[Bug 664699] New: xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: xorg-x11-fonts-update-dirs is not a /bin/sh script

https://bugzilla.redhat.com/show_bug.cgi?id=664699

           Summary: xorg-x11-fonts-update-dirs is not a /bin/sh script
           Product: Fedora
           Version: 14
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: medium
          Priority: low
         Component: xorg-x11-font-utils
        AssignedTo: xgl-maint(a)redhat.com
        ReportedBy: rc040203(a)freenet.de
         QAContact: extras-qa(a)fedoraproject.org
                CC: xgl-maint(a)redhat.com,
                    fonts-bugs(a)lists.fedoraproject.org
    Classification: Fedora


Description of problem:

xorg-x11-fonts-update-dirs is not a /bin/sh script, because this script applies
pushd+popd, which both are non-POSIX-sh-extensions.


Version-Release number of selected component (if applicable):
xorg-x11-font-utils-7.4-3.fc14.x86_64


Steps to Reproduce:
Try to run this scipt with ksh:

# /bin/ksh xorg-x11-fonts-update-dirs --skip-fontscale
/usr/share/X11/fonts/misc
xorg-x11-fonts-update-dirs[54]: pushd: not found [No such file or directory]
xorg-x11-fonts-update-dirs: line 56: popd: not found

Expected results:
A /bin/sh script should be POSIX-sh compliant,

=> either this script should change to using the shebang of a shell 
supporting pushd+popd (e.g. #!/bin/bash) or the script be rewritten (esp. to
not
use pushd+popd)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Matej Cepl <mcepl(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(rc040203@freenet.
                   |                            |de)

--- Comment #1 from Matej Cepl <mcepl(a)redhat.com&gt; 2010-12-21 09:41:40 EST ---
What do you think about the patch in attachment 469993 ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Matej Cepl <mcepl(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Triaged
         AssignedTo|xgl-maint(a)redhat.com        |mcepl(a)redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Ralf Corsepius <rc040203(a)freenet.de&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(rc040203@freenet. |
                   |de)                         |

--- Comment #2 from Ralf Corsepius <rc040203(a)freenet.de&gt; 2010-12-21 10:44:56 EST
---
(In reply to comment #1)
>  What do you think about the patch in attachment 469993 [details] ?
OK, that's the classic subshell pushd/popd approach - I don't any reason why it
shouldn't work. It's advantage is it being usable should once a loop be
introduced around the pushd/popd, it's downside it the subshell having its
price.

An alternative would be the "save pwd" approach.
sav_pwd=`pwd`
cd <somewhere>
do-something
cd ${sav_pwd}
This would avoid the subshell and therefore is somewhat less expensive, but it
would not be suitable for "loops".

AFAIS, ATM the latter alternative would suffice.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

--- Comment #3 from Ralf Corsepius <rc040203(a)freenet.de&gt; 2010-12-21 10:47:00 EST
---
Urgh, this was badly phrased, I was referring to "recursive loops", not
"flat
loops".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-12-22
08:36:25 EST ---
xorg-x11-font-utils-7.4-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xorg-x11-font-utils-7.4-4.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-12-22
14:54:11 EST ---
xorg-x11-font-utils-7.4-4.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xorg-x11-font-utils'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/xorg-x11-font-utils-7.4-4.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-12-24
19:25:44 EST ---
xorg-x11-font-utils-7.4-4.fc14 has been pushed to the Fedora 14 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 664699] xorg-x11-fonts-update-dirs is not a /bin/sh script

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664699

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |xorg-x11-font-utils-7.4-4.f
                   |                            |c14
         Resolution|                            |ERRATA
        Last Closed|                            |2010-12-24 19:25:53

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.