https://bugzilla.redhat.com/show_bug.cgi?id=1124070
Ryan Brown <rybrown(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #8 from Ryan Brown <rybrown(a)redhat.com> ---
New Package SCM Request
=======================
Package Name: pcaro-hermit-fonts
Short Description: Hermit monospace fonts
Upstream URL: https://pcaro.es/p/hermit
Owners: ryansb
Branches: f20 f21 master
InitialCC: fonts-sig i18n-team
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lAwVa3rNTB&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Parag AN(पराग) <panemade(a)gmail.com> ---
Thanks. Looks good now.
No. The fedora-review tool will not fail but will check such mismatch and raise
it an issue.
Package is APPROVED.
Note when you request for Package SCM request, please add InitialCC as
InitialCC: fonts-sig i18n-team
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nk27khkXNF&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
--- Comment #5 from Parag AN(पराग) <panemade(a)gmail.com> ---
Thanks. Few more changes I will suggest
1) We have fedora-review tool which reads the spec and srpm links. This tool
shows issue for spec file name as it will not match to what is packaged inside
srpm. You can have multiple revisions of spec along with version at your web
location but keep only one latest spec with just pcaro-hermit-fonts.spec name.
2) The upstream also uses spelling as "monospace" and not "mono-space". Please
change all such occurrences. Let rpmlint complain it as warning.
3) I think many are familiar with this way to fix DOS line endings
http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
4) with your recent changelog another rpmlint warning has come. When you use
character '%' in %changelog section or in any line which is a comment, always
use it as twice '%%' character.
Else looks good now.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Al06oKApLK&a=cc_unsubscribe