https://bugzilla.redhat.com/show_bug.cgi?id=1514274
--- Comment #33 from Peter Oliver <mavit(a)mavit.org.uk> ---
Thanks for your help, everyone.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
Bug 1514274 depends on bug 1527289, which changed state.
Bug 1527289 Summary: Review Request: nototools - Noto fonts support tools and scripts plus web site generation
https://bugzilla.redhat.com/show_bug.cgi?id=1527289
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #30 from Neal Gompa <ngompa13(a)gmail.com> ---
Review notes:
* Package follows packaging guidelines
* Package denotes licensing correctly and includes license files as appropriate
* Package builds and installs
I see no other issues remaining.
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
--- Comment #29 from Peter Oliver <mavit(a)mavit.org.uk> ---
(In reply to Neal Gompa from comment #28)
> @Peter, can we drop the whole Noto Emoji source requirement from this font
> package now? It looks like the only file you use from it is a single tmpl
> file.
This would be true if https://github.com/googlei18n/noto-emoji/issues/9 was
fixed, but I don’t think anyone is working on that.
For now, also required from Noto Emoji are the Makefile and many of the scripts
the Makefile calls. I haven’t looked into it in detail myself, but Jeremy
Bicha of Ubuntu has recently done the equivalent integration work for the Emoji
Two font, and the patch touches 32 files. It hasn’t yet been accepted by Emoji
Two, because of, as I understand it, its complexity
(https://github.com/EmojiTwo/emojitwo/pull/167)
> Can you instead submit a version of that to the Twemoji GitHub repository
> and use that locally in this package?
We could, yes, but I suspect that Twitter may be reluctant to accept it, since
it would require maintaining this fork of the build system long term. It seems
like too much code to copy and paste from one project to another, to me. Let
me know what you think.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
--- Comment #28 from Neal Gompa <ngompa13(a)gmail.com> ---
@Peter, can we drop the whole Noto Emoji source requirement from this font
package now? It looks like the only file you use from it is a single tmpl file.
Can you instead submit a version of that to the Twemoji GitHub repository and
use that locally in this package?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
--- Comment #27 from Neal Gompa <ngompa13(a)gmail.com> ---
(In reply to Peter Oliver from comment #26)
>
> If I understand correctly, what you're telling me is that I need to include
> both URLs in a single comment, and that I have to label them "Spec URL" and
> "SRPM URL". However, my testing indicates that fedora-review copes fine
> with the URLs being in different comments, and with the string " URL" being
> omitted from the label, so I'm a bit confused.
Don't worry about it. Everything is fine now.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1514274
--- Comment #26 from Peter Oliver <mavit(a)mavit.org.uk> ---
(In reply to Neal Gompa from comment #25)
> But fedora-review will automatically use posts that have the following
> construction:
>
> Spec URL:
> https://pagure.io/twitter-twemoji-fonts/raw/master/f/twitter-twemoji-fonts.
> spec
>
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/mavit/twitter-twemoji-fonts/
> fedora-rawhide-x86_64/00705303-twitter-twemoji-fonts/twitter-twemoji-fonts-2.
> 4.0-1.fc28.src.rpm
If I understand correctly, what you're telling me is that I need to include
both URLs in a single comment, and that I have to label them "Spec URL" and
"SRPM URL". However, my testing indicates that fedora-review copes fine with
the URLs being in different comments, and with the string " URL" being omitted
from the label, so I'm a bit confused.
--
You are receiving this mail because:
You are on the CC list for the bug.