[Bug 1136522] New: Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

Bug ID: 1136522
           Summary: Use HarfBuzz
           Product: Fedora
           Version: 21
         Component: freetype
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail],
                    [e-mail], [e-mail]

Created attachment 933896
  --> https://bugzilla.redhat.com/attachment.cgi?id=933896&action=edit
Use HarfBuzz

Description of problem:
FreeType can use HarfBuzz to provide improved hinting.

The attached patch adds a new with_harfbuzz flag that enables building FreeType
with HarfBuzz support. (It is currently set to 1 but can easily be set to 0 to
disable it by default.)

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

--- Comment #1 from Behdad Esfahbod  ---
Note that this introduces a circular dependency since harfbuzz requires
freetype to build.

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

--- Comment #2 from Marek Kašík  ---
(In reply to Behdad Esfahbod from comment #1)
> Note that this introduces a circular dependency since harfbuzz requires
> freetype to build.

Yes, this is the reason why I haven't turned it on yet. I'll look at it again
once this is solved upstream.

Regards

Marek

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

Michael Kuhn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #933896|0                           |1
        is obsolete|                            |

--- Comment #3 from Michael Kuhn  ---
Created attachment 934031
  --> https://bugzilla.redhat.com/attachment.cgi?id=934031&action=edit
Use HarfBuzz

Yes, building the package(s) from scratch requires one extra step:

1. Build freetype with --define 'with_harfbuzz 0'
2. Build harfbuzz
3. Build freetype

What would be your preferred way of solving this? Loading HarfBuzz dynamically
in FreeType?

I also just noticed that the original patch included a typo for the
"with_harfbuzz 0" case; I am attaching a fixed version for completeness.

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

--- Comment #4 from Michael Kuhn  ---
> What would be your preferred way of solving this? Loading HarfBuzz
> dynamically in FreeType?

… which would obviously not solve the build time issues. Sorry, I guess I was
not fully awake when writing this. :-)

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

--- Comment #5 from Behdad Esfahbod  ---
I don't have a preferred way for this right now unfortunately.  :(

[Bug 1136522] Use HarfBuzz

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1136522

Rex Dieter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FutureFeature
                 CC|                            |[e-mail]
            Version|21                          |rawhide

Red Hat Bugzilla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|Bug Fix                     |Enhancement

--- Comment #6 from Rex Dieter  ---
Fedora has bootstrapping guidelines,
https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping

that could be used here.