Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gfs-fleischman-fonts - GFS Fleischman majuscule Greek font
https://bugzilla.redhat.com/show_bug.cgi?id=454172
mvaliyav@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mvaliyav@redhat.com
------- Additional Comments From mvaliyav@redhat.com 2008-07-09 11:21 EST ------- Unofficial Review
- Rpmlint: OK - Package name: OK - Version: Based on a date: OK - Specfile name: OK - Packaging guidelines: OK - Software license: OK - License field in the spec file: OK - License text from the source zip file included in %doc: OK - The spec file is in American English: OK - The spec file is legible: OK - Source files the same as provided by upstream: NOT OK - Builds into a binary RPM; not architecture dependent, builds ok. OK - No BuildRequires; doesn't depend on any libraries or tools besides the base system: OK - No locales, no need to use %find_lang: OK - No shared libraries: OK - Package not relocatable: OK - Package owns all the created directories: OK - No duplicates in %files: OK - File permissions: OK - Proper %clean section: OK - Consistent macro use: OK - No large documentation files, no -doc subpackage: OK - Font doesn't need %doc files for operation: OK - No header files, no -devel subpackage: OK - No static libraries, no -static subpackage: OK - No dependency on pkgconfig: OK - No .la archives: OK - Not a GUI app, no .desktop file: OK - No other packages' files owned: OK - rm -rf %{buildroot} is run at the beginning of %install: OK - All filenames valid UTF-8: OK
Found few typos in the %description section in spec file.
millenium = millennium sparce = sparse
fonts-bugs@lists.fedoraproject.org