[Bug 1414319] New: freetype ftoption.h evaluates undefined macros

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414319

Bug ID: 1414319
           Summary: freetype ftoption.h evaluates undefined macros
           Product: Fedora
           Version: 25
         Component: freetype
          Severity: low
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail],
                    [e-mail], [e-mail]

Description of problem:
Header file /usr/include/freetype2/freetype/config/ftoption.h evaluates the
numerical value of undefined macro TT_CONFIG_OPTION_SUBPIXEL_HINTING.  This is
somewhat annoying with -Wundef (and a poor practice).

Version-Release number of selected component (if applicable):
freetype-2.6.5-1.fc25

How reproducible:
Always.

Steps to Reproduce:
1. Create file bug.c with the following contents:

#include <ft2build.h>
#include FT_FREETYPE_H

2. Run (with freetype-devel installed)

gcc -Wundef -c $(pkg-config --cflags freetype2) bug.c

Actual results:

In file included from
/usr/include/freetype2/freetype/config/ftconfig-64.h:42:0,
                 from /usr/include/freetype2/freetype/config/ftconfig.h:9,
                 from /usr/include/freetype2/freetype/freetype.h:33,
                 from bug.c:2:
/usr/include/freetype2/freetype/config/ftoption.h:845:5: warning:
"TT_CONFIG_OPTION_SUBPIXEL_HINTING" is not defined [-Wundef]
 #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 1
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/freetype2/freetype/config/ftoption.h:849:5: warning:
"TT_CONFIG_OPTION_SUBPIXEL_HINTING" is not defined [-Wundef]
 #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 2
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected results:
It compiles cleanly.

Additional info:
The numerical evaluation should be guarded by an #ifdef -- AFAICT the expected
behaviour when TT_CONFIG_OPTION_SUBPIXEL_HINTING is undefined is that neither 
TT_SUPPORT_SUBPIXEL_HINTING_INFINALITY nor TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL
should be defined:

--- ftoption.h.orig    2017-01-18 10:41:32.517812687 +0100
+++ ftoption.h    2017-01-18 10:42:16.852136325 +0100
@@ -842,6 +842,7 @@
 #ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
 #define  TT_USE_BYTECODE_INTERPRETER

+#ifdef TT_CONFIG_OPTION_SUBPIXEL_HINTING
 #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 1
 #define  TT_SUPPORT_SUBPIXEL_HINTING_INFINALITY
 #endif
@@ -850,6 +851,7 @@
 #define  TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL
 #endif
 #endif
+#endif

/*

[Bug 1414319] freetype ftoption.h evaluates undefined macros

https://bugzilla.redhat.com/show_bug.cgi?id=1414319

--- Comment #1 from Fedora End Of Life  ---
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

[Bug 1414319] freetype ftoption.h evaluates undefined macros

https://bugzilla.redhat.com/show_bug.cgi?id=1414319

Fedora End Of Life  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |EOL
        Last Closed|                            |2017-12-12 05:52:25

--- Comment #2 from Fedora End Of Life  ---
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.