shotcut: problem with unpacked files, after changing from qmake to cmake

[Martin Gansser]

Hi,

I have changed the rpm spec file for shotcut [1] from qmake to cmake.
Now the program compiles to the end and fails when packaging it with the following error message:

Processing files: shotcut-debuginfo-22.06.07-1.fc36.x86_64
Provides: debuginfo(build-id) = 50b1149507c39b9362a2aebf0ccee415e68665a6 shotcut-debuginfo = 22.06.07-1.fc36 shotcut-debuginfo(x86-64) = 22.06.07-1.fc36
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Recommends: shotcut-debugsource(x86-64) = 22.06.07-1.fc36
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/martin/rpmbuild/BUILDROOT/shotcut-22.06.07-1.fc36.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
   /usr/lib/libCuteLogger.so

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
   /usr/lib/libCuteLogger.so

How can I solve this error ?

[1] https://martinkg.fedorapeople.org/ErrorReports/shotcut/shotcut.spec

[Dan Horák]

On Thu, 23 Jun 2022 16:59:29 -0000
"Martin Gansser"  wrote:
> Hi,
>
> I have changed the rpm spec file for shotcut [1] from qmake to cmake.
> Now the program compiles to the end and fails when packaging it with the following error message:
>
> Processing files: shotcut-debuginfo-22.06.07-1.fc36.x86_64
> Provides: debuginfo(build-id) = 50b1149507c39b9362a2aebf0ccee415e68665a6 shotcut-debuginfo = 22.06.07-1.fc36 shotcut-debuginfo(x86-64) = 22.06.07-1.fc36
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Recommends: shotcut-debugsource(x86-64) = 22.06.07-1.fc36
> Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/martin/rpmbuild/BUILDROOT/shotcut-22.06.07-1.fc36.x86_64
> error: Installed (but unpackaged) file(s) found:
>    /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
>    /usr/lib/libCuteLogger.so
>
> RPM build errors:
>     Installed (but unpackaged) file(s) found:
>    /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
>    /usr/lib/libCuteLogger.so
>
> How can I solve this error ?

I think there should be a switch to build the internal libs like the
CuteLogger as static libs, so they are folded into the main binary,
like in
https://src.fedoraproject.org/rpms/qmapshack/blob/rawhide/f/qmapshack.spec#_...

Dan
> [1] https://martinkg.fedorapeople.org/ErrorReports/shotcut/shotcut.spec
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Martin Gansser]

I have set the option, see cmake command, but unfortunately it does not change the error message.

+ /usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS:BOOL=OFF -DUNIX_STRUCTURE=1 -GNinja -DCMAKE_BUILD_TYPE=Release -DSHOTCUT_VERSION=22.06.07 -DDEFINES+=SHOTCUT_NOUPGRADE

[Ralf Corsépius]

Am 23.06.22 um 18:59 schrieb Martin Gansser:
> Hi,
>
> I have changed the rpm spec file for shotcut [1] from qmake to cmake.
> Now the program compiles to the end and fails when packaging it with the following error message:
>
> Processing files: shotcut-debuginfo-22.06.07-1.fc36.x86_64
> Provides: debuginfo(build-id) = 50b1149507c39b9362a2aebf0ccee415e68665a6 shotcut-debuginfo = 22.06.07-1.fc36 shotcut-debuginfo(x86-64) = 22.06.07-1.fc36
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Recommends: shotcut-debugsource(x86-64) = 22.06.07-1.fc36
> Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/martin/rpmbuild/BUILDROOT/shotcut-22.06.07-1.fc36.x86_64
> error: Installed (but unpackaged) file(s) found:
>     /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
>     /usr/lib/libCuteLogger.so
>
> RPM build errors:
>      Installed (but unpackaged) file(s) found:
>     /usr/lib/debug/usr/lib/libCuteLogger.so-22.06.07-1.fc36.x86_64.debug
>     /usr/lib/libCuteLogger.so
>
> How can I solve this error ?

Looks like this package's cmake stuff doesn't honor %{__libdir}

Ralf

[Martin Gansser]

I thought so too and I will try the following command:

sed -i -e 's|DESTINATION lib|DESTINATION ${LIB_INSTALL_DIR}|'g CuteLogger/CMakeLists.txt