Re: Request to review a MinGW subpackges in libsodium
On Mon, Aug 21, 2023 at 03:17:21PM +0200, Marián Konček wrote:
I opened a PR adding mingw subpackages to libsodium according to my
best
knowledge (which is not too large related to mingw packaging):
https://src.fedoraproject.org/rpms/libsodium/pull-request/3
I talked with the maintainer and it could be accepted, but I would like
someone more experienced from https://fedoraproject.org/wiki/MinGW to take a
look and tell me if i missed some simplifications.
The main item I see missing is conditionalization of the sub-packages,
which is important for anyone wanting to rebuild the same spec on
RHEL/EPEL where most of mingw is not present.
https://docs.fedoraproject.org/en-US/packaging-guidelines/MinGW/#_disabli...
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|