On 01/10/2018 09:33 AM, Miro Hrončok wrote:
On 10.1.2018 03:16, Nick Coghlan wrote:
On 10 January 2018 at 11:30, Jason L Tibbitts III tibbs@math.uh.edu wrote:
In the end I just can't shake the notion that it's bad to have some random non-python-related environment variable basically breaking python.
Aye, I think you've hit on the main problem: if this is keyed off RPM_BUILD_ROOT, then it will impact all RPM builds that use a Fedora provided Python, even if those builds aren't otherwise required to abide by Fedora's policy settings.
With a dedicated environment variable instead, that could look something like:
PYTHON_DISALLOW_AMBIGUOUS_VERSION=0 # Status quo PYTHON_DISALLOW_AMBIGUOUS_VERSION=1 # Hard failure PYTHON_DISALLOW_AMBIGUOUS_VERSION=warn # Deprecation warning
This sounds good to me. It didn't occur to me that we can actually set a dedicated env vars for our builds (which is even better).
+1, let's do that!
This would potentially even make it possible to push this patch to upstream. >
Then either Koji can take care of setting that (and including it in the mock configs it generates), or else it can be included in some of the Fedora specific RPM setup.
Cheers, Nick.
P.S. Using a dedicated environment variable would have the advantage of allowing anyone else that *also* wanted to look for and remove unqualified references to Python 2 to set it.