10:05 a.m.
Hi,
The webkit2gtk5.0 package in rawhide will be removed and replaced by
webkitgtk6.0. Affected packages that will need to be patched to use the
new API version and rebuilt are: evolution-data-server, gnome-builder,
gnome-initial-setup. My plan is to handle all of these builds in a
side tag.
Normally we're supposed to wait a week before making changes like this,
but since I have commit access to care for all the dependent packages,
I assume it should be fine to go ahead sooner.
Michael
10:10 a.m.
On 11/11/2022 17:05, Michael Catanzaro wrote:
The webkit2gtk5.0 package in rawhide will be removed and replaced by
webkitgtk6.0. Affected packages that will need to be patched to use the
new API version
What about packages that use dlopen() like Telegram Desktop?
--
Sincerely,
Vitaly Zaitsev (vitaly(a)easycoding.org)
10:44 a.m.
On Fri, Nov 11 2022 at 05:10:03 PM +0100, Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
What about packages that use dlopen() like Telegram Desktop?
Uh-oh, I didn't know about this... I did a repoquery and thought only
GNOME was using it. :/ I guess this will require more coordination
after all. I found the code here:
https://github.com/desktop-app/lib_webview/blob/b9d81771a0d7533dd07805f06...
We'll have to patch the library version there and include a new build
in the side tag. And it's going to break on every WebKitGTK update for
the foreseeable future, because webkitgtk-6.0 will receive regular
soname bumps until the API stabilizes. (The goal is for it to be stable
in time for Fedora 38, but we'll see.)
I also see that it's loading deprecated JavaScriptCore APIs, which will
break soon, see https://bugs.webkit.org/show_bug.cgi?id=232078.
I wasn't able to figure out the Fedora package name to contact the
maintainer. Do you know what it is?
Michael
10:48 a.m.
On Fri, Nov 11, 2022 at 11:44 AM Michael Catanzaro <mcatanzaro(a)gnome.org> wrote:
On Fri, Nov 11 2022 at 05:10:03 PM +0100, Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
> What about packages that use dlopen() like Telegram Desktop?
Uh-oh, I didn't know about this... I did a repoquery and thought only
GNOME was using it. :/ I guess this will require more coordination
after all. I found the code here:
https://github.com/desktop-app/lib_webview/blob/b9d81771a0d7533dd07805f06...
We'll have to patch the library version there and include a new build
in the side tag. And it's going to break on every WebKitGTK update for
the foreseeable future, because webkitgtk-6.0 will receive regular
soname bumps until the API stabilizes. (The goal is for it to be stable
in time for Fedora 38, but we'll see.)
I also see that it's loading deprecated JavaScriptCore APIs, which will
break soon, see https://bugs.webkit.org/show_bug.cgi?id=232078.
I wasn't able to figure out the Fedora package name to contact the
maintainer. Do you know what it is?
It's telegram-desktop in RPM Fusion:
https://koji.rpmfusion.org/koji/packageinfo?packageID=492
Vitaly Zaitsev is the maintainer. It hasn't moved to Fedora yet.
--
真実はいつも一つ！/ Always, there's only one truth!
11:06 a.m.
OK, I think telegram-desktop will actually be fine with no changes.
When webkit2gtk-5.0 disappears, it should just fall back to using the
stable GTK 3 version instead of the unstable GTK 4 version, which is
probably a good idea for now. If you really want to use the GTK 4 API
before it's stable, then LoadLibrary(webkit2gtk,
"libwebkit2gtk-5.0.so.0" should be replaced with
"libwebkitgtk-6.0.so.0" and incremented for each soname bump. There
will probably be 2-3 soname bumps during the next 3 months or so. Then,
if all goes well, we'll freeze the API and it will be stable
indefinitely, like webkit2gtk-4.0 and webkit2gtk-4.1 are currently. If
I fail to stabilize the API, then it could take until F39, but the goal
is F38.
I also looked closer at the code that's loading deprecated JSC
functions that will be removed, and it looks like it's designed to load
the deprecated functions only if the newer alternatives are not
available at all, so I think that should be fine too.
Michael
6:50 a.m.
On 11/11/2022 18:06, Michael Catanzaro wrote:
OK, I think telegram-desktop will actually be fine with no changes.
When
webkit2gtk-5.0 disappears, it should just fall back to using the stable
GTK 3 version instead of the unstable GTK 4 version, which is probably a
good idea for now.
It has an explicit dependency: Requires: webkit2gtk5.0%{?_isa}.
There will probably be 2-3 soname bumps during the next 3 months or
so. Then, if all goes well, we'll freeze the API and it will be stable indefinitely,
like webkit2gtk-4.0 and webkit2gtk-4.1 are currently.
Thanks for the information. Switched to webkit2gtk4.1:
https://github.com/rpmfusion/telegram-desktop/commit/f7faaf463172ee60e045...
--
Sincerely,
Vitaly Zaitsev (vitaly(a)easycoding.org)
10:02 a.m.
On Sat, Nov 12 2022 at 01:50:28 PM +0100, Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
Thanks for the information. Switched to webkit2gtk4.1:
https://github.com/rpmfusion/telegram-desktop/commit/f7faaf463172ee60e045...
OK, thanks, that should be good.
For now, this API change will only land in rawhide. It will arrive in
F37 in March when I update it from WebKitGTK 2.38 -> 2.40. I *usually*
would update F36 as well at the same time, but maybe it will be more
convenient to just leave F36 on WebKitGTK 2.38 forever due to the GTK 4
API change.
Michael
6:15 a.m.
On Fri, Nov 11, 2022 at 3:52 PM Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
On 11/11/2022 17:48, Neal Gompa wrote:
> Vitaly Zaitsev is the maintainer. It hasn't moved to Fedora yet.
We can't move yet, because it requires openh264-devel at the build time.
We should be able to convert that to a dlopen dependency. Which part
of it uses it directly instead of through ffmpeg?
--
真実はいつも一つ！/ Always, there's only one truth!
6:28 a.m.
On 12/11/2022 13:15, Neal Gompa wrote:
We should be able to convert that to a dlopen dependency.
It should be done in Google's WebRTC upstream.
Which part of it uses it directly instead of through ffmpeg?
tg_owt, fork of WebRTC.
--
Sincerely,
Vitaly Zaitsev (vitaly(a)easycoding.org)
2:49 p.m.
On 11/11/2022 17:44, Michael Catanzaro wrote:
I wasn't able to figure out the Fedora package name to contact
the
maintainer. Do you know what it is?
I'm maintainer of the telegram-desktop package in RPM Fusion.
We'll have to patch the library version there and include a new
build in the side tag. And it's going to break on every WebKitGTK update for the
foreseeable future, because webkitgtk-6.0 will receive regular soname bumps until the API
stabilizes.
What about webkit2gtk4.0? Telegram Desktop can use 4.0, 4.1 and 5.0.
Maybe it will be better to switch to webkit2gtk4.x?
--
Sincerely,
Vitaly Zaitsev (vitaly(a)easycoding.org)
5:40 p.m.
On Fri, Nov 11 2022 at 09:49:29 PM +0100, Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
What about webkit2gtk4.0? Telegram Desktop can use 4.0, 4.1 and 5.0.
Maybe it will be better to switch to webkit2gtk4.x?
Better to use -4.1. That is stable and should be safe to depend on.
The -4.0 is the obsolete libsoup 2 version. It's stable too, but it's
time for it to go away.
Michael
3:02 p.m.
On Fri, Nov 11, 2022, 17:06 Michael Catanzaro <mcatanzaro(a)gnome.org> wrote:
Hi,
The webkit2gtk5.0 package in rawhide will be removed and replaced by
webkitgtk6.0. Affected packages that will need to be patched to use the
new API version and rebuilt are: evolution-data-server, gnome-builder,
gnome-initial-setup. My plan is to handle all of these builds in a
side tag.
Have you considered bumping to 5.1, 5.2, 5.3 ... for the continuously
expected ABI / soname bumps? Jumping by a major version number every time
kind of pollutes the namespace upwards unnecessarily, doesn't it?
Fabio
(sent from my phone, sorry for possible html formatting)
Normally we're supposed to wait a week before making changes like
this,
but since I have commit access to care for all the dependent packages,
I assume it should be fine to go ahead sooner.
Michael
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
5:39 p.m.
On Fri, Nov 11 2022 at 10:02:39 PM +0100, Fabio Valentini
<decathorpe(a)gmail.com> wrote:
Have you considered bumping to 5.1, 5.2, 5.3 ... for the continuously
expected ABI / soname bumps? Jumping by a major version number every
time kind of pollutes the namespace upwards unnecessarily, doesn't it?
Hi, there are no plans for any more API version bumps. It should stay
at -6.0 from now on. Hopefully.
Michael
566
days inactive
569
days old
14 comments
5 participants
participants (5)
-
Fabio Valentini -
Kevin Kofler -
Michael Catanzaro -
Neal Gompa -
Vitaly Zaitsev