gammaray includes qt-everywhere-opensource-src-4.8.5.tar.gz

[Michael Schwendt]

>  Source1:       
> http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-%{...
>
>  BuildRequires:  qt-devel
>  BuildRequires:  qt-devel-private 
>  %cmake .
> -DQT_PRIVATE_INCLUDE_DIR=%{_builddir}/qt-everywhere-opensource-src-%{qt_version}/include/QtCore
The package review request was: https://bugzilla.redhat.com/905615

Nowhere is a comment that explains why the 230MB Qt source is included
and used to build GammaRay. Isn't qt-devel-private sufficient?

[Dan Vratil]

On Saturday 14 of December 2013 19:21:14 Michael Schwendt wrote:
>  > Source1:       
>  > http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-%{
>  > qt_version}.tar.gz
>  > 
>  > BuildRequires:  qt-devel
>  > BuildRequires:  qt-devel-private
>  > 
>  > %cmake .
>  > -DQT_PRIVATE_INCLUDE_DIR=%{_builddir}/qt-everywhere-opensource-src-%{qt_v
>  > ersion}/include/QtCore
>  The package review request was: https://bugzilla.redhat.com/905615
>  
>  Nowhere is a comment that explains why the 230MB Qt source is included
>  and used to build GammaRay. Isn't qt-devel-private sufficient? 
Hi

it's documented in the very first comment:

"The package needs Qt sources in order to have access to some private headers 
and sources that are not available in qt-devel and qt-devel-private"

AFAIK this was necessary to get access to QPainter internals for painter 
introspection, and to build against the harfbuzz shipped with Qt sources.

Cheers,
Dan

-- 
Daniel Vrátil
KDE Desktop Team
Associate Software Engineer, Red Hat, Inc.

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348

[Kevin Kofler]

Daniel Vrátil wrote:
>  it's documented in the very first comment:
>  
>  "The package needs Qt sources in order to have access to some private
>  headers and sources that are not available in qt-devel and
>  qt-devel-private"
>  
>  AFAIK this was necessary to get access to QPainter internals for painter
>  introspection, and to build against the harfbuzz shipped with Qt sources. 
Argh!!! How the heck did that pass review?

If gammaray needs some extra headers in qt-devel-private, we can probably 
arrange for that (though building against qt-devel-private is rightfully 
frowned upon in the first place, it's called "private" for a reason! But 
this being a tool to poke in the internals of Qt apps, it's probably 
reasonable for that tool to use the private headers), but bundling the whole 
Qt tarball is entirely unacceptable (and against our bundling policies), 
even if you only use small parts of it (which is even more dangerous: Who 
guarantees that the private undocumented APIs in your bundled headers match 
the ones in the installed version of Qt?).

        Kevin Kofler