Need assistance to build ispc

[Luya Tshimbalanga]

Hello team,

Latest release of ispc failed to build due gcc=c++ related errors as 
seen on scratch build: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=45567484

Here is the source located on https://src.fedoraproject.org/rpms/ispc/

Patch welcome to fix the issue.

-- 
Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer

[Kalev Lember]

On Tue, Jun 9, 2020 at 9:02 AM Luya Tshimbalanga <luya(a)fedoraproject.org&gt;
wrote:

>  Hello team,
>
>  Latest release of ispc failed to build due gcc=c++ related errors as
>  seen on scratch build:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=45567484
>
>  Here is the source located on https://src.fedoraproject.org/rpms/ispc/
>
>  Patch welcome to fix the issue.
>  
Hi Luya,

The build failed with:

/builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp: In member
function 'void BitcodeLib::print() const':
/builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp:61:17: error:
variable 'type' set but not used [-Werror=unused-but-set-variable]
   61 |     const char *type = nullptr;
      |                 ^~~~

cc1plus: all warnings being treated as errors

This means that the compiler found a tiny warning (unused variable) but
treated it as an error because -Werror was set during the build.

What I would suggest doing is looking into how to disable -Werror (it could
be a configure flag) or perhaps just patch it out for Fedora builds.
-Werror makes a lot of sense for upstream where they want to make sure
their build is warning free, but not for a distribution such as Fedora
where we introduce new changes all the time (each compiler adds new,
different warnings) and it's completely impractical to have -Werror turned
on for our builds.

Hope this helps,
Kalev

[Tom Hughes]

On 09/06/2020 08:54, Kalev Lember wrote:

>  The build failed with:
>  
>  /builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp: In member function 'void
> BitcodeLib::print() const':
>  /builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp:61:17: error: variable
> 'type' set but not used [-Werror=unused-but-set-variable]
>      61 |     const char *type = nullptr;
>         |                 ^~~~
>  
>  cc1plus: all warnings being treated as errors
>  
>  This means that the compiler found a tiny warning (unused variable) but 
>  treated it as an error because -Werror was set during the build.
>  
>  What I would suggest doing is looking into how to disable -Werror (it 
>  could be a configure flag) or perhaps just patch it out for Fedora 
>  builds. -Werror makes a lot of sense for upstream where they want to 
>  make sure their build is warning free, but not for a distribution such 
>  as Fedora where we introduce new changes all the time (each compiler 
>  adds new, different warnings) and it's completely impractical to have 
>  -Werror turned on for our builds. 
It looks to be hard coded upstream:

   https://github.com/ispc/ispc/blob/master/CMakeLists.txt#L355

so I suggest just adding to the spec:

   sed -i 's| -Werror | |g' CMakeLists.txt

as is already being done for some other flags.

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Luya Tshimbalanga]

On 2020-06-09 1:06 a.m., Tom Hughes via devel wrote:
>  It looks to be hard coded upstream:
>
>    https://github.com/ispc/ispc/blob/master/CMakeLists.txt#L355
>
>  so I suggest just adding to the spec:
>
>    sed -i 's| -Werror | |g' CMakeLists.txt
>
>  as is already being done for some other flags.
>
>  Tom
>  
Thank you Kaleb and Tom. Your suggestion fixed the issue.

-- 
Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer