fedora-review seam to not work 8-(

[J. Scheurich]

Hi,

(Since the last update ?) fedora-review seams to not work:

I am using

Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm

as a testcase.

$ fedora-review -n vcglib
INFO: Processing local files: vcglib
INFO: Getting .spec and .srpm Urls from : Local files in /home/home/mufti
INFO:   --> SRPM url: file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
INFO:   --> Spec url: file:///home/home/mufti/vcglib.spec
INFO: Using review directory: /home/home/mufti/review-vcglib
ERROR: Exception down the road... (logs in
/home/mufti/.cache/fedora-review.log)

$ less /home/mufti/.cache/fedora-review.log
...
08-05 17:51 root         INFO       --> SRPM url:
file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
08-05 17:51 root         INFO       --> Spec url:
file:///home/home/mufti/vcglib.spec
08-05 17:51 root         DEBUG    find_urls completed: 0.010
08-05 17:51 root         INFO     Using review directory:
/home/home/mufti/review-vcglib
08-05 17:51 root         DEBUG    Avoiding init of working mock root
08-05 17:51 root         DEBUG    Url download completed: 2.384
08-05 15:51 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
line 99, in _do_report
...

As far as i understand python, a "BaseException" occored in
self._do_run(outfile):

$ less +232 /usr/lib/python3.7/site-packages/FedoraReview/review_helper.py
       self.log.debug("fedora-review %s %s started", __version__,
BUILD_FULL)
        self.log.debug("Command  line: %s", " ".join(sys.argv))
        try:
            rcode = 0
            self._do_run(outfile)
        except ReviewError as err:
            if isinstance(err, SpecParseReviewError):
                nvr = _Nvr(self.bug.get_name())
                result = SimpleTestResult(
                    "SpecFileParseError", "Can't parse the spec file:
",
str(err)
                )
                write_xml_report(nvr, [result])
            self.log.debug("ReviewError: %s", str(err), exc_info=True)
            if not err.silent:
                msg = "ERROR: " + str(err)
                if err.show_logs:
                    msg += " (logs in " + Settings.session_log + ")"
                self.log.error(msg)
            rcode = err.exitcode
        except BaseException:
            self.log.debug("Exception down the road...", exc_info=True)
            self.log.error(
                "Exception down the road... (logs in %s)",
Settings.session_log
...

What i am doing wrong ?

so long
MUFTI

[Robert-André Mauchin]

On Monday, 5 August 2019 18:05:27 CEST J. Scheurich wrote:
>  Hi,
>  
>  (Since the last update ?) fedora-review seams to not work:
>  
>  I am using
>  
>  Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
>  SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
>  
>  as a testcase.
>  
>  $ fedora-review -n vcglib
>  INFO: Processing local files: vcglib
>  INFO: Getting .spec and .srpm Urls from : Local files in /home/home/mufti
>  INFO:   --> SRPM url: file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
>  INFO:   --> Spec url: file:///home/home/mufti/vcglib.spec
>  INFO: Using review directory: /home/home/mufti/review-vcglib
>  ERROR: Exception down the road... (logs in
>  /home/mufti/.cache/fedora-review.log)
>  
>  $ less /home/mufti/.cache/fedora-review.log
>  ...
>  08-05 17:51 root         INFO       --> SRPM url:
>  file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
>  08-05 17:51 root         INFO       --> Spec url:
>  file:///home/home/mufti/vcglib.spec
>  08-05 17:51 root         DEBUG    find_urls completed: 0.010
>  08-05 17:51 root         INFO     Using review directory:
>  /home/home/mufti/review-vcglib
>  08-05 17:51 root         DEBUG    Avoiding init of working mock root
>  08-05 17:51 root         DEBUG    Url download completed: 2.384
>  08-05 15:51 root         DEBUG    Exception down the road...
>  Traceback (most recent call last):
>    File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  line 236, in run
>      self._do_run(outfile)
>    File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  line 226, in _do_run
>      self._do_report(outfile)
>    File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  line 99, in _do_report
>  ...
>  
>  As far as i understand python, a "BaseException" occored in
>  self._do_run(outfile):
>  
>  $ less +232 /usr/lib/python3.7/site-packages/FedoraReview/review_helper.py
>         self.log.debug("fedora-review %s %s started", __version__,
>  BUILD_FULL)
>          self.log.debug("Command  line: %s", " ".join(sys.argv))
>          try:
>              rcode = 0
>              self._do_run(outfile)
>          except ReviewError as err:
>              if isinstance(err, SpecParseReviewError):
>                  nvr = _Nvr(self.bug.get_name())
>                  result = SimpleTestResult(
>                      "SpecFileParseError", "Can't parse the spec file:
> ",
>  str(err)
>                  )
>                  write_xml_report(nvr, [result])
>              self.log.debug("ReviewError: %s", str(err), exc_info=True)
>              if not err.silent:
>                  msg = "ERROR: " + str(err)
>                  if err.show_logs:
>                      msg += " (logs in " + Settings.session_log + ")"
>                  self.log.error(msg)
>              rcode = err.exitcode
>          except BaseException:
>              self.log.debug("Exception down the road...", exc_info=True)
>              self.log.error(
>                  "Exception down the road... (logs in %s)",
>  Settings.session_log
>  ...
>  
>  What i am doing wrong ?
>  
>  so long
>  MUFTI 

What's your version of fedora-review? You should have 0.7.2

Name         : fedora-review
Version      : 0.7.2
Release      : 1.fc30
Architecture : noarch
Size         : 626 k
Source       : fedora-review-0.7.2-1.fc30.src.rpm
Repository   : @System
From repo    : updates-testing
Summary      : Review tool for fedora rpm packages
URL          : https://pagure.io/FedoraReview
License      : GPLv2+
Description  : This tool automates much of the dirty work when reviewing a 
package
             : for the Fedora Package Collection like:
             : 
             :     * Downloading SRPM & SPEC.
             :     * Download upstream source
             :     * Check md5sums
             :     * Build and install package in mock.
             :     * Run rpmlint.
             :     * Generate a review template, which becomes the starting
             :       point for the review work.
             : 
             : The tool is composed of plugins, one for each supported 
language.
             : As of today, there is plugins for C/C++, Ruby, java, R, perl 
and
             : python.  There is also support for external tests that can be 
written
             : in a simple way in bash.


For you SPEC, you should drop the main package and only keep devel.

Drop %global debug_package %{nil}  and make the package noarch

Use: Source: https://github.com/cnr-isti-vclab/vcglib/archive/v%{version}/%
{name}-%{version}.tar.gz

Use cp -a to keep attributes: cp -ar vcg img %{buildroot}%{_includedir}/%
{name}

Remove trailing spaces

Not needed:
mkdir -p %{buildroot}%{_docdir}/%{name}
install -m 644 README.md %{buildroot}%{_docdir}/%{name} 

It is automatically included when you use %doc README.md

[Elliott Sales de Andrade]

On Mon, 5 Aug 2019 at 18:28, Robert-André Mauchin <zebob.m(a)gmail.com&gt; wrote:
>  On Monday, 5 August 2019 18:05:27 CEST J. Scheurich wrote:
>  > Hi,
>  >
>  > (Since the last update ?) fedora-review seams to not work:
>  >
>  > I am using
>  >
>  > Spec URL: ftp://ftp.ourproject.org/pub/wdune/vcglib.spec
>  > SRPM URL: ftp://ftp.ourproject.org/pub/wdune/vcglib-1.0.1-1.src.rpm
>  >
>  > as a testcase.
>  >
>  > $ fedora-review -n vcglib
>  > INFO: Processing local files: vcglib
>  > INFO: Getting .spec and .srpm Urls from : Local files in /home/home/mufti
>  > INFO:   --> SRPM url: file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
>  > INFO:   --> Spec url: file:///home/home/mufti/vcglib.spec
>  > INFO: Using review directory: /home/home/mufti/review-vcglib
>  > ERROR: Exception down the road... (logs in
>  > /home/mufti/.cache/fedora-review.log)
>  >
>  > $ less /home/mufti/.cache/fedora-review.log
>  > ...
>  > 08-05 17:51 root         INFO       --> SRPM url:
>  > file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
>  > 08-05 17:51 root         INFO       --> Spec url:
>  > file:///home/home/mufti/vcglib.spec
>  > 08-05 17:51 root         DEBUG    find_urls completed: 0.010
>  > 08-05 17:51 root         INFO     Using review directory:
>  > /home/home/mufti/review-vcglib
>  > 08-05 17:51 root         DEBUG    Avoiding init of working mock root
>  > 08-05 17:51 root         DEBUG    Url download completed: 2.384
>  > 08-05 15:51 root         DEBUG    Exception down the road...
>  > Traceback (most recent call last):
>  >   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  > line 236, in run
>  >     self._do_run(outfile)
>  >   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  > line 226, in _do_run
>  >     self._do_report(outfile)
>  >   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
>  > line 99, in _do_report
>  > ...
>  >
>  > As far as i understand python, a "BaseException" occored in
>  > self._do_run(outfile):
>  >
>  > $ less +232 /usr/lib/python3.7/site-packages/FedoraReview/review_helper.py
>  >        self.log.debug("fedora-review %s %s started", __version__,
>  > BUILD_FULL)
>  >         self.log.debug("Command  line: %s", " ".join(sys.argv))
>  >         try:
>  >             rcode = 0
>  >             self._do_run(outfile)
>  >         except ReviewError as err:
>  >             if isinstance(err, SpecParseReviewError):
>  >                 nvr = _Nvr(self.bug.get_name())
>  >                 result = SimpleTestResult(
>  >                     "SpecFileParseError", "Can't parse the spec
> file: ",
>  > str(err)
>  >                 )
>  >                 write_xml_report(nvr, [result])
>  >             self.log.debug("ReviewError: %s", str(err), exc_info=True)
>  >             if not err.silent:
>  >                 msg = "ERROR: " + str(err)
>  >                 if err.show_logs:
>  >                     msg += " (logs in " + Settings.session_log +
> ")"
>  >                 self.log.error(msg)
>  >             rcode = err.exitcode
>  >         except BaseException:
>  >             self.log.debug("Exception down the road...", exc_info=True)
>  >             self.log.error(
>  >                 "Exception down the road... (logs in %s)",
>  > Settings.session_log
>  > ...
>  >
>  > What i am doing wrong ?
>  >
>  > so long
>  > MUFTI
>
>
>  What's your version of fedora-review? You should have 0.7.2
>
>  Name         : fedora-review
>  Version      : 0.7.2
>  Release      : 1.fc30
>  Architecture : noarch
>  Size         : 626 k
>  Source       : fedora-review-0.7.2-1.fc30.src.rpm
>  Repository   : @System
>  From repo    : updates-testing
>  Summary      : Review tool for fedora rpm packages
>  URL          : https://pagure.io/FedoraReview
>  License      : GPLv2+
>  Description  : This tool automates much of the dirty work when reviewing a
>  package
>               : for the Fedora Package Collection like:
>               :
>               :     * Downloading SRPM & SPEC.
>               :     * Download upstream source
>               :     * Check md5sums
>               :     * Build and install package in mock.
>               :     * Run rpmlint.
>               :     * Generate a review template, which becomes the starting
>               :       point for the review work.
>               :
>               : The tool is composed of plugins, one for each supported
>  language.
>               : As of today, there is plugins for C/C++, Ruby, java, R, perl
>  and
>               : python.  There is also support for external tests that can be
>  written
>               : in a simple way in bash.
>
>
>  For you SPEC, you should drop the main package and only keep devel.
>
>  Drop %global debug_package %{nil}  and make the package noarch
>  
No, that's not correct. Header-only libraries are not noarch, and
disable debug packages.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_hea...

> Use: Source: https://github.com/cnr-isti-vclab/vcglib/archive/v%{version}/%
> {name}-%{version}.tar.gz
>
> Use cp -a to keep attributes: cp -ar vcg img %{buildroot}%{_includedir}/%
> {name}
>
> Remove trailing spaces
>
> Not needed:
> mkdir -p %{buildroot}%{_docdir}/%{name}
> install -m 644 README.md %{buildroot}%{_docdir}/%{name}
>
> It is automatically included when you use %doc README.md
>

[Kevin Kofler]

Elliott Sales de Andrade wrote:
>  No, that's not correct. Header-only libraries are not noarch,
> and
>  disable debug packages.
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_hea...
Well, if there is no testsuite and if the headers are truly
architecture-independent (those are the 2 reasons the guidelines give as a
rationale for making the packages arch-specific), I don't see a good reason
to not make them noarch.

        Kevin Kofler

[Kevin Kofler]

I wrote:

>  Elliott Sales de Andrade wrote:
> > No, that's not correct. Header-only libraries are not noarch, and
> > disable debug packages.
> >
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_hea...
>  
>  Well, if there is no testsuite and if the headers are truly
>  architecture-independent (those are the 2 reasons the guidelines give as a
>  rationale for making the packages arch-specific), I don't see a good
>  reason to not make them noarch. 
PS: Oh, and if there is a testsuite to run, but the headers are truly
architecture-independent, you can at least make -devel a noarch subpackage
with no ill effect. (Koji will actually fail your build if the headers turn
out to differ based on the architecture, so it is perfectly safe, unlike the
completely noarch package where it is up to YOU to ensure that the contents
do not depend on the architecture.) Though, in that case (noarch
subpackage), you do still have to disable the debug packages explicitly.

        Kevin Kofler

[Vitaly Zaitsev]

On 06.08.2019 2:06, Kevin Kofler wrote:
>  Well, if there is no testsuite and if the headers are truly
>  architecture-independent 
Most of modern C++ header-only libraries provides Cmake scripts. Such
scripts will be installed to %{_libdir}/cmake/foo. That's why they
cannot be noarch.

-- 
Sincerely,
  Vitaly Zaitsev (vitaly(a)easycoding.org)

[Kevin Kofler]

Vitaly Zaitsev via devel wrote:
>  Most of modern C++ header-only libraries provides Cmake scripts.
> Such
>  scripts will be installed to %{_libdir}/cmake/foo. That's why they
>  cannot be noarch. 
CMake will actually also find the scripts if you install them to 
%{_datadir}/cmake/foo. And if (and ONLY if) there is nothing
architecture-dependent in them, that is exactly where they belong. 
Unfortunately, the only package other than CMake itself that I see using 
this on my system is bash-completion.

        Kevin Kofler

[J. Scheurich]

>  What's your version of fedora-review? You should have 0.7.2
>
>  Name         : fedora-review
>  Version      : 0.7.2
>  Release      : 1.fc30 
$ fedora-review -V
fedora-review version 0.7.2 65d36bb 2019-04-09 16:30:26 -0400
external plugins:
$ yum info fedora-review
...
Installed Packages
Name         : fedora-review
Version      : 0.7.2
Release      : 2.fc31
Architecture : noarch
Size         : 626 k
Source       : fedora-review-0.7.2-2.fc31.src.rpm

This seams to be release 2.fc31, not 1.fc30.

Should i try to install 1.fc30 ?

so long
MUFTI

[Robert-André Mauchin]

On Tuesday, 6 August 2019 05:47:58 CEST J. Scheurich wrote:
>  > What's your version of fedora-review? You should have 0.7.2
>  >
>  >
>  >
>  > Name         : fedora-review
>  > Version      : 0.7.2
>  > Release      : 1.fc30
>  
>  $ fedora-review -V
>  fedora-review version 0.7.2 65d36bb 2019-04-09 16:30:26 -0400
>  external plugins:
>  $ yum info fedora-review
>  ...
>  Installed Packages
>  Name         : fedora-review
>  Version      : 0.7.2
>  Release      : 2.fc31
>  Architecture : noarch
>  Size         : 626 k
>  Source       : fedora-review-0.7.2-2.fc31.src.rpm
>  
>  This seams to be release 2.fc31, not 1.fc30.
>  
>  Should i try to install 1.fc30 ?
>   
No they're the same. I ran f-r 0.7.2 on your SPEC and SRPM with no issue, so I 
don't know çrom where the error is coming. Try cleaning your chroot.

mock -scrub=all

[J. Scheurich]

| Try cleaning your chroot.
>  mock -scrub=all 
This do not help on fedora 31 8-(

$  fedora-review -n vcglib
INFO: Processing local files: vcglib
INFO: Getting .spec and .srpm Urls from : Local files in /home/home/mufti
INFO:   --> SRPM url: file:///home/home/mufti/vcglib-1.0.1-1.src.rpm
INFO:   --> Spec url: file:///home/home/mufti/vcglib.spec
INFO: Using review directory: /home/home/mufti/review-vcglib
ERROR: Exception down the road... (logs in /root/.cache/fedora-review.log)

so long
MUFTI