Bad exit status from %prep during chmod -Rf a+rX,u+w,g-w,o-w . (coreutils 9.0-1.fc36)

[Miro Hrončok]

Hello,

I see this failure in dnf in Copr and Koji:

https://copr.fedorainfracloud.org/coprs/churchyard/patch251/build/2872812/
https://koji.fedoraproject.org/koji/taskinfo?taskID=76673401

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.x8REO2
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf dnf-4.9.0
+ /usr/bin/gzip -dc /builddir/build/SOURCES/dnf-4.9.0.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd dnf-4.9.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
error: Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
     Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)

I am perplexed with the error.

Could it be some problem with updated coreutils?

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok

[František Šumšal]

I just noticed that as well in our systemd Packit runs, but so far
only on i386, because the repos for x86_64, ppc64le, and aarch64
are still on coreutils-8.32-32.fc36 (whereas i386 has
coreutils-9.0-1.fc36):

https://copr.fedorainfracloud.org/coprs/packit/systemd-systemd-20923/buil...
https://copr.fedorainfracloud.org/coprs/packit/systemd-systemd-20926/buil...

On 10/4/21 11:57, Miro Hrončok wrote:
>  Hello,
>  
>  I see this failure in dnf in Copr and Koji:
>  
>  https://copr.fedorainfracloud.org/coprs/churchyard/patch251/build/2872812/
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=76673401
>  
>  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.x8REO2
>  + umask 022
>  + cd /builddir/build/BUILD
>  + cd /builddir/build/BUILD
>  + rm -rf dnf-4.9.0
>  + /usr/bin/gzip -dc /builddir/build/SOURCES/dnf-4.9.0.tar.gz
>  + /usr/bin/tar -xof -
>  + STATUS=0
>  + '[' 0 -ne 0 ']'
>  + cd dnf-4.9.0
>  + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
>  error: Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
>       Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
>  
>  I am perplexed with the error.
>  
>  Could it be some problem with updated coreutils?
>  
>  
-- 
PGP Key ID: 0xFB738CE27B634E4B

[Miro Hrončok]

On 04. 10. 21 13:33, František Šumšal wrote:
>  I just noticed that as well in our systemd Packit runs, but so far
>  only on i386, because the repos for x86_64, ppc64le, and aarch64
>  are still on coreutils-8.32-32.fc36 (whereas i386 has
>  coreutils-9.0-1.fc36) 
That's because by defalt, Copr uses the Koji repo for i686 and the composed 
repo for other arches.

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok

[František Šumšal]

Some results from a Rawhide podman container:

# koji download-build --arch x86_64 coreutils-9.0-1.fc36
# dnf install coreutils-common-9.0-1.fc36.x86_64.rpm coreutils-9.0-1.fc36.x86_64.rpm
# git clone https://github.com/systemd/systemd
# cd systemd
# /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
# echo $?
1

Some further tests:
# mkdir test
# cd test
# touch testfile
# ln -s testfile testlink
# strace /usr/bin/chmod -R a+rX,u+w,g-w,o-w .
execve("/usr/bin/chmod", ["/usr/bin/chmod", "-R",
"a+rX,u+w,g-w,o-w", "."], 0x7ffc34d019f8 /* 13 vars */) = 0
brk(NULL)                               = 0x5589ce102000
arch_prctl(0x3001 /* ARCH_??? */, 0x7ffc33618dc0) = -1 EINVAL (Invalid argument)
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or
directory)

... snip ...

newfstatat(AT_FDCWD, ".", {st_mode=S_IFDIR|0755, st_size=4096, ...}, 0) = 0
fchmodat(AT_FDCWD, ".", 0755)           = 0
openat(AT_FDCWD, ".", O_RDONLY|O_NOCTTY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 3
newfstatat(3, "", {st_mode=S_IFDIR|0755, st_size=4096, ...}, AT_EMPTY_PATH) =
0
fcntl(3, F_GETFL)                       = 0x18800 (flags
O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY)
fcntl(3, F_SETFD, FD_CLOEXEC)           = 0
fcntl(3, F_DUPFD_CLOEXEC, 3)            = 4
getdents64(3, 0x5589ce107120 /* 4 entries */, 32768) = 112
getdents64(3, 0x5589ce107120 /* 0 entries */, 32768) = 0
close(3)                                = 0
newfstatat(4, "testfile", {st_mode=S_IFREG|0644, st_size=0, ...},
AT_SYMLINK_NOFOLLOW) = 0
fchmodat(4, "testfile", 0644)           = 0
newfstatat(4, "testlink", {st_mode=S_IFLNK|0777, st_size=8, ...},
AT_SYMLINK_NOFOLLOW) = 0
close(4)                                = 0
close(1)                                = 0
close(2)                                = 0
exit_group(1)                           = ?
+++ exited with 1 +++


However, with coreutils-8.32-31.fc36.x86_64:
# strace /usr/bin/chmod -R a+rX,u+w,g-w,o-w .
... snip ...
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=346132, ...}, AT_EMPTY_PATH) =
0
mmap(NULL, 346132, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fcfb35d2000
close(3)                                = 0
umask(000)                              = 022
newfstatat(AT_FDCWD, ".", {st_mode=S_IFDIR|0755, st_size=4096, ...}, 0) = 0
fchmodat(AT_FDCWD, ".", 0755)           = 0
openat(AT_FDCWD, ".", O_RDONLY|O_NOCTTY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 3
newfstatat(3, "", {st_mode=S_IFDIR|0755, st_size=4096, ...}, AT_EMPTY_PATH) =
0
fcntl(3, F_GETFL)                       = 0x18800 (flags
O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY)
fcntl(3, F_SETFD, FD_CLOEXEC)           = 0
fcntl(3, F_DUPFD_CLOEXEC, 3)            = 4
getdents64(3, 0x55748075f120 /* 4 entries */, 32768) = 112
getdents64(3, 0x55748075f120 /* 0 entries */, 32768) = 0
close(3)                                = 0
newfstatat(4, "testfile", {st_mode=S_IFREG|0644, st_size=0, ...},
AT_SYMLINK_NOFOLLOW) = 0
fchmodat(4, "testfile", 0644)           = 0
newfstatat(4, "testlink", {st_mode=S_IFLNK|0777, st_size=8, ...},
AT_SYMLINK_NOFOLLOW) = 0
close(4)                                = 0
close(1)                                = 0
close(2)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++


On 10/4/21 13:33, František Šumšal wrote:
>  I just noticed that as well in our systemd Packit runs, but so far
>  only on i386, because the repos for x86_64, ppc64le, and aarch64
>  are still on coreutils-8.32-32.fc36 (whereas i386 has
>  coreutils-9.0-1.fc36):
>  
>  https://copr.fedorainfracloud.org/coprs/packit/systemd-systemd-20923/buil...
>  https://copr.fedorainfracloud.org/coprs/packit/systemd-systemd-20926/buil...
>  
>  On 10/4/21 11:57, Miro Hrončok wrote:
> > Hello,
> >
> > I see this failure in dnf in Copr and Koji:
> >
> > https://copr.fedorainfracloud.org/coprs/churchyard/patch251/build/2872812/
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=76673401
> >
> > Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.x8REO2
> > + umask 022
> > + cd /builddir/build/BUILD
> > + cd /builddir/build/BUILD
> > + rm -rf dnf-4.9.0
> > + /usr/bin/gzip -dc /builddir/build/SOURCES/dnf-4.9.0.tar.gz
> > + /usr/bin/tar -xof -
> > + STATUS=0
> > + '[' 0 -ne 0 ']'
> > + cd dnf-4.9.0
> > + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> > error: Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
> >      Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
> >
> > I am perplexed with the error.
> >
> > Could it be some problem with updated coreutils?
> >
>  
>  
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
>  
>  
-- 
PGP Key ID: 0xFB738CE27B634E4B

[Kamil Dudka]

On Monday, October 4, 2021 1:58:36 PM CEST František Šumšal wrote:
>  Some results from a Rawhide podman container:
>  
>  # koji download-build --arch x86_64 coreutils-9.0-1.fc36
>  # dnf install coreutils-common-9.0-1.fc36.x86_64.rpm
>  coreutils-9.0-1.fc36.x86_64.rpm 
 # git clone
>  https://github.com/systemd/systemd
>  # cd systemd
>  # /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
>  # echo $?
>  1
>  
>  Some further tests:
>  # mkdir test
>  # cd test
>  # touch testfile
>  # ln -s testfile testlink
>  # strace /usr/bin/chmod -R a+rX,u+w,g-w,o-w . 
Thanks for the reproducer!  This is a regression in the new upstream release:

   
https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v9.0-...

I will submit a fixed build as soon as I figure out how to untag the broken one:

$ koji untag-build f36 coreutils-8.32-31.fc36
2021-10-04 14:16:18,518 [ERROR] koji: ActionNotAllowed: tag requires autosign permission

Kamil

[Miro Hrončok]

On 04. 10. 21 14:16, Kamil Dudka wrote:
>  On Monday, October 4, 2021 1:58:36 PM CEST František Šumšal wrote:
> > Some results from a Rawhide podman container:
> >
> > # koji download-build --arch x86_64 coreutils-9.0-1.fc36
> > # dnf install coreutils-common-9.0-1.fc36.x86_64.rpm
> > coreutils-9.0-1.fc36.x86_64.rpm
>    # git clone
> > https://github.com/systemd/systemd
> > # cd systemd
> > # /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> > # echo $?
> > 1
> >
> > Some further tests:
> > # mkdir test
> > # cd test
> > # touch testfile
> > # ln -s testfile testlink
> > # strace /usr/bin/chmod -R a+rX,u+w,g-w,o-w .
>  
>  Thanks for the reproducer!  This is a regression in the new upstream release:
>  
>      
> https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v9.0-...
>  
>  I will submit a fixed build as soon as I figure out how to untag the broken one:
>  
>  $ koji untag-build f36 coreutils-8.32-31.fc36
>  2021-10-04 14:16:18,518 [ERROR] koji: ActionNotAllowed: tag requires autosign permission
It seems that coreutils itself builds fine, so there should be no need to untag 
jut to fix it:

https://koji.fedoraproject.org/koji/taskinfo?taskID=76673896

But either way: to answer the question how to untag: You need a releng person 
to do that.

Or, you can:

  $ fedpkg request-side-tag
  $ koji tag f36-build-side-12345 coreutils-8.32-32.fc36
  $ koji wait-repo f36-build-side-12345 --build coreutils-8.32-32.fc36
  $ fedpkg build --target f36-build-side-12345

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok

[Kamil Dudka]

On Monday, October 4, 2021 2:24:22 PM CEST Miro Hrončok wrote:
>  On 04. 10. 21 14:16, Kamil Dudka wrote:
>  > On Monday, October 4, 2021 1:58:36 PM CEST František Šumšal wrote:
>  >> Some results from a Rawhide podman container:
>  >> 
>  >> # koji download-build --arch x86_64 coreutils-9.0-1.fc36
>  >> # dnf install coreutils-common-9.0-1.fc36.x86_64.rpm
>  >> coreutils-9.0-1.fc36.x86_64.rpm
>  >> 
>  >   # git clone
>  >> 
>  >> https://github.com/systemd/systemd
>  >> # cd systemd
>  >> # /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
>  >> # echo $?
>  >> 1
>  >> 
>  >> Some further tests:
>  >> # mkdir test
>  >> # cd test
>  >> # touch testfile
>  >> # ln -s testfile testlink
>  >> # strace /usr/bin/chmod -R a+rX,u+w,g-w,o-w .
>  > 
>  > Thanks for the reproducer!  This is a regression in the new upstream release:
>  >      https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v
>  >      9.0-2-ge8b56ebd536> 
>  > I will submit a fixed build as soon as I figure out how to untag the
>  > broken one:
>  > 
>  > $ koji untag-build f36 coreutils-8.32-31.fc36
>  > 2021-10-04 14:16:18,518 [ERROR] koji: ActionNotAllowed: tag requires
>  > autosign permission
>  It seems that coreutils itself builds fine, so there should be no need to
>  untag jut to fix it:
>  
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=76673896 
Indeed.  A build of coreutils with the upstream fix applied is running:

    https://koji.fedoraproject.org/koji/buildinfo?buildID=1840134

Thank you both for the help and sorry for the breakage!

Kamil

>  But either way: to answer the question how to untag: You need a
> releng
>  person to do that.
>  
>  Or, you can:
>  
>    $ fedpkg request-side-tag
>    $ koji tag f36-build-side-12345 coreutils-8.32-32.fc36
>    $ koji wait-repo f36-build-side-12345 --build coreutils-8.32-32.fc36
>    $ fedpkg build --target f36-build-side-12345

[Kamil Dudka]

On Monday, October 4, 2021 11:57:14 AM CEST Miro Hrončok wrote:
>  Hello,
>  
>  I see this failure in dnf in Copr and Koji:
>  
>  https://copr.fedorainfracloud.org/coprs/churchyard/patch251/build/2872812/
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=76673401
>  
>  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.x8REO2
>  + umask 022
>  + cd /builddir/build/BUILD
>  + cd /builddir/build/BUILD
>  + rm -rf dnf-4.9.0
>  + /usr/bin/gzip -dc /builddir/build/SOURCES/dnf-4.9.0.tar.gz
>  + /usr/bin/tar -xof -
>  + STATUS=0
>  + '[' 0 -ne 0 ']'
>  + cd dnf-4.9.0
>  + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
>  error: Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
>       Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
>  
>  I am perplexed with the error.
>  
>  Could it be some problem with updated coreutils? 
Yes.  The error message comes from rpmbuild.  chmod itself did not provide
any diagnostic message.  Is it possible to trigger the error locally?

Kamil

[Miro Hrončok]

On 04. 10. 21 14:06, Kamil Dudka wrote:
>  On Monday, October 4, 2021 11:57:14 AM CEST Miro Hrončok wrote:
> > Hello,
> >
> > I see this failure in dnf in Copr and Koji:
> >
> > https://copr.fedorainfracloud.org/coprs/churchyard/patch251/build/2872812/
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=76673401
> >
> > Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.x8REO2
> > + umask 022
> > + cd /builddir/build/BUILD
> > + cd /builddir/build/BUILD
> > + rm -rf dnf-4.9.0
> > + /usr/bin/gzip -dc /builddir/build/SOURCES/dnf-4.9.0.tar.gz
> > + /usr/bin/tar -xof -
> > + STATUS=0
> > + '[' 0 -ne 0 ']'
> > + cd dnf-4.9.0
> > + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> > error: Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
> >       Bad exit status from /var/tmp/rpm-tmp.x8REO2 (%prep)
> >
> > I am perplexed with the error.
> >
> > Could it be some problem with updated coreutils?
>  
>  Yes.  The error message comes from rpmbuild.  chmod itself did not provide
>  any diagnostic message.  Is it possible to trigger the error locally? 
František was able to:

https://lists.fedoraproject.org/archives/list/[e-mail].o...

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok