Re: fedpkg: Failed to get repository name from Git url or pushurl

[Vít Ondruch]

Dne 01. 03. 23 v 23:39 Kenneth Goldman napsal(a):
> There's Source, Source0, and sources.  What are the definitions?

I think that older RPMs require the numbered version, e.g. `Source0`. 
With advent of macros such as `%autosetup`, the number is not as 
important as it used to be and therefore it has been made optional.
> The tutorial doesn't have a 'sources' tag.  Is that documented?  What should
> it be?

I think there is no `sources` tag (while there is `%{sources}` macro 
available later). You can either use `Source` tag multiple times or use 
the appropriately numbered `Source0`, `Source1`, etc.
> The hello tutorial has the URL to the tarball in Source: but it also says to
> use
> wget to download the tarball.

While RPM has the ability to download the sources, it is disabled by 
default for security reasons. You simply don't want to download random 
stuff from Internet.

https://stackoverflow.com/questions/33177450/how-do-i-get-rpmbuild-to-downlo...
> The Source: tag doesn't have a list of files, just a pointer to the tarball.

One file per one `Source` line, but you probably understand it based on 
the above.
> Maybe I'm way off and the source files should be in a local directory?

I believe so in the context of the tutorial and usage of `$ fedpkg 
--release f36 mockbuild` command.
> When I run the tutorial, it seems to ignore the .spec URLs and uses the local
> tarball.  How does it even know what the name is?  Does it default to the
> file name of the URL?

Yes
> How does it know what to build.  Does it default to configure;make
> or something similar?

You have to specify what are the right steps in the `%build` sections. 
In the tutorial, there are used the `%configure` + `%make_build` macros. 
You could use different build commands (or macros) at this place.

Vít
> > -----Original Message-----
> > From: Artur Frenszek-Iwicki 
> > Sent: Wednesday, February 15, 2023 11:43 AM
> > To: [e-mail]
> > Subject: [EXTERNAL] RE: fedpkg: Failed to get repository name from Git url
> > or
> > pushurl
> > > Should that tutorial work?  Is it perhaps obsolete?
> >
> > I'd say the opposite of obsolete - it's been updated to suggest using fedpkg
> > all
> > along the way, instead of the old rpmbuild tools. But it looks like it
> > wasn't tested
> > enough to make sure everything works.
> > > My newbie understanding is that fedpkg should get the source from the
> > > Source0 location and then follow the build instructions.
> > > Is that even close?
> >
> > This is a bit complicated. When the package is being built, the list of
> > files is taken
> > from the Source: tags in the spec file. However, fedpkg keeps a separate
> > file,
> > "sources" (no extension), where it lists files uploaded to the Fedora build
> > cache.
> > The justification is that keeping source tarballs in the repository is a bad
> > idea,
> > since these files can be really large (1GiB+ for game packages), so they're
> > stored
> > in a cache instead, and the repository contains only this "sources" file
> > with
> > references to said cache. (That being said, you totally can store source
> > files in
> > the repo - this is often done with stuff like non-standard Fedora configs.)
> >
> > As for the "get the source from the Source0 location" bit - no.
> > fedpkg will not download stuff from Source: tags for you, only the files
> > listed in
> > the "sources" file.
> >
> > Since my impression is that you want to start experimenting with RPM
> > packaging
> > in general, and not specifically fedpkg - I'll do a bit shameless
> > self-promotion
> > and link to an article on RPM packaging that I wrote some time ago:
> > https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__blog.svgames.pl_article_basics-2Dof-2Drpm-
> > 2Dpackaging&d=DwIGaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=DZCVG43VcL8GTneMZb8k8lEwb-O1GZktFfre1-mlmiA&m=9Zy9a03p-
> > GrtnAWrzttvmFX417X-C_WOqiZaQjuiv1_bUC_4VaDdANM4Cv-
> > tBucE&s=ASsrhv8V4Ny-ujgsugfcpVLuPxEn578dICLLMx2eCYw&e=
> >
> > In this article, I show how to build RPM packages using the traditional
> > rpmbuild
> > workflow. If you're just starting out with writing specs and such, it should
> > get
> > you started enough to make switching to fedpkg later down the road a no-
> > brainer.
> >
> > A.FI.
> > _______________________________________________
> > devel mailing list -- [e-mail] To unsubscribe send an
> > email
> > to [e-mail]
> > Fedora Code of Conduct: https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__docs.fedoraproject.org_en-2DUS_project_code-2Dof-
> > 2Dconduct_&d=DwIGaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=DZCVG43VcL8GTneMZb8k8lEwb-O1GZktFfre1-mlmiA&m=9Zy9a03p-
> > GrtnAWrzttvmFX417X-C_WOqiZaQjuiv1_bUC_4VaDdANM4Cv-
> > tBucE&s=wgOj27qGmhxD4UEHTA9tqeAxCZr1ny0rPQPs7_SL2sQ&e=
> > List Guidelines: https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__fedoraproject.org_wiki_Mailing-5Flist-
> > 5Fguidelines&d=DwIGaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=DZCVG43VcL8GTneMZb8k8lEwb-O1GZktFfre1-mlmiA&m=9Zy9a03p-
> > GrtnAWrzttvmFX417X-C_WOqiZaQjuiv1_bUC_4VaDdANM4Cv-
> > tBucE&s=cUh77057QE1qCKOAD2SsxFWibxM8aVJOWgvcuUM-1gI&e=
> > List Archives: https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__lists.fedoraproject.org_archives_list_devel-
> > 40lists.fedoraproject.org&d=DwIGaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=DZCVG43VcL8GTneMZb8k8lEwb-O1GZktFfre1-mlmiA&m=9Zy9a03p-
> > GrtnAWrzttvmFX417X-C_WOqiZaQjuiv1_bUC_4VaDdANM4Cv-
> > tBucE&s=WiPTKb0_GaJvkLzQAdKMxWSDV8qxvKguXGSvM8rqGgs&e=
> > Do not reply to spam, report it:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__pagure.io_fedora-
> > 2Dinfrastructure_new-5Fissue&d=DwIGaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=DZCVG43VcL8GTneMZb8k8lEwb-O1GZktFfre1-mlmiA&m=9Zy9a03p-
> > GrtnAWrzttvmFX417X-C_WOqiZaQjuiv1_bUC_4VaDdANM4Cv-
> > tBucE&s=FMdlaadJWvp1hsOPTPqy9TFB3w7W_bTTIYBf553Savs&e=
> >
> > devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> > Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

fedpkg: Failed to get repository name from Git url or pushurl -> %build

[Kenneth Goldman]

> -----Original Message-----
> From: Vít Ondruch 
> Sent: Thursday, March 2, 2023 6:58 AM
> To: [e-mail]
> Subject: [EXTERNAL] Re: fedpkg: Failed to get repository name from Git url or
> pushurl
> > How does it know what to build.  Does it default to configure;make
> > or something similar?
>
> You have to specify what are the right steps in the `%build` sections.
> In the tutorial, there are used the `%configure` + `%make_build` macros.
> You could use different build commands (or macros) at this place.

This really helps!

Let's see if I have this right ...

%build
%configure
%make_build

are not three separate steps.  %build is the overall step, and the next two lines
are the build steps.  The blank line terminates the %build.  Correct?

Where are the macros defined?  I.e., %configure probably expands
to ./configure and %make_build to make.

If I want to add some arguments to configure, and add an autoreconf
step before configure, how would I do that?