--module-name or some other name?

[Chenxiong Qi]

Hi all,

Recently, a fedpkg global option --module-name could confuse some
packagers easily because word "module" is sort of ambiguous with the
module introduced by Fedora Modularity. This option is used for
specifying a repository name manually instead of guessing that from git
push URL or the macro name in SPEC file.

To avoid the confusion, it would be nice to use another name, for
example --repository-name or --package-name. I personally prefer the
former one. Before making this change, I'd like to hear your thoughts.

*  --repository-name or --package-name, what do you think which one is
proper for fedpkg?

* How do you use --module-name in your practice?

* Is it ok to rename it directly without keeping the original name, or
to keep --module-name for a period of time so that you have time to
migrate to new name?

Thanks.

Regards,
Chenxiong Qi

[Pierre-Yves Chibon]

On Wed, Mar 14, 2018 at 08:56:32PM +0800, Chenxiong Qi wrote:
>  Hi all,
>  
>  Recently, a fedpkg global option --module-name could confuse some
>  packagers easily because word "module" is sort of ambiguous with the
>  module introduced by Fedora Modularity. This option is used for
>  specifying a repository name manually instead of guessing that from git
>  push URL or the macro name in SPEC file.
>  
>  To avoid the confusion, it would be nice to use another name, for
>  example --repository-name or --package-name. I personally prefer the
>  former one. Before making this change, I'd like to hear your thoughts.
>  
>  *  --repository-name or --package-name, what do you think which one is
>  proper for fedpkg?
>  
>  * How do you use --module-name in your practice?
>  
>  * Is it ok to rename it directly without keeping the original name, or
>  to keep --module-name for a period of time so that you have time to
>  migrate to new name? 
What about simply --name ? (Possibly together with a --namespace?)

I'd still include the --module-name though if possible deprecate it in the UI.


Pierre

[Randy Barlow]

On 03/14/2018 08:56 AM, Chenxiong Qi wrote:
>  *  --repository-name or --package-name, what do you think which one
> is
>  proper for fedpkg? 
Either of these will do. I also like pingou's --name suggestion, with a
--namespace (defaulting to rpm would be nice).

I'd probably have a slight preference for --package-name, but they would
all do.

>  * Is it ok to rename it directly without keeping the original name,
> or
>  to keep --module-name for a period of time so that you have time to
>  migrate to new name? 
I recommend keeping it for a time, but printing a warning when it is
used that suggests to use the new flag.

[Clement Verna]

On 14 March 2018 at 15:09, Randy Barlow <bowlofeggs(a)fedoraproject.org&gt; wrote:
>  On 03/14/2018 08:56 AM, Chenxiong Qi wrote:
> > *  --repository-name or --package-name, what do you think which one is
> > proper for fedpkg?
>
>  Either of these will do. I also like pingou's --name suggestion, with a
>  --namespace (defaulting to rpm would be nice).
>
>  I'd probably have a slight preference for --package-name, but they would
>  all do.
>
> > * Is it ok to rename it directly without keeping the original name, or
> > to keep --module-name for a period of time so that you have time to
> > migrate to new name?
>
>  I recommend keeping it for a time, but printing a warning when it is
>  used that suggests to use the new flag. 
You can add a sleep(10) to --module-name that's the best way to
deprecate a command :)

> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org

[Michal Novotny]

Hello,

On Wed, Mar 14, 2018 at 1:56 PM, Chenxiong Qi <cqi(a)redhat.com&gt; wrote:
>  Hi all,
>
>  Recently, a fedpkg global option --module-name could confuse some
>  packagers easily because word "module" is sort of ambiguous with the
>  module introduced by Fedora Modularity. This option is used for
>  specifying a repository name manually instead of guessing that from git
>  push URL or the macro name in SPEC file.
>
>  To avoid the confusion, it would be nice to use another name, for
>  example --repository-name or --package-name. I personally prefer the
>  former one. Before making this change, I'd like to hear your thoughts.
>
>  *  --repository-name or --package-name, what do you think which one is
>  proper for fedpkg?
>
>  * How do you use --module-name in your practice?
>
>  * Is it ok to rename it directly without keeping the original name, or
>  to keep --module-name for a period of time so that you have time to
>  migrate to new name? 
If there needs to be a change at all, then I would also be in favor of
--name and --namespace.

clime

>
> Thanks.
>
> Regards,
> Chenxiong Qi
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org