Failure on fedora default backgrounds

[Luya Tshimbalanga]

Hello team,

It appears a change within %{_kde4_datadir} macro caused failures on 
Rawhide affecting default Fedora backgrounds starting from 21.
Could someone from KDE SIG address that issue? Thanks.

Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:

''''

RPM build errors:
error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
     File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
Child return code was: 1
'''

Reference:
[1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075

[JT]

I'm the maintainer of those packages and I've already spoken with Neal
Gompa about it.  I'll be addressing that when I get home, I'm on the road
until Sunday without my system to be able to commit to fix it.
JT

On Thu, Feb 1, 2024 at 8:26 PM Luya Tshimbalanga 
wrote:
> Hello team,
>
> It appears a change within %{_kde4_datadir} macro caused failures on
> Rawhide affecting default Fedora backgrounds starting from 21.
> Could someone from KDE SIG address that issue? Thanks.
>
> Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
>
> ''''
>
> RPM build errors:
> error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
>     File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> Child return code was: 1
> '''
>
> Reference:
> [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
>
> --
> Luya Tshimbalanga
> Fedora Design Team
> Fedora Design Suite maintainer
>
> --
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue

[Mamoru TASAKA]

Luya Tshimbalanga wrote on 2024/02/02 10:25:
> Hello team,
>
> It appears a change within %{_kde4_datadir} macro caused failures on Rawhide affecting default Fedora backgrounds starting from 21.
> Could someone from KDE SIG address that issue? Thanks.
>
> Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
>
> ''''
>
> RPM build errors:
> error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
>      File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> Child return code was: 1
> '''
>
> Reference:
> [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075

I am not KDE sig member, but the above failure is most likely due to
the following change:

https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...

/usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir} macro definition)
was moved from kde-filesystem.rpm to kde4-filesystem.rpm .

Regards,
Mamoru

[Neal Gompa]

On Fri, Feb 2, 2024 at 2:04 AM Mamoru TASAKA  wrote:
> Luya Tshimbalanga wrote on 2024/02/02 10:25:
> > Hello team,
> >
> > It appears a change within %{_kde4_datadir} macro caused failures on Rawhide affecting default Fedora backgrounds starting from 21.
> > Could someone from KDE SIG address that issue? Thanks.
> >
> > Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
> >
> > ''''
> >
> > RPM build errors:
> > error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> >      File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > Child return code was: 1
> > '''
> >
> > Reference:
> > [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
>
> I am not KDE sig member, but the above failure is most likely due to
> the following change:
>
> https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...
>
> /usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir} macro definition)
> was moved from kde-filesystem.rpm to kde4-filesystem.rpm .

Yes, just add "BuildRequires: kde4-filesystem".

On 2024-02-01 11:26 p.m., Neal Gompa  wrote:
> On Fri, Feb 2, 2024 at 2:04 AM Mamoru TASAKA  wrote:
> > Luya Tshimbalanga wrote on 2024/02/02 10:25:
> > > Hello team,
> > >
> > > It appears a change within %{_kde4_datadir} macro caused failures on Rawhide affecting default Fedora backgrounds starting from 21.
> > > Could someone from KDE SIG address that issue? Thanks.
> > >
> > > Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
> > >
> > > ''''
> > >
> > > RPM build errors:
> > > error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > >       File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > Child return code was: 1
> > > '''
> > >
> > > Reference:
> > > [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
> >
> > I am not KDE sig member, but the above failure is most likely due to
> > the following change:
> >
> > https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...
> >
> > /usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir} macro definition)
> > was moved from kde-filesystem.rpm to kde4-filesystem.rpm .
>
> Yes, just add "BuildRequires: kde4-filesystem".

Thank you all for the solution. I notice I lack access to commit changes on  f21-backgrounds so proven packagers are welcome to do so. Thanks

[Dan Horák]

On Fri, 2 Feb 2024 23:55:43 -0800
[e-mail] wrote:
> On 2024-02-01 11:26 p.m., Neal Gompa  wrote:
> > On Fri, Feb 2, 2024 at 2:04 AM Mamoru TASAKA  wrote:
> > > Luya Tshimbalanga wrote on 2024/02/02 10:25:
> > > > Hello team,
> > > >
> > > > It appears a change within %{_kde4_datadir} macro caused failures on Rawhide affecting default Fedora backgrounds starting from 21.
> > > > Could someone from KDE SIG address that issue? Thanks.
> > > >
> > > > Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
> > > >
> > > > ''''
> > > >
> > > > RPM build errors:
> > > > error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > >       File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > > Child return code was: 1
> > > > '''
> > > >
> > > > Reference:
> > > > [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
> > >
> > > I am not KDE sig member, but the above failure is most likely due to
> > > the following change:
> > >
> > > https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...
> > >
> > > /usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir} macro definition)
> > > was moved from kde-filesystem.rpm to kde4-filesystem.rpm .
> >
> > Yes, just add "BuildRequires: kde4-filesystem".
>
> Thank you all for the solution. I notice I lack access to commit changes on  f21-backgrounds so proven packagers are welcome to do so. Thanks

update to f21-backgrounds pushed into git, no build started

Is the Requires: kde-filesystem in the "kde" subpackage still correct?

Dan

[Luya Tshimbalanga]

On 2024-02-03 01:27, Dan Horák wrote:
> On Fri, 2 Feb 2024 23:55:43 -0800
> [e-mail]  wrote:
> > On 2024-02-01 11:26 p.m., Neal Gompa  wrote:
> > > On Fri, Feb 2, 2024 at 2:04 AM Mamoru TASAKA  wrote:
> > > > Luya Tshimbalanga wrote on 2024/02/02 10:25:
> > > > > Hello team,
> > > > >
> > > > > It appears a change within %{_kde4_datadir} macro caused failures on Rawhide affecting default Fedora backgrounds starting from 21.
> > > > > Could someone from KDE SIG address that issue? Thanks.
> > > > >
> > > > > Here is an extract of failure[1]  on for f35-backgrounds built on Rawhide:
> > > > >
> > > > > ''''
> > > > >
> > > > > RPM build errors:
> > > > > error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > > >        File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > > > Child return code was: 1
> > > > > '''
> > > > >
> > > > > Reference:
> > > > > [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
> > > >
> > > > I am not KDE sig member, but the above failure is most likely due to
> > > > the following change:
> > > >
> > > > https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...
> > > >
> > > > /usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir} macro definition)
> > > > was moved from kde-filesystem.rpm to kde4-filesystem.rpm .
> > >
> > > Yes, just add "BuildRequires: kde4-filesystem".
> >
> > Thank you all for the solution. I notice I lack access to commit changes on  f21-backgrounds so proven packagers are welcome to do so. Thanks
>
> update to f21-backgrounds pushed into git, no build started
>
> Is the Requires: kde-filesystem in the "kde" subpackage still correct?

Yes, "Requires: kde-filesystem" is still correct after running a built test.

[JT]

> Thank you all for the solution. I notice I lack access to commit changes

on  f21-backgrounds so proven packagers are welcome to do so. Thanks

As I said on Monday when I replied to this ticket, I had talked to Neil
about this already, I'm aware of the fix, but as I am on the road and
unable to push commits to the repo until Sunday.  Others are certainly
allowed to step in and fix it, if they want to, but the problem isn't being
ignored. I simply dont have the keys on my laptop I have with me to be able
to push changes right now.  I will have that ability tomorrow.  If you
cannot wait another day for this, then by all means someone else can push
the fix to the various repos.
JT

On Sat, Feb 3, 2024 at 2:56 AM  wrote:
> On 2024-02-01 11:26 p.m., Neal Gompa  wrote:
> > On Fri, Feb 2, 2024 at 2:04 AM Mamoru TASAKA
>
> wrote:
> > > Luya Tshimbalanga wrote on 2024/02/02 10:25:
> > > > Hello team,
> > > >
> > > > It appears a change within %{_kde4_datadir} macro caused failures on
>
> Rawhide affecting default Fedora backgrounds starting from 21.
> > > > Could someone from KDE SIG address that issue? Thanks.
> > > >
> > > > Here is an extract of failure[1]  on for f35-backgrounds built on
>
> Rawhide:
> > > > ''''
> > > >
> > > > RPM build errors:
> > > > error: File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > >       File must begin with "/": %{_kde4_datadir}/wallpapers/F35/
> > > > Child return code was: 1
> > > > '''
> > > >
> > > > Reference:
> > > > [1]https://koji.fedoraproject.org/koji/taskinfo?taskID=112257075
> > >
> > > I am not KDE sig member, but the above failure is most likely due to
> > > the following change:
>
> https://src.fedoraproject.org/rpms/kde-filesystem/c/3cc17949d085bef5476638f2...
> > > /usr/lib/rpm/macros.d/macros.kde4 (which provides %{_kde4_datadir}
>
> macro definition)
> > > was moved from kde-filesystem.rpm to kde4-filesystem.rpm .
> >
> > Yes, just add "BuildRequires: kde4-filesystem".
>
> Thank you all for the solution. I notice I lack access to commit changes
> on  f21-backgrounds so proven packagers are welcome to do so. Thanks
> --
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue

[Luya Tshimbalanga]

On 2024-02-03 12:12, JT wrote:
> > Thank you all for the solution. I notice I lack access to commit
>
> changes on  f21-backgrounds so proven packagers are welcome to do so. 
> Thanks
>
> As I said on Monday when I replied to this ticket, I had talked to 
> Neil about this already, I'm aware of the fix, but as I am on the road 
> and unable to push commits to the repo until Sunday. Others are 
> certainly allowed to step in and fix it, if they want to, but the 
> problem isn't being ignored. I simply dont have the keys on my laptop 
> I have with me to be able to push changes right now.  I will have that 
> ability tomorrow.  If you cannot wait another day for this, then by 
> all means someone else can push the fix to the various repos.
> JT

Ok. You can check if the commits are correct on repository and adjust 
accordingly. Thanks.