Help us test FedoraReview on Python 3

[Miro Hrončok]

There is a FedoraReview port to Python 3 that needs real word testing by packagers.

When you use FedoraReview, please use the Python 3 port instead to help us find 
bugs.

Instructions are at https://pagure.io/FedoraReview/pull-request/312 -> the first 
comment of my Pull Request is updated with up to date instructions.

Thanks,
-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Dridi Boukelmoune]

On Fri, Mar 8, 2019 at 12:29 PM Miro Hrončok <mhroncok(a)redhat.com&gt; wrote:
>  There is a FedoraReview port to Python 3 that needs real word testing by packagers.
>
>  When you use FedoraReview, please use the Python 3 port instead to help us find
>  bugs.
>
>  Instructions are at https://pagure.io/FedoraReview/pull-request/312 -> the first
>  comment of my Pull Request is updated with up to date instructions. 
Attached are two automated reviews for playerctl, and if you look at
the diff you may notice that some things are gone, some things moved
around, some false-positives disappeared and when order of things
changed (eg. listing sub-packages) it's usually better now.

Overall it seems in better shape and more in sync with the current
guidelines, so thanks a lot!

Dridi

[Sérgio Basto]

On Fri, 2019-03-08 at 12:28 +0100, Miro Hrončok wrote:
>  There is a FedoraReview port to Python 3 that needs real word
> testing
>  by packagers.
>  
>  When you use FedoraReview, please use the Python 3 port instead to
>  help us find 
>  bugs.
>  
>  Instructions are at https://pagure.io/FedoraReview/pull-request/312
>  -> the first 
>  comment of my Pull Request is updated with up to date instructions. 
Is not official but Robert-André Mauchin shared his copr repo which
might help to install and test it [1]. 

I'm not sure if it's the most accurate information, but I think having
a copr repository with the latest commits could help us all.

Thanks.

[1]
Yes, you can beta test the Py 3 version here:
https://copr.fedorainfracloud.org/coprs/eclipseo/fedora-review/

And report issues over there:
https://pagure.io/FedoraReview/pull-request/312


>  Thanks,
>  -- 
>  Miro Hrončok
>  --
>  Phone: [phone]
>  IRC: mhroncok
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: 
>  https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives: 
>  https://lists.fedoraproject.org/archives/list/[e-mail] 
-- 
Sérgio M. B.

[Fedora-packaging] Re: Help us test FedoraReview on Python 3

[Miro Hrončok]

On 14. 03. 19 3:56, Sérgio Basto wrote:
>  On Fri, 2019-03-08 at 12:28 +0100, Miro Hrončok wrote:
> > There is a FedoraReview port to Python 3 that needs real word testing
> > by packagers.
> >
> > When you use FedoraReview, please use the Python 3 port instead to
> > help us find
> > bugs.
> >
> > Instructions are at https://pagure.io/FedoraReview/pull-request/312
> > -> the first
> > comment of my Pull Request is updated with up to date instructions.
>  
>  Is not official but Robert-André Mauchin shared his copr repo which
>  might help to install and test it [1].
>  
>  I'm not sure if it's the most accurate information, but I think having
>  a copr repository with the latest commits could help us all. 
The copr repo is now part of instructions in the Pull Request.

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[José Abílio Matos]

On Friday, 8 March 2019 11.28.43 WET Miro Hrončok wrote:
>  There is a FedoraReview port to Python 3 that needs real word testing
> by
>  packagers.
>  
>  When you use FedoraReview, please use the Python 3 port instead to help us
>  find bugs.
>  
>  Instructions are at https://pagure.io/FedoraReview/pull-request/312 -> the
>  first comment of my Pull Request is updated with up to date instructions.
>  
>  Thanks, 
There is a simple bug. When the building phase fails it says something like:
ERROR: 'mock build failed, see /home/jamatos/tmp/1688565-R-ggplot2/results/
build.log'

The results directory should be removed from that error message. It should be:

ERROR: 'mock build failed, see /home/jamatos/tmp/1688565-R-ggplot2/build.log'

Where should I report this so it does not get lost?

Regards,
-- 
José Abílio

[Robert-André Mauchin]

On jeudi 14 mars 2019 16:04:35 CET José Abílio Matos wrote:> 
>  
>  There is a simple bug. When the building phase fails it says something
>  like: 
 ERROR: 'mock build failed, see
>  /home/jamatos/tmp/1688565-R-ggplot2/results/ build.log'
>  
>  The results directory should be removed from that error message. It should
>  be: 
 
>  ERROR: 'mock build failed, see
>  /home/jamatos/tmp/1688565-R-ggplot2/build.log' 
 
>  Where should I report this so it does not get lost?
>  
>  Regards,
>  -- 
>  José Abílio
>   
I don't think that should be the case, the build log at 1688565-R-ggplot2/
build.log is a short non informative one, while the 1688565-R-ggplot2/results/ 
build.log is the actual detailed build output.

[José Abílio Matos]

On Thursday, 14 March 2019 16.26.06 WET Robert-André Mauchin wrote:
>  I don't think that should be the case, the build log at
> 1688565-R-ggplot2/
>  build.log is a short non informative one, while the
>  1688565-R-ggplot2/results/ build.log is the actual detailed build output. 
OK. This is not what I see (two files detailed below), the second is more 
descriptive than the first:

$ cat 1688565-R-ggplot2/results/build.log
Mock Version: 1.4.14
Mock Version: 1.4.14
Mock Version: 1.4.14
ENTER ['do'](['bash', '--login', '-c',
'/usr/bin/rpmbuild -bs --target x86_64 
--nodeps /builddir/build/SPECS/R-ggplot2.spec'], chrootPath='/var/lib/mock/
fedora-rawhide-x86_64/root'env={'TERM': 'vt100', 'SHELL':
'/bin/bash', 'HOME': 
'/builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 
'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"',
'PS1': '<mock-chroot> 
\\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'}
shell=Falselogger=<mockbuild.trace_decorator.getLog object at 
0x7f8731c81eb8>timeout=0uid=1000gid=985user='mockbuild'nspawn_args=['--
capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.h853xstm:/etc/
resolv.conf']unshare_net=TrueprintOutput=False)
Executing command: ['/usr/bin/systemd-nspawn', '-q', '-M', 
'9232f14b446f40bb87001446e1cd8a74', '-D',
'/var/lib/mock/fedora-rawhide-
x86_64/root', '-a', '--capability=cap_ipc_lock',
'--bind=/tmp/mock-
resolv.h853xstm:/etc/resolv.conf', '--setenv=TERM=vt100',
'--setenv=SHELL=/
bin/bash', '--setenv=HOME=/builddir', '--setenv=HOSTNAME=mock',
'--
setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin', '--setenv=PROMPT_COMMAND=printf
"\
\033]0;<mock-chroot>\\007"', '--setenv=PS1=<mock-chroot>
\\s-\\v\\$ ', '--
setenv=LANG=en_US.UTF-8', '-u', 'mockbuild', 'bash',
'--login', '-c', '/usr/
bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/R-
ggplot2.spec'] with env {'TERM': 'vt100', 'SHELL':
'/bin/bash', 'HOME': '/
builddir', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 
'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"',
'PS1': '<mock-chroot> 
\\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'} and shell False
Building target platforms: x86_64
Building for target x86_64
Wrote: /builddir/build/SRPMS/R-ggplot2-3.1.0-1.fc31.src.rpm
Child return code was: 0
Mock Version: 1.4.14


$ cat 1688565-R-ggplot2/build.log
INFO: mock.py version 1.4.14 starting (python version = 3.7.2)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
INFO: Start(/home/jamatos/tmp/1688565-R-ggplot2/srpm/R-
ggplot2-3.1.0-1.fc29.src.rpm)  Config(fedora-rawhide-x86_64)
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.14
INFO: Mock Version: 1.4.14
Finish: chroot init
Start: build phase for R-ggplot2-3.1.0-1.fc29.src.rpm
Start: build setup for R-ggplot2-3.1.0-1.fc29.src.rpm
ERROR: Exception(/home/jamatos/tmp/1688565-R-ggplot2/srpm/R-
ggplot2-3.1.0-1.fc29.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 38 
seconds
INFO: Results and/or logs in: /home/jamatos/tmp/1688565-R-ggplot2/results
ERROR: Command failed: 
 # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/
root/ --releasever 31 --disableplugin=local --setopt=deltarpm=False /var/lib/
mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/R-
ggplot2-3.1.0-1.fc31.src.rpm
fedora                                          1.7 MB/s |  55 MB     00:31    
Last metadata expiration check: 0:00:17 ago on Fri 15 Mar 2019 01:04:17 PM 
WET.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-digest-0.6.15-4.fc30.x86_64 is already installed.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-gtable-0.2.0-3.fc30.noarch is already installed.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-lazyeval-0.2.1-5.fc31.x86_64 is already installed.
No matching package to install: 'R-mapproj'
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-munsell-0.5.0-3.fc30.noarch is already installed.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-plyr-1.8.4-8.fc30.x86_64 is already installed.
Package R-reshape2-1.4.3-6.fc30.x86_64 is already installed.
Package R-rlang-0.3.1-1.fc30.x86_64 is already installed.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-scales-1.0.0-2.fc30.x86_64 is already installed.
Package R-core-3.5.3-1.fc31.x86_64 is already installed.
Package R-tibble-2.0.1-1.fc31.x86_64 is already installed.
Package R-viridisLite-0.3.0-3.fc30.noarch is already installed.
Package R-withr-2.1.2-3.fc30.noarch is already installed.
Package texlive-collection-latexrecommended-8:svn45955-25.fc30.noarch is 
already installed.
Not all dependencies satisfied
Error: Some packages could not be found.


-- 
José Abílio

[Sérgio Basto]

On Fri, 2019-03-15 at 14:21 +0000, José Abílio Matos wrote:
>  No matching package to install: 'R-mapproj' 
-- 
Sérgio M. B.

[José Abílio Matos]

On Monday, 18 March 2019 16.11.20 WET Sérgio Basto wrote:
>  On Fri, 2019-03-15 at 14:21 +0000, José Abílio Matos wrote:
>  
>  > No matching package to install: 'R-mapproj'
>  
>  -- 
>  Sérgio M. B. 
Sure. I know/was aware of what the problem is/was. :-)

My point was that that information was in a different file that fedora-review 
pointed. That was the issue, not that fedora-review failed because not all 
build requires were met.

Regards,
-- 
José Abílio