Is PKG_CONFIG_PATH set on the buildsystem?

[Jonathan Underwood]

Hi,

I was just trying to update  package of mine, and the main change is
adding the following macros to the spec file:

%define emacs_version %(pkg-config emacs --modversion)
%define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
%define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir)

in order to determine those things at package build time (as discussed
previously on fedora-packaging). However, on attempting to check the
changes in, I get this:

cvs diff: [12:11:28] obtained lock in /cvs/extras/rpms/emacs-vm/devel
Package emacs was not found in the pkg-config search path.
Perhaps you should add the directory containing `emacs.pc'
to the PKG_CONFIG_PATH environment variable
No package 'emacs' found
error: line 31: Version required: Requires: emacs >=
error: query of specfile emacs-vm.spec failed, can't parse
Package emacs was not found in the pkg-config search path.
Perhaps you should add the directory containing `emacs.pc'
to the PKG_CONFIG_PATH environment variable
No package 'emacs' found
error: line 31: Version required: Requires: emacs >=
error: query of specfile emacs-vm.spec failed, can't parse
cvs tag  -c emacs-vm--
? .build-8.0.3.495-1.fc8.log
? .build-8.0.3.495-3.fc8.log
? .emacs.desktop
? clog
? emacs-vm-8.0.3.495-1.fc8.src.rpm
? emacs-vm-8.0.3.495-3.fc8.src.rpm
? vm-8.0.2-devo-482.tgz
? vm-8.0.3-495
? x86_64
ERROR: Tag emacs-vm-- is not in name-version-release format
cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!
make: *** [tag] Error 1


Is it therefore not possible to call pkg-config from within a spec
file? Could this be fixed?

Cheers,
Jonathan

[Christopher Brown]

On 08/09/07, Jonathan Underwood <jonathan.underwood(a)gmail.com&gt; wrote:
>  Hi,
>
>  I was just trying to update  package of mine, and the main change is
>  adding the following macros to the spec file:
>
>  %define emacs_version %(pkg-config emacs --modversion)
>  %define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
>  %define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir)
>
>  in order to determine those things at package build time (as discussed
>  previously on fedora-packaging). However, on attempting to check the
>  changes in, I get this:
>
>  cvs diff: [12:11:28] obtained lock in /cvs/extras/rpms/emacs-vm/devel
>  Package emacs was not found in the pkg-config search path.
>  Perhaps you should add the directory containing `emacs.pc'
>  to the PKG_CONFIG_PATH environment variable
>  No package 'emacs' found
>  error: line 31: Version required: Requires: emacs >=
>  error: query of specfile emacs-vm.spec failed, can't parse
>  Package emacs was not found in the pkg-config search path.
>  Perhaps you should add the directory containing `emacs.pc'
>  to the PKG_CONFIG_PATH environment variable
>  No package 'emacs' found
>  error: line 31: Version required: Requires: emacs >=
>  error: query of specfile emacs-vm.spec failed, can't parse
>  cvs tag  -c emacs-vm--
>  ? .build-8.0.3.495-1.fc8.log
>  ? .build-8.0.3.495-3.fc8.log
>  ? .emacs.desktop
>  ? clog
>  ? emacs-vm-8.0.3.495-1.fc8.src.rpm
>  ? emacs-vm-8.0.3.495-3.fc8.src.rpm
>  ? vm-8.0.2-devo-482.tgz
>  ? vm-8.0.3-495
>  ? x86_64
>  ERROR: Tag emacs-vm-- is not in name-version-release format
>  cvs tag: Pre-tag check failed
>  cvs [tag aborted]: correct the above errors first!
>  make: *** [tag] Error 1
>
>
>  Is it therefore not possible to call pkg-config from within a spec
>  file? Could this be fixed?
>  
I think buildsys is having a bad hair day. My builds are failing because
util-linux-ng is missing as a dependency.

http://koji.fedoraproject.org/koji/getfile?taskID=152224&name=srpm.log
http://koji.fedoraproject.org/koji/getfile?taskID=152224&name=root.log

Cheers
Chris

-- 
http://www.chruz.com

[Jesse Keating]

On Sat, 8 Sep 2007 13:21:25 +0100
"Christopher Brown" <snecklifter(a)gmail.com&gt; wrote:

>  I think buildsys is having a bad hair day. My builds are failing
>  because util-linux-ng is missing as a dependency.
>  
>  http://koji.fedoraproject.org/koji/getfile?taskID=152224&name=srpm.log
>  http://koji.fedoraproject.org/koji/getfile?taskID=152224&name=root.log 
This was my fault.  I've fixed it and the buildsystem shouldn't fail on
this in roughly 20 minutes.  (or once
http://koji.fedoraproject.org/koji/taskinfo?taskID=152254 completes.)

-- 
Jesse Keating
Fedora -- All my bits are free, are yours?

[Michael Schwendt]

On Sat, 8 Sep 2007 13:17:29 +0100, Jonathan Underwood wrote:

>  Hi,
>  
>  I was just trying to update  package of mine, and the main change is
>  adding the following macros to the spec file:
>  
>  %define emacs_version %(pkg-config emacs --modversion)
>  %define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
>  %define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir)
>  
>  in order to determine those things at package build time (as discussed
>  previously on fedora-packaging). However, on attempting to check the
>  changes in, I get this:
>  
>  cvs diff: [12:11:28] obtained lock in /cvs/extras/rpms/emacs-vm/devel
>  Package emacs was not found in the pkg-config search path.
>  Perhaps you should add the directory containing `emacs.pc'
>  to the PKG_CONFIG_PATH environment variable
>  No package 'emacs' found
>  error: line 31: Version required: Requires: emacs >=
>  error: query of specfile emacs-vm.spec failed, can't parse 
(!)

>  Package emacs was not found in the pkg-config search path.
>  Perhaps you should add the directory containing `emacs.pc'
>  to the PKG_CONFIG_PATH environment variable
>  No package 'emacs' found
>  error: line 31: Version required: Requires: emacs >=
>  error: query of specfile emacs-vm.spec failed, can't parse
>  cvs tag  -c emacs-vm--
>  ? .build-8.0.3.495-1.fc8.log
>  ? .build-8.0.3.495-3.fc8.log
>  ? .emacs.desktop
>  ? clog
>  ? emacs-vm-8.0.3.495-1.fc8.src.rpm
>  ? emacs-vm-8.0.3.495-3.fc8.src.rpm
>  ? vm-8.0.2-devo-482.tgz
>  ? vm-8.0.3-495
>  ? x86_64
>  ERROR: Tag emacs-vm-- is not in name-version-release format
>  cvs tag: Pre-tag check failed
>  cvs [tag aborted]: correct the above errors first!
>  make: *** [tag] Error 1
>  
>  
>  Is it therefore not possible to call pkg-config from within a spec
>  file? Could this be fixed? 
You can fix it by not creating invalid tags in your spec file.
See (!) above. Just make sure that when pkg-config returns false
and your macros are empty, you either override the macros with
defaults or you create valid "Requires" tags via %if/%else/...

[Jonathan Underwood]

On 08/09/2007, Michael Schwendt <mschwendt.tmp0701.nospam(a)arcor.de&gt; wrote:
>  On Sat, 8 Sep 2007 13:17:29 +0100, Jonathan Underwood wrote:
>
>  > Hi,
>  >
>  > I was just trying to update  package of mine, and the main change is
>  > adding the following macros to the spec file:
>  >
>  > %define emacs_version %(pkg-config emacs --modversion)
>  > %define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
>  > %define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir)
>  >
>  > in order to determine those things at package build time (as discussed
>  > previously on fedora-packaging). However, on attempting to check the
>  > changes in, I get this:
>  >
>  > cvs diff: [12:11:28] obtained lock in /cvs/extras/rpms/emacs-vm/devel
>  > Package emacs was not found in the pkg-config search path.
>  > Perhaps you should add the directory containing `emacs.pc'
>  > to the PKG_CONFIG_PATH environment variable
>  > No package 'emacs' found
>  > error: line 31: Version required: Requires: emacs >=
>  > error: query of specfile emacs-vm.spec failed, can't parse
>
>  (!)
>
>  > Package emacs was not found in the pkg-config search path.
>  > Perhaps you should add the directory containing `emacs.pc'
>  > to the PKG_CONFIG_PATH environment variable
>  > No package 'emacs' found
>  > error: line 31: Version required: Requires: emacs >=
>  > error: query of specfile emacs-vm.spec failed, can't parse
>  > cvs tag  -c emacs-vm--
>  > ? .build-8.0.3.495-1.fc8.log
>  > ? .build-8.0.3.495-3.fc8.log
>  > ? .emacs.desktop
>  > ? clog
>  > ? emacs-vm-8.0.3.495-1.fc8.src.rpm
>  > ? emacs-vm-8.0.3.495-3.fc8.src.rpm
>  > ? vm-8.0.2-devo-482.tgz
>  > ? vm-8.0.3-495
>  > ? x86_64
>  > ERROR: Tag emacs-vm-- is not in name-version-release format
>  > cvs tag: Pre-tag check failed
>  > cvs [tag aborted]: correct the above errors first!
>  > make: *** [tag] Error 1
>  >
>  >
>  > Is it therefore not possible to call pkg-config from within a spec
>  > file? Could this be fixed?
>
>  You can fix it by not creating invalid tags in your spec file.
>  See (!) above. Just make sure that when pkg-config returns false
>  and your macros are empty, you either override the macros with
>  defaults or you create valid "Requires" tags via %if/%else/... 
Yes - I realize - but I think the issue is the tag is invalid because
pkg-config isn't seeing the .pc file for emacs on the build system,
which is what I would like to fix.. Or am I missing something?
[haven't had any coffee yet today].

J.

[Michael Schwendt]

On Sat, 8 Sep 2007 14:46:31 +0100, Jonathan Underwood wrote:

>  > > cvs diff: [12:11:28] obtained lock in
> /cvs/extras/rpms/emacs-vm/devel 
>  > You can fix it by not creating invalid tags in your spec file.
>  Yes - I realize - but I think the issue is the tag is invalid
> because
>  pkg-config isn't seeing the .pc file for emacs on the build system,
>  which is what I would like to fix.. Or am I missing something?
>  [haven't had any coffee yet today]. 
Well, then you need to 

  1) replace your "BuildRequires: emacs" with "BuildRequires:
  emacs-el", since the main package does not contain a pkg-config
  file anymore

and

  2) open a ticket against "emacs" to report that
   /usr/share/pkg-config/emacs.pc
   is a wrong location, which ought to be
   /usr/share/pkgconfig/emacs.pc

The tool is called pkg-config, the directories pkgconfig

[Jonathan Underwood]

On 08/09/2007, Michael Schwendt <mschwendt.tmp0701.nospam(a)arcor.de&gt; wrote:
>  On Sat, 8 Sep 2007 14:46:31 +0100, Jonathan Underwood wrote:
>
>  > > > cvs diff: [12:11:28] obtained lock in /cvs/extras/rpms/emacs-vm/devel
>
>  > > You can fix it by not creating invalid tags in your spec file.
>
>  > Yes - I realize - but I think the issue is the tag is invalid because
>  > pkg-config isn't seeing the .pc file for emacs on the build system,
>  > which is what I would like to fix.. Or am I missing something?
>  > [haven't had any coffee yet today].
>
>  Well, then you need to
>
>    1) replace your "BuildRequires: emacs" with "BuildRequires:
>    emacs-el", since the main package does not contain a pkg-config
>    file anymore
>
>  and
>
>    2) open a ticket against "emacs" to report that
>     /usr/share/pkg-config/emacs.pc
>     is a wrong location, which ought to be
>     /usr/share/pkgconfig/emacs.pc
>
>  The tool is called pkg-config, the directories pkgconfig 
Aha. Yes - that's my fault too, as I provided Chip with the patch to
build the pkg-config file. I suck. Will get it fixed. Thanks for
noticing that Michael.

J.

[Jonathan Underwood]

On 08/09/2007, Michael Schwendt <mschwendt.tmp0701.nospam(a)arcor.de&gt; wrote:
>  You can fix it by not creating invalid tags in your spec file.
>  See (!) above. Just make sure that when pkg-config returns false
>  and your macros are empty, you either override the macros with
>  defaults or you create valid "Requires" tags via %if/%else/... 
OK, had a coffeee, and now I understand what you're saying. Thanks.

[Laurent Rineau]

On Saturday 08 September 2007 16:25:13 Jonathan Underwood wrote:
>  On 08/09/2007, Michael Schwendt
> <mschwendt.tmp0701.nospam(a)arcor.de&gt; wrote:
>  > You can fix it by not creating invalid tags in your spec file.
>  > See (!) above. Just make sure that when pkg-config returns false
>  > and your macros are empty, you either override the macros with
>  > defaults or you create valid "Requires" tags via %if/%else/...
>
>  OK, had a coffeee, and now I understand what you're saying. Thanks. 
Maybe a failed build task is better than a successfull build task that 
produces packages with wrong requirements. If something goes wrong, IMO the 
better is to let the build task fail.

-- 
Laurent Rineau
http://fedoraproject.org/wiki/LaurentRineau

[Christopher Aillon]

Jonathan Underwood wrote:
>  Hi,
>  
>  I was just trying to update  package of mine, and the main change is
>  adding the following macros to the spec file:
>  
>  %define emacs_version %(pkg-config emacs --modversion)
>  %define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
>  %define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir) 
Trick question: how many letter 'o's does pkg-config have?