Updated review trackers pages

[Mattia Verga]

Hi all,

we have updated the script which provides the cached review trackers 
pages at https://fedoraproject.org/PackageReviewStatus/ (thanks to 
cverna for the assistance).

Nothing too impressive, the main changes in frontend are:

- A search field in list pages to filter tickets. Since these pages are 
static HTML, the search is performed client side, so you will need to 
have javascript enabled on your browser.
- Some new colors highlighting to strike problematic tickets (for 
example, if a new package review ticket depends on some other ticket 
that was rejected)
- A list of "top blockers" tickets
- A more permissive hideout filter.

Let us know if you have any more improvement request.

BTW, since we have a 'trivial' ticket list for new reviewers, it would 
be nice to have this populated: just add the 'trivial' tag in the ticket 
whiteboard field on bugzilla.
Other useful whiteboard tags recognized by the script are (already used 
by the old script):
- 'buildfails': A flag for tickets which fail build.
- 'notready': A flag for tickets not yet ready for being reviewed.
- 'stalledsubmitter' and 'awaitingsubmitter': A flag for tickets which 
are stalled.

Cheers,
Mattia

[Richard Shaw]

On Tue, Apr 7, 2020 at 2:22 AM Mattia Verga via devel <
devel(a)lists.fedoraproject.org&gt; wrote:

>  Hi all,
>
>  we have updated the script which provides the cached review trackers
>  pages at https://fedoraproject.org/PackageReviewStatus/ (thanks to
>  cverna for the assistance).
>  
Can we assume the one from 2006 is stale? :)

Thanks,
Richard

[Ankur Sinha]

On Tue, Apr 07, 2020 07:21:14 +0000, Mattia Verga via devel wrote:
>  Hi all, 
Hi Mattia,

Thanks very much for this!

> <snip>
>  
>  BTW, since we have a 'trivial' ticket list for new reviewers, it would 
>  be nice to have this populated: just add the 'trivial' tag in the ticket 
>  whiteboard field on bugzilla. 
The list says that there aren't any trivial tickets, but easyfix does
show one (only one):
https://fedoraproject.org/PackageReviewStatus/trivial.html
vs
https://fedoraproject.org/easyfix/

Could you check this please?

+1 to marking more package reviews as trivial. It'll really help the
newcomers coming to us in the Join SIG to get started with packaging :)

-- 
Thanks,
Regards,
Ankur Sinha "FranciscoD" (He / Him / His) |
https://fedoraproject.org/wiki/User:Ankursinha
Time zone: Europe/London

[Mattia Verga]

Il 07/04/20 16:01, Ankur Sinha ha scritto:
>  The list says that there aren't any trivial tickets, but easyfix does
>  show one (only one):
>  https://fedoraproject.org/PackageReviewStatus/trivial.html
>  vs
>  https://fedoraproject.org/easyfix/
>
>  Could you check this please?
>  
Yeah, that's because it's listed in the "in progress" page...
that 
ticket has the review flag set and the assignee field is populated, but 
it's state is NEW.

I will add a page to list all tickets in inconsistent state like that one.

Thanks

[Mattia Verga]

Il 07/04/20 16:52, Mattia Verga ha scritto:
>  Il 07/04/20 16:01, Ankur Sinha ha scritto:
> > The list says that there aren't any trivial tickets, but easyfix does
> > show one (only one):
> > https://fedoraproject.org/PackageReviewStatus/trivial.html
> > vs
> > https://fedoraproject.org/easyfix/
> >
> > Could you check this please?
> >
>  Yeah, that's because it's listed in the "in progress" page... that
>  ticket has the review flag set and the assignee field is populated, but
>  it's state is NEW.
>
>  I will add a page to list all tickets in inconsistent state like that one.
>
>  Thanks
>  
Ok, I've just pushed an "update" which moves all tickets with 
inconsistent state in a separate page.
For "consistent" state I mean two cases:
- state "NEW" + assignee not set (nobody(a)fedoraproject.org) + 
review-flag not set
- state != "NEW" + assignee set + review flag set (either ? | - | +)

If you are a reviewer, please check if you have any ticket assigned. 
I've also added a "reviewers.html" page where you can easily find what 
tickets are "assigned" to you (I use double quote here because this only 
checks if your email is set in the "assigned_to" field - there are many 
tickets in inconsistent state because their state is new but have an 
assignee set).

Mattia

[Till Hofmann]

On 4/7/20 9:21 AM, Mattia Verga via devel wrote:
>  we have updated the script which provides the cached review trackers
>
>  pages at https://fedoraproject.org/PackageReviewStatus/ (thanks to 
>  cverna for the assistance). 
It looks like 1821497 [1] is displayed incorrectly (currently at the
bottom of the page), maybe bccause of the unusual title ("Review
Request: <vazir> - <A Persian (Farsi) Font>")?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1821497

[Mattia Verga]

Il 07/04/20 17:31, Till Hofmann ha scritto:
>  It looks like 1821497 [1] is displayed incorrectly (currently at the
>  bottom of the page), maybe bccause of the unusual title ("Review
>  Request: <vazir> - <A Persian (Farsi) Font>")?
>
>  [1] https://bugzilla.redhat.com/show_bug.cgi?id=1821497 
Thanks, I've just pushed the fix for that.

Mattia