Disabling build options for SSE on non-capable arches ?

[David Timms]

Hi, (this is a 4th retry, now trying devel as first try to packaging a
week ago says held by moderator, but doesn't seem to have been posted to
the list, and I don't know why...)

Audacity has had the following as part of rpm spec in the %configure
section:

%configure \
    --disable-dynamic-loading \
...
%ifnarch %{ix86} x86_64
    --disable-sse \
%else
    %{nil}
%endif

Which fails on: non x86 arches:
https://koji.fedoraproject.org/koji/taskinfo?taskID=29513664

If I remove the conditional, I get successful build, but not optimized
on x86 with SSE.

What's wrong with this conditional ?

Cheers, David

[Adam Williamson]

On Thu, 2018-09-20 at 07:58 +1000, David Timms wrote:
>  Hi, (this is a 4th retry, now trying devel as first try to packaging
> a
>  week ago says held by moderator, but doesn't seem to have been posted to
>  the list, and I don't know why...)
>  
>  Audacity has had the following as part of rpm spec in the %configure
>  section:
>  
>  %configure \
>      --disable-dynamic-loading \
>  ...
>  %ifnarch %{ix86} x86_64
>      --disable-sse \
>  %else
>      %{nil}
>  %endif
>  
>  Which fails on: non x86 arches:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=29513664
>  
>  If I remove the conditional, I get successful build, but not optimized
>  on x86 with SSE.
>  
>  What's wrong with this conditional ? 
I think sticking a conditional in the middle of a line-wrapped command
like that may not work.

I'd try instead creating a variable for the args first, something like
this:

%ifnarch %{ix86} x86_64
    %global sseargs --disable-sse
%else
    %global sseargs

...

%configure %{sseargs} \
...
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net

[Sérgio Basto]

On Thu, 2018-09-20 at 07:58 +1000, David Timms wrote:
>  Hi, (this is a 4th retry, now trying devel as first try to packaging
>  a
>  week ago says held by moderator, but doesn't seem to have been posted
>  to
>  the list, and I don't know why...)
>  
>  Audacity has had the following as part of rpm spec in the %configure
>  section:
>  
>  %configure \
>      --disable-dynamic-loading \
>  ...
>  %ifnarch %{ix86} x86_64
>      --disable-sse \
>  %else
>      %{nil}
>  %endif
>  
>  Which fails on: non x86 arches:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=29513664
>  
>  If I remove the conditional, I get successful build, but not
>  optimized
>  on x86 with SSE.
>  
>  What's wrong with this conditional ? 
The conditional is correct but [1] from the previous %endif you leave
two blanks lines which you can't, one blank line makes terminate the
./configure command and so last option "--disable-sse" is not included
in build, you may check build.log [2] and you don't find any "
--disable-sse" 

[1]
%endif
(blank line)
(blank line)
%ifnarch %{ix86} x86_64
    --disable-sse \
%else
    %{nil}
%endif

[2]
https://koji.fedoraproject.org/koji/taskinfo?taskID=29513670
https://kojipkgs.fedoraproject.org//work/tasks/3670/29513670/build.log

Thanks and Best regards, 

>  Cheers, David
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelin
>  es
>  List Archives: https://lists.fedoraproject.org/archives/list/devel@li
>  sts.fedoraproject.org 
-- 
Sérgio M. B.

[David Timms]

On 20/09/18 09:38, Sérgio Basto wrote:
>  On Thu, 2018-09-20 at 07:58 +1000, David Timms wrote:
>  The conditional is correct but [1] from the previous %endif you leave
>  two blanks lines which you can't, one blank line makes terminate the
>  ./configure command and so last option "--disable-sse" is not included
>  in build, you may check build.log [2] and you don't find any "
>  --disable-sse"  
OK, thanks, guys. I had already noticed the blank lines removed and
commited, but my git foo can't have been on the ball. I was also getting
a clog generated which had the comment from an earlier commit - another
thing I don't understand.

Once properly committed, build succeeded on f27 on copr, so commited to
Fedora, and awaiting success!