libsmbclient.h in FC7

[Marcin Zajączkowski]

Hi,


I was surprised when my package (fuse-smb) failed during last rawhide
rebuild in mock.

In log there is:
checking libsmbclient.h usability... no
checking libsmbclient.h presence... no
checking for libsmbclient.h... no
configure: error: Please install libsmbclient header files.

Up to FC6 libsmbclient.h is in samba-common (which is in BuildRequires),
but after small investigation I noticed that in FC7 this file is in
separate package libsmbclient-devel and dependency should be added.

I would like to ask should I do something like:
if "%fedora" > "6"
    BuildRequires: libsmbclient-devel
%endif

or it's better to make a branch for a rawhide and higher?


Regards
Marcin

[Rex Dieter]

Marcin Zajączkowski wrote:

>  Up to FC6 libsmbclient.h is in samba-common (which is in
> BuildRequires),
>  but after small investigation I noticed that in FC7 this file is in
>  separate package libsmbclient-devel and dependency should be added.
>  
>  I would like to ask should I do something like:
>  if "%fedora" > "6"
>      BuildRequires: libsmbclient-devel
>  %endif
>  
>  or it's better to make a branch for a rawhide and higher? 
either way works, it's up to you.

-- Rex

[Simo Sorce]

On Wed, 2007-04-18 at 20:52 +0200, Marcin Zajączkowski wrote:
>  Hi,
>  
>  
>  I was surprised when my package (fuse-smb) failed during last rawhide
>  rebuild in mock.
>  
>  In log there is:
>  checking libsmbclient.h usability... no
>  checking libsmbclient.h presence... no
>  checking for libsmbclient.h... no
>  configure: error: Please install libsmbclient header files.
>  
>  Up to FC6 libsmbclient.h is in samba-common (which is in BuildRequires),
>  but after small investigation I noticed that in FC7 this file is in
>  separate package libsmbclient-devel and dependency should be added.
>  
>  I would like to ask should I do something like:
>  if "%fedora" > "6"
>      BuildRequires: libsmbclient-devel
>  %endif
>   
Can't you just specify a dependency on the header file and let rpm
figure out which is the right package?
Or is this not allowed for BuildRequires ?

Simo.

[Patrice Dumas]

On Wed, Apr 18, 2007 at 04:15:18PM -0400, Simo Sorce wrote:
>  
>  Can't you just specify a dependency on the header file and let rpm
>  figure out which is the right package?
>  Or is this not allowed for BuildRequires ? 
It is allowed, but having dependencies on files outside of bin
directories causes yum to download the filelists. However it is likely
that the package name won't change anymore, and if it changes an
obsoletes will be added, so think that using a file as a
dependency is not right in that case.

--
Pat

[Nicolas Mailhot]

Le mercredi 18 avril 2007 à 22:24 +0200, Patrice Dumas a écrit :
>  On Wed, Apr 18, 2007 at 04:15:18PM -0400, Simo Sorce wrote:
>  > 
>  > Can't you just specify a dependency on the header file and let rpm
>  > figure out which is the right package?
>  > Or is this not allowed for BuildRequires ?
>  
>  It is allowed, but having dependencies on files outside of bin
>  directories causes yum to download the filelists. 
How come "obviously correct but slow" is worse than "fast and
fragile" (esp. for stuff that is only used at build time?)

-- 
Nicolas Mailhot

[Patrice Dumas]

On Thu, Apr 19, 2007 at 07:28:20PM +0200, Nicolas Mailhot wrote:
>  
>  How come "obviously correct but slow" is worse than "fast and
>  fragile" (esp. for stuff that is only used at build time?) 
Using a dependency on a header file is not very correct. Anyway
both solutions are acceptable in my opinion.

--
Pat

[Marcin Zajączkowski]

Patrice Dumas wrote:
(...)
>  Anyway both solutions are acceptable in my opinion. 
Thanks for all your opinions.
I've chosen version with "if" macro to allow keep me one file for a few
releases.

Whould you tell me, is there a better way to determine Fedora version than:
%if "fedora-release" > "6"
BuildRequires: libsmbclient-devel >= 3.0
%endif

?


Regards
Marcin

[Marcin Zajączkowski]

Marcin Zajączkowski wrote:
>  Patrice Dumas wrote:
>  (...)
> > Anyway both solutions are acceptable in my opinion.
>  
>  Thanks for all your opinions.
>  I've chosen version with "if" macro to allow keep me one file for a few
>  releases.
>  
>  Whould you tell me, is there a better way to determine Fedora version than: 
Last construction was always true despite the version given as an
argument...

This should be better:
%if %(rpmquery --qf '%{VERSION}' fedora-release) > 5
BuildRequires: libsmbclient-devel >= 3.0
%endif

>  
>  ?
>  
>  
>  Regards
>  Marcin
>

[Patrice Dumas]

On Thu, Apr 19, 2007 at 10:26:06PM +0200, Marcin Zajączkowski wrote:
>  Patrice Dumas wrote:
>  (...)
>  > Anyway both solutions are acceptable in my opinion.
>  
>  Thanks for all your opinions.
>  I've chosen version with "if" macro to allow keep me one file for a few
>  releases.
>  
>  Whould you tell me, is there a better way to determine Fedora version than:
>  %if "fedora-release" > "6"
>  BuildRequires: libsmbclient-devel >= 3.0
>  %endif 
Normaly it is:
%if "%fedora" > "6"
BuildRequires: libsmbclient-devel >= 3.0
%endif

--
Pat

[Marcin Zajączkowski]

Patrice Dumas wrote:
>  On Thu, Apr 19, 2007 at 10:26:06PM +0200, Marcin Zajączkowski wrote:
(...)
> > Whould you tell me, is there a better way to determine Fedora
> version than:
> > %if "fedora-release" > "6"
> > BuildRequires: libsmbclient-devel >= 3.0
> > %endif
>  
>  Normaly it is:
>  %if "%fedora" > "6"
>  BuildRequires: libsmbclient-devel >= 3.0
>  %endif 
I thought that too, but it's always false on my machine with FC5 (I
don't use mock), even if I write '%if "%fedora" >
"3"'.


Marcin

[Patrice Dumas]

On Thu, Apr 19, 2007 at 11:14:42PM +0200, Marcin Zajączkowski wrote:
>  
>  I thought that too, but it's always false on my machine with FC5 (I
>  don't use mock), even if I write '%if "%fedora" >
> "3"'. 
That's because %fedora is not defined everywhere. It is defined in the
buildsystem, in mock (although I don't know exactly how) and according
to a thread in -devel will certainly be in next releases
http://www.redhat.com/archives/fedora-devel-list/2007-March/msg01759.html

You can use 
rpmbuild --define 'fedora 6' 
to define the macros in the mean time.

--
Pat

[Marcin Zajączkowski]

Marcin Zajączkowski wrote:
>  Patrice Dumas wrote:
> > On Thu, Apr 19, 2007 at 10:26:06PM +0200, Marcin Zajączkowski wrote:
>  (...)
> >> Whould you tell me, is there a better way to determine Fedora version than:
> >> %if "fedora-release" > "6"
> >> BuildRequires: libsmbclient-devel >= 3.0
> >> %endif
> > Normaly it is:
> > %if "%fedora" > "6"
> > BuildRequires: libsmbclient-devel >= 3.0
> > %endif
>  
>  I thought that too, but it's always false on my machine with FC5 (I
>  don't use mock), even if I write '%if "%fedora" >
> "3"'. 
In mock build there is '--define "fedora 7"'. I added similar macro to
my .rpmmacros (maybe it should defined out-of-box globally in Fedora?)

But I'm not sure why my version failed in mock (23 is a line with my "if"):
error: syntax error in expression
error: fuse-smb.spec:23: parseExpressionBoolean returns -1
error: Package has no %description: fuse-smb
error: query of specfile fuse-smb.spec failed, can't parse
error: syntax error in expression
error: fuse-smb.spec:23: parseExpressionBoolean returns -1
error: Package has no %description: fuse-smb
error: query of specfile fuse-smb.spec failed, can't parse

Any ideas?

Marcin

[Andy Shevchenko]

Hi Marcin Zaj??czkowski!

 On Thu, Apr 19, 2007 at 11:46:28PM +0200, Marcin Zaj??czkowski wrote next:

>  In mock build there is '--define "fedora 7"'. I
> added similar macro to
>  my .rpmmacros (maybe it should defined out-of-box globally in Fedora?)
>  
>  But I'm not sure why my version failed in mock (23 is a line with my
> "if"):
>  error: syntax error in expression
>  error: fuse-smb.spec:23: parseExpressionBoolean returns -1
>  Any ideas? 
Look to line 23 +- 2. 
Could you post these lines here?

-- 
With best regards,
Andy Shevchenko.      mailto: andy(a)smile.org.ua

[Andy Shevchenko]

Hi Andy Shevchenko!

 On Fri, Apr 20, 2007 at 08:42:58AM +0300, Andy Shevchenko wrote next:

>  > In mock build there is '--define "fedora 7"'.
> I added similar macro to
>  > my .rpmmacros (maybe it should defined out-of-box globally in Fedora?)
>  > 
>  > But I'm not sure why my version failed in mock (23 is a line with my
> "if"):
>  > error: syntax error in expression
>  > error: fuse-smb.spec:23: parseExpressionBoolean returns -1
>  > Any ideas?
>  Look to line 23 +- 2. 
>  Could you post these lines here? 
Sorry, I don't attent to the your note.

Could you post the rpmmacros which used for?

-- 
With best regards,
Andy Shevchenko.      mailto: andy(a)smile.org.ua

[Marcin Zajączkowski]

Andy Shevchenko wrote:
>  Hi Andy Shevchenko! 
(...)
> >> But I'm not sure why my version failed in mock (23 is a
> line with my "if"):
> >> error: syntax error in expression
> >> error: fuse-smb.spec:23: parseExpressionBoolean returns -1
> >> Any ideas?
> > Look to line 23 +- 2. 
> > Could you post these lines here?
>  Sorry, I don't attent to the your note.
>  
>  Could you post the rpmmacros which used for? 
Hmm, I'm not sure. It was a build requested by "make tag build" on the 
Fedora server(s). Locally I don't use mock.


Marcin