packaging files via symlinks

[Florian La Roche]

Hello all,

I've added a check to pyrpm to detect the cases where
a symlink to a directory is used within a directory name
to package files into a rpm. The patch for this is at:
http://www.jur-linux.org/git/?p=cvs-pyrpm.git;a=commitdiff;h=3cfefdc1496c...
Let me know if you can speed this test further up and know
further python or algorithm improvements.

We knew such a symlink was often used to package e.g. /etc/init.d/<service>,
but running this on Fedora-devel shows that also other
packages are affected:

symlink /etc/init.d from chkconfig-1.3.37-1.i386.rpm is used as directory name in
conmux-0.0-6.493svn.fc7.noarch.rpm aiccu-2007.01.15-3.fc8.i386.rpm
tomcat5-5.5.23-9jpp.4.fc8.i386.rpm cobbler-0.6.3-2.fc9.noarch.rpm
func-0.13-3.fc9.noarch.rpm zabbix-agent-1.4.2-3.fc8.i386.rpm varnish-1.1.1-3.fc8.i386.rpm
jetty-5.1.12-1jpp.7.fc8.i386.rpm dkms-2.0.17.5-1.fc8.noarch.rpm
ldirectord-2.1.2-2.fc8.i386.rpm monotone-server-0.37-3.fc9.i386.rpm
dircproxy-1.2.0-0.6beta2.fc8.i386.rpm fuse-2.7.0-8.fc8.i386.rpm
wifiroamd-1.12-1.fc8.noarch.rpm conman-0.1.9.2-7.fc7.i386.rpm
sqlgrey-1.7.5-1.fc7.noarch.rpm edac-utils-0.9-7.fc8.i386.rpm zabbix-1.4.2-3.fc8.i386.rpm
cyphesis-0.5.13-2.fc8.i386.rpm heartbeat-2.1.2-2.fc8.i386.rpm
symlink /usr/lib/tcl8.4 from tcl-8.4.15-5.fc8.i386.rpm is used as directory name in
tkdnd-1.0a2-9.fc8.i386.rpm amsn-0.96-7.fc7.i386.rpm
tbcload-1.4-5.20061030cvs.fc8.i386.rpm
symlink /usr/share/pharosc/alliance/makevbe/ssxlib013 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/rgalib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/ssxlib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/sxlib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/vgalib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/vsclib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/vxlib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/pharosc/alliance/vbe/wsclib013_0 from
pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
symlink /usr/share/sgml/docbook/xsl-stylesheets from
docbook-style-xsl-1.73.2-4.fc9.noarch.rpm is used as directory name in
docbook-style-xsl-1.73.2-4.fc9.noarch.rpm dblatex-0.2.7-16.fc9.noarch.rpm

I'll add a bugzilla report for tkdnd, amsn, tbcload,
pharosc, docbook-style-xsl, dblatex if noone are already filed.

regards,

Florian La Roche

[Patrice Dumas]

On Sat, Nov 17, 2007 at 04:37:26PM +0100, Florian La Roche wrote:
>  Hello all,
>  
>  but running this on Fedora-devel shows that also other
>  packages are affected:
>  
>  symlink /usr/share/sgml/docbook/xsl-stylesheets from
> docbook-style-xsl-1.73.2-4.fc9.noarch.rpm is used as directory name in
> docbook-style-xsl-1.73.2-4.fc9.noarch.rpm dblatex-0.2.7-16.fc9.noarch.rpm
>  
>  I'll add a bugzilla report for tkdnd, amsn, tbcload,
>  pharosc, docbook-style-xsl, dblatex if noone are already filed. 
I am interested in dblatex, and I don't see what is wrong with using the
symlink as a directory. Indeed, 
/usr/share/sgml/docbook/xsl-stylesheets-1.73.2-4.fc9
may be the right directory to use, but it xsl-stylesheets version
dependent. Does it mean that the version dependency is hidden by using
the symlink, but that it will break upon docbook-style-xsl update?

In that case I guess that the right thing to do is to have
/usr/share/sgml/docbook/xsl-stylesheets be a directory.

--
Pat

[Florian La Roche]

Hello all,

Update on the results:

On Sat, Nov 17, 2007 at 04:37:26PM +0100, Florian La Roche wrote:
>  Hello all,
>  
>  I've added a check to pyrpm to detect the cases where
>  a symlink to a directory is used within a directory name
>  to package files into a rpm. The patch for this is at:
>
> http://www.jur-linux.org/git/?p=cvs-pyrpm.git;a=commitdiff;h=3cfefdc1496c...
>  Let me know if you can speed this test further up and know
>  further python or algorithm improvements.
>  
>  We knew such a symlink was often used to package e.g. /etc/init.d/<service>,
>  but running this on Fedora-devel shows that also other
>  packages are affected:
>  
>  symlink /etc/init.d from chkconfig-1.3.37-1.i386.rpm is used as directory name in
> conmux-0.0-6.493svn.fc7.noarch.rpm aiccu-2007.01.15-3.fc8.i386.rpm
> tomcat5-5.5.23-9jpp.4.fc8.i386.rpm cobbler-0.6.3-2.fc9.noarch.rpm
> func-0.13-3.fc9.noarch.rpm zabbix-agent-1.4.2-3.fc8.i386.rpm varnish-1.1.1-3.fc8.i386.rpm
> jetty-5.1.12-1jpp.7.fc8.i386.rpm dkms-2.0.17.5-1.fc8.noarch.rpm
> ldirectord-2.1.2-2.fc8.i386.rpm monotone-server-0.37-3.fc9.i386.rpm
> dircproxy-1.2.0-0.6beta2.fc8.i386.rpm fuse-2.7.0-8.fc8.i386.rpm
> wifiroamd-1.12-1.fc8.noarch.rpm conman-0.1.9.2-7.fc7.i386.rpm
> sqlgrey-1.7.5-1.fc7.noarch.rpm edac-utils-0.9-7.fc8.i386.rpm zabbix-1.4.2-3.fc8.i386.rpm
> cyphesis-0.5.13-2.fc8.i386.rpm heartbeat-2.1.2-2.fc8.i386.rpm 
Not sure we want to fix all of these, maybe FESCO wants to decide this first.

>  symlink /usr/lib/tcl8.4 from tcl-8.4.15-5.fc8.i386.rpm is used as
> directory name in tkdnd-1.0a2-9.fc8.i386.rpm amsn-0.96-7.fc7.i386.rpm
> tbcload-1.4-5.20061030cvs.fc8.i386.rpm 
This is going to get fixed with tcl8.5.

>  symlink /usr/share/pharosc/alliance/makevbe/ssxlib013 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/rgalib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/ssxlib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/sxlib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/vgalib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/vsclib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/vxlib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm
>  symlink /usr/share/pharosc/alliance/vbe/wsclib013_0 from
> pharosc-alliance-8.3-1.fc8.noarch.rpm is used as directory name in
> pharosc-alliance-devel-8.3-1.fc8.noarch.rpm 
Only affects one package.

>  symlink /usr/share/sgml/docbook/xsl-stylesheets from
> docbook-style-xsl-1.73.2-4.fc9.noarch.rpm is used as directory name in
> docbook-style-xsl-1.73.2-4.fc9.noarch.rpm dblatex-0.2.7-16.fc9.noarch.rpm 
docbook-style-xsl could drop the versioned directory.


regards,

Florian La Roche


>  
>  I'll add a bugzilla report for tkdnd, amsn, tbcload,
>  pharosc, docbook-style-xsl, dblatex if noone are already filed.
>  
>  regards,
>  
>  Florian La Roche
>