Re: mlichvar pushed to lrzsz (master). "add man page symlinks for sb, sx, rb, rx programs (#1611501)"

[Tomasz Kłoczko]

On Wed, 12 Sep 2018 at 13:06, <notifications(a)fedoraproject.org&gt; wrote:

>  Notification time stamped 2018-09-12 11:01:03 UTC
>
>  From 20e576638ca6bbc6583bb357353a6c66760fe457 Mon Sep 17 00:00:00 2001
>  From: Miroslav Lichvar <mlichvar(a)redhat.com&gt;
>  Date: Sep 12 2018 11:00:41 +0000
>  Subject: add man page symlinks for sb, sx, rb, rx programs (#1611501)
>
>
>  ---
>
>  diff --git a/lrzsz.spec b/lrzsz.spec
>  index a751bba..c47cbb1 100644
>  --- a/lrzsz.spec
>  +++ b/lrzsz.spec
>  @@ -37,6 +37,9 @@ make %{?_smp_mflags}
>
>   %install
>   %makeinstall
>  +for m in rb rx; do ln -s rz.1 %{buildroot}%{_mandir}/man1/$m.1; done
>  +for m in sb sx; do ln -s sz.1 %{buildroot}%{_mandir}/man1/$m.1; done
>  +
>   %find_lang %{name}
>  
Just FTR: This kind of modifications are wrong.
After compressing {rs}z.1 in %post it will be {rs}z.1.gz and created
symlinks will be pointing nowhere.
As well in such situation it should be not used symlinks to *gz files as
when compression of the man pages method may change in such situations
symlinks will be pointing to nowhere.
Only correct method for above is use roff link files like:

+for m in rb rx; do echo ".so man1/rz.1" > %{buildroot}%{_mandir}/man1/$m.1;
done
+for m in sb sx; do echo ".so man1/sz.1" > %{buildroot}%{_mandir}/man1/$m.1;
done

kloczek
-- 
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH

mlichvar pushed to lrzsz (master). "add man page symlinks for sb, sx, rb, rx programs (#1611501)"

[Miroslav Lichvar]

On Wed, Sep 12, 2018 at 01:47:00PM +0200, Tomasz Kłoczko wrote:
>  > From 20e576638ca6bbc6583bb357353a6c66760fe457 Mon Sep 17
> 00:00:00 2001
>  > From: Miroslav Lichvar <mlichvar(a)redhat.com&gt;
>  > Date: Sep 12 2018 11:00:41 +0000
>  > Subject: add man page symlinks for sb, sx, rb, rx programs (#1611501)
>  > +for m in rb rx; do ln -s rz.1 %{buildroot}%{_mandir}/man1/$m.1; done
>  > +for m in sb sx; do ln -s sz.1 %{buildroot}%{_mandir}/man1/$m.1; done
>  > +
>  >  %find_lang %{name}
>  >
>  
>  Just FTR: This kind of modifications are wrong.
>  After compressing {rs}z.1 in %post it will be {rs}z.1.gz and created
>  symlinks will be pointing nowhere. 
That may have been true in the past, but the current compression script seems
to fix the symlinks as expected.

$ rpm -qlvp lrzsz-0.12.20-46.fc30.x86_64.rpm | grep man1
lrwxrwxrwx    1 root    root                        7 Sep 12 13:05
/usr/share/man/man1/rb.1.gz -> rz.1.gz
lrwxrwxrwx    1 root    root                        7 Sep 12 13:05
/usr/share/man/man1/rx.1.gz -> rz.1.gz
-rw-r--r--    1 root    root                     5810 Sep 12 13:05
/usr/share/man/man1/rz.1.gz
lrwxrwxrwx    1 root    root                        7 Sep 12 13:05
/usr/share/man/man1/sb.1.gz -> sz.1.gz
lrwxrwxrwx    1 root    root                        7 Sep 12 13:05
/usr/share/man/man1/sx.1.gz -> sz.1.gz
-rw-r--r--    1 root    root                     7383 Sep 12 13:05
/usr/share/man/man1/sz.1.gz

-- 
Miroslav Lichvar