a look at my spec file for Webmin

[Scott Berry]

Can someone have a look at this spec file and tell me if I have everything
correct?  It looks correct to me pretty much but I think there are just a
couple things missing.  I will attach this as a file.

Scott

[Manuel Aróstegui]

El Jueves, 7 de Junio de 2007 18:12, Scott Berry escribió:
>  Can someone have a look at this spec file and tell me if I have
> everything
>  correct?  It looks correct to me pretty much but I think there are just a
>  couple things missing.  I will attach this as a file.
>
>  Scott 
The thing is...that works for you?
If you're looking for the correct way to write spec files why you don't follow 
guidelines?

-- 
Manuel Arostegui Ramirez.

Electronic Mail is not secure, may not be read every day, and should not
be used for urgent or sensitive issues.

[Scott Berry]

This is from a srpm from www.webmin.com.  Yes it has worked  on Fedora 6.
The reason I don't follow guidelines is there is no
 Examples. I tried understanding them but they are a little too in depth for
beginning users.  The guidelines I do use are found here:
http://docs.fedoraproject.org/drafts/rpm-guide-en/ch11s02.html 
The guidelines need to be geared more towards a beginner if you want more
packagers.
  I understand that not everything can be predicted but a good tutorial
would be in the order for beginners.  I just took the spec file and added
what the document said to add.  The document given as a link  hasn't been
updated in two years.
Scott
-----

Original Message-----
From: fedora-devel-list-bounces(a)redhat.com
[mailto:[e-mail]] On Behalf Of Manuel Arostegui
Ramirez
Sent: Thursday, June 07, 2007 11:16 AM
To: Development discussions related to Fedora Core
Subject: Re: a look at my spec file for Webmin

El Jueves, 7 de Junio de 2007 18:12, Scott Berry escribió:
>  Can someone have a look at this spec file and tell me if I have
> everything
>  correct?  It looks correct to me pretty much but I think there are just a
>  couple things missing.  I will attach this as a file.
>
>  Scott 
The thing is...that works for you?
If you're looking for the correct way to write spec files why you don't
follow 
guidelines?

-- 
Manuel Arostegui Ramirez.

Electronic Mail is not secure, may not be read every day, and should not
be used for urgent or sensitive issues.

-- 
fedora-devel-list mailing list
fedora-devel-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list



-- 
No virus found in this incoming message.
Checked by AVG Free Edition. 
Version: 7.5.472 / Virus Database: 269.8.11/837 - Release Date: 6/6/2007
2:03 PM

[Rahul Sundaram]

Scott Berry wrote:
>  This is from a srpm from www.webmin.com.  Yes it has worked  on
> Fedora 6.
>  The reason I don't follow guidelines is there is no
>   Examples. I tried understanding them but they are a little too in depth for
>  beginning users.  The guidelines I do use are found here:
>  http://docs.fedoraproject.org/drafts/rpm-guide-en/ch11s02.html 
>  The guidelines need to be geared more towards a beginner if you want more
>  packagers. 
A more appropriate guide would be 
http://fedoraproject.org/wiki/Packaging/Guidelines

Rahul

[Scott Berry]

Yep I have that one here also.  This is the one that needs a little work.
The guidelines are okay but for a new user what do you do?

Scott

-----Original Message-----
From: fedora-devel-list-bounces(a)redhat.com
[mailto:[e-mail]] On Behalf Of Rahul Sundaram
Sent: Thursday, June 07, 2007 12:28 PM
To: Development discussions related to Fedora Core
Subject: Re: a look at my spec file for Webmin

Scott Berry wrote:
>  This is from a srpm from www.webmin.com.  Yes it has worked  on
> Fedora 6.
>  The reason I don't follow guidelines is there is no
>   Examples. I tried understanding them but they are a little too in depth 
for
>  beginning users.  The guidelines I do use are found here:
>  http://docs.fedoraproject.org/drafts/rpm-guide-en/ch11s02.html 
>  The guidelines need to be geared more towards a beginner if you want more
>  packagers. 
A more appropriate guide would be 
http://fedoraproject.org/wiki/Packaging/Guidelines

Rahul

-- 
fedora-devel-list mailing list
fedora-devel-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list



-- 
No virus found in this incoming message.
Checked by AVG Free Edition. 
Version: 7.5.472 / Virus Database: 269.8.11/837 - Release Date: 6/6/2007
2:03 PM

[Rahul Sundaram]

Scott Berry wrote:
>  Yep I have that one here also.  This is the one that needs a little
> work.
>  The guidelines are okay but for a new user what do you do?
>  
>  Scott 
Read it. If you have specific questions you can always ask. If you got a 
spec file that follows the guidelines you can submit it for review and 
the reviewer can suggest changes to improve it before it gets imported 
into the repository.

Rahul

[David Smith]

Scott Berry wrote:
>  This is from a srpm from www.webmin.com.  Yes it has worked  on
> Fedora 6.
>  The reason I don't follow guidelines is there is no
>   Examples. I tried understanding them but they are a little too in depth for
>  beginning users.  The guidelines I do use are found here:
>  http://docs.fedoraproject.org/drafts/rpm-guide-en/ch11s02.html 
>  The guidelines need to be geared more towards a beginner if you want more
>  packagers.
>    I understand that not everything can be predicted but a good tutorial
>  would be in the order for beginners.  I just took the spec file and added
>  what the document said to add.  The document given as a link  hasn't been
>  updated in two years.
>  Scott 
Scott,

One of the problems you are having is that you picked a package with 
such a complicated spec file to begin with.  There really aren't too 
many packages that include all the scripts that this one does: %pre, 
%post, %preun, %postun, and %triggerpostun.  From my brief look at the 
spec file it appears to be doing way too much.

You probably need to sit back and think a bit and dramatically simplify 
the spec file.  Contact me off-list if you'd like some help (not that I 
  own any packages but I've hacked on spec files before).

-- 
David Smith
dsmith(a)redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

[Jos Vos]

On Thu, Jun 07, 2007 at 12:10:35PM -0500, Scott Berry wrote:

>  This is from a srpm from www.webmin.com.  Yes it has worked  on
> Fedora 6.
>  The reason I don't follow guidelines is there is no
>   Examples. I tried understanding them but they are a little too in depth for
>  beginning users.  The guidelines I do use are found here:
>  http://docs.fedoraproject.org/drafts/rpm-guide-en/ch11s02.html 
>  The guidelines need to be geared more towards a beginner if you want more
>  packagers. 
Although docs can always be better, you shouldn't necessarily assume
that docs (alone) can make you a good packager starting as an
unexperienced "beginner", as you call yourself.

As someone giving RPM packaging talks and courses, I think packaging
is not something you learn from a set of guidelines alone.  The most
important thing, besides reading theory, is browsing through existing
spec files.  Fedora has more than 4200 of them (not all are of the
same quality, b.t.w.).  From those examples, you can easily learn how
packages deal with init scripts, for example.

My advice:

-  Start reading <http://docs.fedoraproject.org/drafts/rpm-guide-en/>;.

-  Browse through some spec files, e.g. by going to the Fedora directory
   with 4200+ src.rpm's and get all the spec files like this:

   mkdir /tmp/specs
   for f in *.src.rpm; do
	rpm2cpio $f | (cd /tmp/specs; cpio -iuvdm '*.spec')
   done

-  Start experimenting and ask questions on a mailing list.

As others already pointed out, the example you gave has some really
bad parts in it and is certainly not an example of a good spec file.

-- 
--    Jos Vos <jos(a)xos.nl&gt;
--    X/OS Experts in Open Systems BV   |   Phone: [phone]
--    Amsterdam, The Netherlands        |     Fax: [phone]

[Gianluca Sforna]

On 6/7/07, Jos Vos <jos(a)xos.nl&gt; wrote:
>  My advice:
>
>  -  Start reading <http://docs.fedoraproject.org/drafts/rpm-guide-en/>;.
>
>  -  Browse through some spec files, e.g. by going to the Fedora directory
>     with 4200+ src.rpm's and get all the spec files like this:
>
>     mkdir /tmp/specs
>     for f in *.src.rpm; do
>          rpm2cpio $f | (cd /tmp/specs; cpio -iuvdm '*.spec')
>     done
>
>  -  Start experimenting and ask questions on a mailing list.
>  
Add to that:

 - subscribe to fedora-package-review list, so you get an idea of the
common mistakes a beginner does.

This is even more useful if you need a sponsor, since you are supposed
to do some reviews (partial, full, just comments, etc) in order to
show your understanding of the guidelines.

PS. btw, webim was already submitted for review in:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184080
you may want to contact the original submitter and start from his spec file.

[Scott Berry]

How is the contact made for the original sender I see no email or anything?
Just a reply to the bug?

Scott


-----Original Message-----
From: fedora-devel-list-bounces(a)redhat.com
[mailto:[e-mail]] On Behalf Of Gianluca Sforna
Sent: Thursday, June 07, 2007 4:27 PM
To: Development discussions related to Fedora Core
Subject: Re: a look at my spec file for Webmin

On 6/7/07, Jos Vos <jos(a)xos.nl&gt; wrote:
>  My advice:
>
>  -  Start reading <http://docs.fedoraproject.org/drafts/rpm-guide-en/>;.
>
>  -  Browse through some spec files, e.g. by going to the Fedora directory
>     with 4200+ src.rpm's and get all the spec files like this:
>
>     mkdir /tmp/specs
>     for f in *.src.rpm; do
>          rpm2cpio $f | (cd /tmp/specs; cpio -iuvdm '*.spec')
>     done
>
>  -  Start experimenting and ask questions on a mailing list.
>  
Add to that:

 - subscribe to fedora-package-review list, so you get an idea of the
common mistakes a beginner does.

This is even more useful if you need a sponsor, since you are supposed
to do some reviews (partial, full, just comments, etc) in order to
show your understanding of the guidelines.

PS. btw, webim was already submitted for review in:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184080
you may want to contact the original submitter and start from his spec file.

-- 
fedora-devel-list mailing list
fedora-devel-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list



-- 
No virus found in this incoming message.
Checked by AVG Free Edition. 
Version: 7.5.472 / Virus Database: 269.8.11/837 - Release Date: 6/6/2007
2:03 PM

[Patrice Dumas]

On Thu, Jun 07, 2007 at 06:49:37PM -0500, Scott Berry wrote:
>  How is the contact made for the original sender I see no email or
> anything?
>  Just a reply to the bug? 
You should see a mail adress only if you login to bugzilla. This
hopefully helps reducing the spam.

--
Pat