libsoup 2.54.0 accidental ABI break fixed in 2.54.1

[Debarshi Ray]

A heads-up for those owning packages linking against libsoup.  It
might be safer to just rebuild all such packages against 2.54.1.

----- Forwarded message from Dan Winship <danw(a)gnome.org&gt; -----

Date: Tue, 26 Apr 2016 08:45:54 -0400
From: Dan Winship <danw(a)gnome.org&gt;
To: distributor-list(a)gnome.org
Subject: libsoup 2.54.0 accidental ABI break fixed in 2.54.1

libsoup 2.54.0 accidentally broke ABI (by adding a member to a class
struct and not removing a corresponding padding member). libsoup 2.54.1
(just released now) fixes this again; any packages that were built
against 2.54.0 (or 2.53.92) will need to be rebuilt against 2.54.1
(though packages built against 2.53.90 or earlier are fine).

(Just to clarify on the versions: this is a stable release in the GNOME
3.20 series, but there has not yet been a release in the 3.21 series, so
libsoup 2.54.1 is now also the latest "unstable" release.)

-- Dan

[Alexander Bokovoy]

On Wed, 27 Apr 2016, Debarshi Ray wrote:
> A heads-up for those owning packages linking against libsoup.  It
> might be safer to just rebuild all such packages against 2.54.1. 
For Fedora 24 beta
I guess we are self-consistent but after beta freeze
is done we would need to rebuild everything depending on libsoup, right?

> ----- Forwarded message from Dan Winship <danw(a)gnome.org&gt; -----
>
> Date: Tue, 26 Apr 2016 08:45:54 -0400
> From: Dan Winship <danw(a)gnome.org&gt;
> To: distributor-list(a)gnome.org
> Subject: libsoup 2.54.0 accidental ABI break fixed in 2.54.1
>
> libsoup 2.54.0 accidentally broke ABI (by adding a member to a class
> struct and not removing a corresponding padding member). libsoup 2.54.1
> (just released now) fixes this again; any packages that were built
> against 2.54.0 (or 2.53.92) will need to be rebuilt against 2.54.1
> (though packages built against 2.53.90 or earlier are fine).
>
> (Just to clarify on the versions: this is a stable release in the GNOME
> 3.20 series, but there has not yet been a release in the 3.21 series, so
> libsoup 2.54.1 is now also the latest "unstable" release.)
>
> -- Dan 


> --
> devel mailing list
> devel(a)lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/[e-mail] 

-- 
/ Alexander Bokovoy

[Milan Crha]

On Wed, 2016-04-27 at 12:56 +0300, Alexander Bokovoy wrote:
>  For Fedora 24 beta I guess we are self-consistent but after beta
>  freeze is done we would need to rebuild everything depending on
>  libsoup, right? 

	Hi,
anything what subclasses from SoupAuthClass reduces the amount. It
includes for example evolution-data-server (for e-soup-auth-
bearer.h/.c) and evolution-ews (for e-soup-auth-negotiate.h/.c).

While the usual claim is:
   GLib-GObject-WARNING **: specified class size for type
   'ESoupAuthBearer' is smaller than the parent type's 'SoupAuth'
   class size
(copied from https://bugzilla.gnome.org/show_bug.cgi?id=765222 ), I
didn't get "size is bigger" when I used the updated libsoup in the F24,
thus either the ABI check is faulty in the opposite case, or, more
likely, it's not a problem (as subclasses can add items to the class,
thus they can be larger).

I do not know whether there is any way of searching source packages and
their sources for the existence of SoupAuthClass string, even it would
be helpful to check which packages to rebuild "just in case".

There could also be some automatic way of checking the build.log-s, to
see which packages were not build against libsoup 2.54.0(.x) and
rebuild only them. That would help too.

Rebuilding everything what requires libsoup, then transitively what
requires those packages (the usage in the evolution-data-server is part
of the public API) would mean a significant amount of packages to be
rebuilt.

	Bye,
	Milan

P.S.: The libsoup F24 update to 2.54.1 is filled here:
      https://bodhi.fedoraproject.org/updates/FEDORA-2016-f104225abc

[Michael Catanzaro]

On Wed, 2016-04-27 at 12:14 +0200, Milan Crha wrote:
>  I do not know whether there is any way of searching source packages
>  and
>  their sources for the existence of SoupAuthClass string, even it
>  would
>  be helpful to check which packages to rebuild "just in case". 
Dunno a way to do this for Fedora, but Debian code search is probably a
pretty good approximation:

https://codesearch.debian.net/results/SoupAuthClass/page_0

lazarus, soup-sharp, evolution-data-server, evolution-ews

[Milan Crha]

On Wed, 2016-04-27 at 09:01 -0500, Michael Catanzaro wrote:
>  Dunno a way to do this for Fedora, but Debian code search is
> probably
>  a pretty good approximation:
>  
>  https://codesearch.debian.net/results/SoupAuthClass/page_0
>  
>  lazarus, soup-sharp, evolution-data-server, evolution-ews 
	Hi,
thanks, that sounds fine. I made a build root override for
libsoup-2.54.1-1.fc24 with an expiration set on 2016-05-04 and I've
prepared the evolution-data-server and evolution-ews to be rebuild
against it once the
   $ koji wait-repo f24-build --build=libsoup-2.54.1-1.fc24
will succeed.

I do not have commit rights for the lazarus, neither soup-sharp, thus
someone else might step in and rebuild them against the updated libsoup
too.

I will add the two evolution-related packages into the libsoup update
once the builds are done.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f104225abc
	Bye,
	Milan