Re: rpms/ettercap/FC-5 ettercap.spec,1.13,1.14

[Patrice Dumas]

On Fri, Mar 23, 2007 at 12:06:06PM -0400, Jon Ciesla wrote:
> Index: ettercap.spec
>
> RCS file: /cvs/extras/rpms/ettercap/FC-5/ettercap.spec,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -r1.13 -r1.14
> --- ettercap.spec	23 Mar 2007 14:54:22 -0000	1.13
> +++ ettercap.spec	23 Mar 2007 16:05:33 -0000	1.14
> @@ -96,7 +96,7 @@
>  make install DESTDIR=%{buildroot}
>  install -c -m 755 src/ettercap-gtk %{buildroot}%{_bindir}
>  mv %{buildroot}%{_bindir}/ettercap %{buildroot}%{_bindir}/ettercap-tui
> -#rm %{buildroot}%{_libdir}/ettercap/*.la
> +[ -f %{buildroot}%{_libdir}/ettercap/*.la ] && rm %{buildroot}%{_libdir}/ettercap/*.la
>  mkdir -p %{buildroot}%{_docdir}
>  install -c -m 644 %{SOURCE2} %{buildroot}%{_docdir}

I think that you should either do
rm %{buildroot}%{_libdir}/ettercap/*.la
to be sure that the build stops when there is no *.la file, or use the
simpler:
rm -f %{buildroot}%{_libdir}/ettercap/*.la

I would personally prefer a build that stop when files are no longer
there, but that is only a personal preference.

--
Pat

rpms/ettercap/FC-5 ettercap.spec,1.13,1.14

[Jon Ciesla]

In addition to other similar suggestions, I'm going to permanently resolve
the issue, merging the -plugins package into -common.  With the proper BR,
the files will always be there.  This issue was casued by a BR mistake in
the first place.
> On Fri, Mar 23, 2007 at 12:06:06PM -0400, Jon Ciesla wrote:
> > Index: ettercap.spec
> >
> > RCS file: /cvs/extras/rpms/ettercap/FC-5/ettercap.spec,v
> > retrieving revision 1.13
> > retrieving revision 1.14
> > diff -u -r1.13 -r1.14
> > --- ettercap.spec	23 Mar 2007 14:54:22 -0000	1.13
> > +++ ettercap.spec	23 Mar 2007 16:05:33 -0000	1.14
> > @@ -96,7 +96,7 @@
> >  make install DESTDIR=%{buildroot}
> >  install -c -m 755 src/ettercap-gtk %{buildroot}%{_bindir}
> >  mv %{buildroot}%{_bindir}/ettercap %{buildroot}%{_bindir}/ettercap-tui
> > -#rm %{buildroot}%{_libdir}/ettercap/*.la
> > +[ -f %{buildroot}%{_libdir}/ettercap/*.la ] && rm
> > %{buildroot}%{_libdir}/ettercap/*.la
> >  mkdir -p %{buildroot}%{_docdir}
> >  install -c -m 644 %{SOURCE2} %{buildroot}%{_docdir}
>
> I think that you should either do
> rm %{buildroot}%{_libdir}/ettercap/*.la
> to be sure that the build stops when there is no *.la file, or use the
> simpler:
> rm -f %{buildroot}%{_libdir}/ettercap/*.la
>
> I would personally prefer a build that stop when files are no longer
> there, but that is only a personal preference.
>
> --
> Pat
>
> --
> fedora-devel-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/fedora-devel-list