In need of C++ gurus

[Jan Synacek]

Hi,

warzone2100 fails to build [1] and I have no idea how to fix that.
Most of the errors are:

main_sdl.cpp:79:13: error: expected unqualified-id before '__attribute__'
 static std::vector<screeninfo> displaylist; // holds all our possible
display lists
             ^
main_sdl.cpp:117:29: error: cannot convert 'bool' to '__vector(4)
__bool int' in initialization
 static bool mouseInWindow = true;
                             ^~~~
main_sdl.cpp:148:22: error: cannot convert 'bool' to '__vector(4)
__bool int' in initialization
 bool GetTextEvents = false;
                      ^~~~~

Could someone point me in the right direction? I've looked at [2], but
that doesn't seem to help much in this case.

[1] https://bugzilla.redhat.com/attachment.cgi?id=1254868
[2] https://gcc.gnu.org/gcc-7/porting_to.html

Cheers,
-- 
Jan Synacek
Software Engineer, Red Hat

[Dan Horák]

On Mon, 20 Feb 2017 09:15:46 +0100
Jan Synacek <jsynacek(a)redhat.com&gt; wrote:

>  Hi,
>  
>  warzone2100 fails to build [1] and I have no idea how to fix that.
>  Most of the errors are: 
it's a known problem on ppc64le, please search this lists archive, it
was discussed recently (switching from --std=c++11 to --std=gnu++11 ??)


		Dan

> 
> main_sdl.cpp:79:13: error: expected unqualified-id before
> '__attribute__' static std::vector<screeninfo> displaylist; // holds
> all our possible display lists
>              ^
> main_sdl.cpp:117:29: error: cannot convert 'bool' to '__vector(4)
> __bool int' in initialization
>  static bool mouseInWindow = true;
>                              ^~~~
> main_sdl.cpp:148:22: error: cannot convert 'bool' to '__vector(4)
> __bool int' in initialization
>  bool GetTextEvents = false;
>                       ^~~~~
> 
> Could someone point me in the right direction? I've looked at [2], but
> that doesn't seem to help much in this case.
> 
> [1] https://bugzilla.redhat.com/attachment.cgi?id=1254868
> [2] https://gcc.gnu.org/gcc-7/porting_to.html
> 
> Cheers,
> -- 
> Jan Synacek
> Software Engineer, Red Hat
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org

[Jakub Jelinek]

On Mon, Feb 20, 2017 at 09:15:46AM +0100, Jan Synacek wrote:
>  Hi,
>  
>  warzone2100 fails to build [1] and I have no idea how to fix that.
>  Most of the errors are:
>  
>  main_sdl.cpp:79:13: error: expected unqualified-id before '__attribute__'
>   static std::vector<screeninfo> displaylist; // holds all our possible
>  display lists
>               ^
>  main_sdl.cpp:117:29: error: cannot convert 'bool' to '__vector(4)
>  __bool int' in initialization
>   static bool mouseInWindow = true;
>                               ^~~~
>  main_sdl.cpp:148:22: error: cannot convert 'bool' to '__vector(4)
>  __bool int' in initialization
>   bool GetTextEvents = false;
>                        ^~~~~
>  
>  Could someone point me in the right direction? I've looked at [2], but
>  that doesn't seem to help much in this case. 
That looks like C++ and altivec.h on PowerPC.  altivec.h changes the
meaning of bool and vector keywords, so it is essential in what order
and what mode you include it if you really need it (easiest is of course
not include it at all).  In general, for the non-ISO modes (i.e.
-std=gnu++98, -std=gnu++11, -std=gnu++14, -std=gnu++17 etc.) altivec.h
and preprocessor uses for these two context sensitive preprocessing, which
usually works with most of the C++ code, while if you compile in strict ISO
modes (-std=c++98, -std=c++11, -std=c++14, -std=c++17 etc.), then altivec.h
redefines vector and bool to the altivec.h stuff, so in that case you must
not include any standard C++ headers after including altivec.h and avoid
bool/vector or #undef them if you want the standard C++ meaning of those
(bool keyword and std::vector).

So if you are using -std=c++* mode, easiest fix is to change it to
-std=gnu++* mode.  Otherwise you need to provide more details.

	Jakub

[Florian Weimer]

On 02/20/2017 09:27 AM, Jakub Jelinek wrote:
>  That looks like C++ and altivec.h on PowerPC.  altivec.h changes the
>  meaning of bool and vector keywords, so it is essential in what order
>  and what mode you include it if you really need it (easiest is of course
>  not include it at all).  In general, for the non-ISO modes (i.e.
>  -std=gnu++98, -std=gnu++11, -std=gnu++14, -std=gnu++17 etc.) altivec.h
>  and preprocessor uses for these two context sensitive preprocessing, which
>  usually works with most of the C++ code, while if you compile in strict ISO
>  modes (-std=c++98, -std=c++11, -std=c++14, -std=c++17 etc.), then altivec.h
>  redefines vector and bool to the altivec.h stuff, so in that case you must
>  not include any standard C++ headers after including altivec.h and avoid
>  bool/vector or #undef them if you want the standard C++ meaning of those
>  (bool keyword and std::vector). 
Can we please put a #pragma into <altivec.h> which enables the 
context-sensitive parsing even for the non-GNU modes?  Including 
<altivec.h> should be sufficient to turn on this kind of magic processing.

Thanks,
Florian

[Jan Synacek]

On Mon, Feb 20, 2017 at 9:27 AM, Jakub Jelinek <jakub(a)redhat.com&gt; wrote:
>  On Mon, Feb 20, 2017 at 09:15:46AM +0100, Jan Synacek wrote:
> > Hi,
> >
> > warzone2100 fails to build [1] and I have no idea how to fix that.
> > Most of the errors are:
> >
> > main_sdl.cpp:79:13: error: expected unqualified-id before '__attribute__'
> >  static std::vector<screeninfo> displaylist; // holds all our possible
> > display lists
> >              ^
> > main_sdl.cpp:117:29: error: cannot convert 'bool' to '__vector(4)
> > __bool int' in initialization
> >  static bool mouseInWindow = true;
> >                              ^~~~
> > main_sdl.cpp:148:22: error: cannot convert 'bool' to '__vector(4)
> > __bool int' in initialization
> >  bool GetTextEvents = false;
> >                       ^~~~~
> >
> > Could someone point me in the right direction? I've looked at [2], but
> > that doesn't seem to help much in this case.
>
>  That looks like C++ and altivec.h on PowerPC.  altivec.h changes the
>  meaning of bool and vector keywords, so it is essential in what order
>  and what mode you include it if you really need it (easiest is of course
>  not include it at all).  In general, for the non-ISO modes (i.e.
>  -std=gnu++98, -std=gnu++11, -std=gnu++14, -std=gnu++17 etc.) altivec.h
>  and preprocessor uses for these two context sensitive preprocessing, which
>  usually works with most of the C++ code, while if you compile in strict ISO
>  modes (-std=c++98, -std=c++11, -std=c++14, -std=c++17 etc.), then altivec.h
>  redefines vector and bool to the altivec.h stuff, so in that case you must
>  not include any standard C++ headers after including altivec.h and avoid
>  bool/vector or #undef them if you want the standard C++ meaning of those
>  (bool keyword and std::vector).
>
>  So if you are using -std=c++* mode, easiest fix is to change it to
>  -std=gnu++* mode.  Otherwise you need to provide more details. 
Thanks Dan and Jakub! There was a "-std=c++11" hidden in the
configure, it was there because of some weird reason and simply
removing it helped.

-- 
Jan Synacek
Software Engineer, Red Hat