12:40 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1187337
--- Comment #2 from Carlos Morel-Riquelme <empateinfinito(a)gmail.com> ---
Thanks for the reply Parag, well i read all guidelines and follow your
recommendations, about fedora review tool when i run
fedora-review --mock-config fedora-rawhide-x86_64 -n sil-coval-fonts
i have the error mock 127, this is reported here
https://bugzilla.redhat.com/show_bug.cgi?id=1185565 , but the review finish
fine. here are some output.
review.txt
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[ ]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Test run failed
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
fonts:
[ ]: This text should never be shown.
Note: Test run failed
[ ]: Run repo-font-audit on all fonts in package.
Note: Test run failed
[ ]: Run ttname on all fonts in package.
Note: Test run failed
Rpmlint
-------
Checking: sil-coval-fonts-0.1-1.fc22.noarch.rpm
sil-coval-fonts-0.1-1.fc22.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
sil-coval-fonts (rpmlib, GLIBC filtered):
/bin/sh
config(sil-coval-fonts)
fontpackages-filesystem
Provides
--------
sil-coval-fonts:
config(sil-coval-fonts)
font(:lang=aa)
font(:lang=ab)
font(:lang=ak)
font(:lang=an)
font(:lang=ast)
font(:lang=av)
font(:lang=ay)
font(:lang=az-az)
font(:lang=ba)
font(:lang=be)
font(:lang=bg)
font(:lang=bi)
font(:lang=bin)
font(:lang=br)
font(:lang=bs)
font(:lang=bua)
font(:lang=ce)
font(:lang=ch)
font(:lang=chm)
font(:lang=co)
font(:lang=crh)
font(:lang=cs)
font(:lang=csb)
font(:lang=cu)
font(:lang=cv)
font(:lang=cy)
font(:lang=da)
font(:lang=de)
font(:lang=el)
font(:lang=en)
font(:lang=eo)
font(:lang=es)
font(:lang=et)
font(:lang=eu)
font(:lang=fat)
font(:lang=fi)
font(:lang=fil)
font(:lang=fj)
font(:lang=fo)
font(:lang=fr)
font(:lang=fur)
font(:lang=fy)
font(:lang=ga)
font(:lang=gd)
font(:lang=gl)
font(:lang=gn)
font(:lang=gv)
font(:lang=haw)
font(:lang=ho)
font(:lang=hr)
font(:lang=hsb)
font(:lang=ht)
font(:lang=hu)
font(:lang=hz)
font(:lang=ia)
font(:lang=id)
font(:lang=ie)
font(:lang=ig)
font(:lang=ik)
font(:lang=io)
font(:lang=is)
font(:lang=it)
font(:lang=jv)
font(:lang=kaa)
font(:lang=ki)
font(:lang=kj)
font(:lang=kk)
font(:lang=ku-tr)
font(:lang=kum)
font(:lang=kv)
font(:lang=kw)
font(:lang=kwm)
font(:lang=ky)
font(:lang=la)
font(:lang=lb)
font(:lang=lez)
font(:lang=lg)
font(:lang=li)
font(:lang=ln)
font(:lang=mg)
font(:lang=mi)
font(:lang=mk)
font(:lang=mn-mn)
font(:lang=mo)
font(:lang=ms)
font(:lang=na)
font(:lang=nb)
font(:lang=nds)
font(:lang=ng)
font(:lang=nl)
font(:lang=nn)
font(:lang=no)
font(:lang=nr)
font(:lang=nso)
font(:lang=ny)
font(:lang=oc)
font(:lang=om)
font(:lang=os)
font(:lang=pap-an)
font(:lang=pap-aw)
font(:lang=pl)
font(:lang=pt)
font(:lang=qu)
font(:lang=quz)
font(:lang=rm)
font(:lang=rn)
font(:lang=ro)
font(:lang=ru)
font(:lang=rw)
font(:lang=sah)
font(:lang=sc)
font(:lang=sel)
font(:lang=sg)
font(:lang=sh)
font(:lang=shs)
font(:lang=sk)
font(:lang=sl)
font(:lang=sm)
font(:lang=sma)
font(:lang=smj)
font(:lang=smn)
font(:lang=sn)
font(:lang=so)
font(:lang=sq)
font(:lang=sr)
font(:lang=ss)
font(:lang=st)
font(:lang=su)
font(:lang=sv)
font(:lang=sw)
font(:lang=tg)
font(:lang=tk)
font(:lang=tl)
font(:lang=tn)
font(:lang=to)
font(:lang=tr)
font(:lang=ts)
font(:lang=tt)
font(:lang=tw)
font(:lang=ty)
font(:lang=tyv)
font(:lang=uk)
font(:lang=uz)
font(:lang=ve)
font(:lang=vo)
font(:lang=vot)
font(:lang=wa)
font(:lang=wen)
font(:lang=wo)
font(:lang=xh)
font(:lang=yap)
font(:lang=yo)
font(:lang=za)
font(:lang=zu)
font(coval)
sil-coval-fonts
Source checksums
----------------
http://openfontlibrary.org/assets/downloads/bretan/79f39f3224dd7db0aae8fc...
:
CHECKSUM(SHA256) this package :
d1441cca556f93ed46e7d9e83cef687a2f4f2f59be70f8676be39f3445eb0753
CHECKSUM(SHA256) upstream package :
d1441cca556f93ed46e7d9e83cef687a2f4f2f59be70f8676be39f3445eb0753
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -n
sil-coval-fonts
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, fonts, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
finally i don't know if i need submit other file ?
well, i really appreciate any suggestion :)
thanks parag
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=X514DAJ2WK&a=cc_unsubscribe