Re: Fedora Review Service
I created the Fedora Infra ticket
https://pagure.io/fedora-infrastructure/issue/11028
Jakub
On Sat, Dec 3, 2022 at 1:00 PM Jakub Kadlcik <jkadlcik(a)redhat.com> wrote:
> fedora-review require a lot of manual checks from reviewer (especially
> licenses). It can't be fully automated.
That's true but my goal isn't to fully automate the process. A person
will always be required to take the final look and make sure the spec
is reasonably written and the package is acceptable.
I am looking at it the other way around. I did many reviews where I
run fedora-review and it printed an issues section and/or some [!]
checks, so I basically just copy-pasted them into the RHBZ as a
comment and provided some context about them for the contributor. The
problem is, that the contributor needed to wait days/weeks/months for
feedback that CI could have provided immediately.
My hope is also that by saving reviewers the time to point out the
easy mistakes, we will have time to focus only on the things that, as
you said, can't be automatized, and therefore cover more tickets as a
consequence.
Jakub
On Sat, Dec 3, 2022 at 12:25 PM Vitaly Zaitsev via devel
<devel(a)lists.fedoraproject.org> wrote:
>
> On 02/12/2022 18:20, Jakub Kadlcik wrote:
> > I started working on a service [2] that listens to fedora-messaging
> > and for every new RHBZ review ticket or a new comment with updated
> > packages, it submits a build in Copr. Thanks to this [1] feature, Copr
> > automatically runs the fedora-review tool and generates the
> > review.txt file. Once the build is finished, my service gets the
> > message and generates a helpful comment (so far only to STDOUT).
>
> fedora-review require a lot of manual checks from reviewer (especially
> licenses). It can't be fully automated.
>
> But posting this as a template for the reviewer is good idea. +1.
>
> --
> Sincerely,
> Vitaly Zaitsev (vitaly(a)easycoding.org)
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue