Re: [PSA] %meson contains -Db_ndebug=true

[Igor Gnatenko]

Ok, I have reverted change:

* https://bodhi.fedoraproject.org/updates/FEDORA-2019-42ea21c6e4
* https://bodhi.fedoraproject.org/updates/FEDORA-2019-660ccd306c
* https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-eb940f069c
* https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-d229ead72a
* https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-9f6eea54fe

On Mon, Apr 8, 2019 at 12:59 PM Kalev Lember <kalevlember(a)gmail.com&gt; wrote:

>  On 4/8/19 11:13, Florian Weimer wrote:
>  > * Peter Hutterer:
>  >
>  >> On Mon, Apr 08, 2019 at 09:20:35AM +0200, Igor Gnatenko wrote:
>  >>> Hello,
>  >>>
>  >>> While fixing mesa build which was slow due to a lot off debug stuff
>  >>> (assert()), I've added -Db_ndebug=true into the %meson macro.
>  >>>
>  >>> This seemed like good approach because in Fedora we should not use
>  debug
>  >>> bits in runtime (not related to debuginfo). However this caused some
>  >>> breakage in some packages like libratbag which was relying on assert()
>  in
>  >>> tests. This should be really fixed in affected packages..
>  >>>
>  >>> I am not convinced that we should revert meson change.. Let me know if
>  you
>  >>> think otherwise and why.
>  >>
>  >> IMO if asserts cause a slow build in mesa, mesa should disable asserts.
>  >>
>  >> Pushing this into the build system means you're changing the behaviour
>  of
>  >> every package build with meson. I rely on asserts in several packages
>  for
>  >> paths that must not happen - removing those asserts means instead of
>  >> crashing we now have undefined behaviour, probably leaking things.
>  >
>  > I agree.
>  >
>  > Fedora should follow upstream defaults here, like most other
>  > distributions.  Most upstreams leave assertions enabled.
>
>  I agree as well. Please don't override -Db_ndebug in distro-wide %meson
>  macro and instead move the override to mesa packaging if it's needed there.
>
>  Kalev
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>