Hello Jerry,
I proposed a workaround a few days ago
https://pagure.io/FedoraReview/pull-request/485
but your patch looks like a proper fix. I'll try it and merge to the
fedora-review codebase.
Does anybody know what was the purpose of --resolve and if it will be
no problem when we remove it?
Jakub
On Tue, Jul 18, 2023 at 12:39 AM Sandro <lists(a)penguinpee.nl> wrote:
On 17-07-2023 20:39, Jerry James wrote:
> On Mon, Jul 17, 2023 at 10:54 AM Jerry James <loganjerry(a)gmail.com> wrote:
>> Like many of you, I have been quite inconvenienced because of
>> dnf5-related breakage of fedora-review. I've been monkeying with it
>> today and finally got a successful run of fedora-review after making
>> the following changes [*].
>>
>> 1. Edit /etc/mock/templates/fedora-rawhide.tpl. Change:
>>
>> config_opts['package_manager'] = 'dnf'
>>
>> to:
>>
>> config_opts['package_manager'] = 'dnf5'
>>
>> 2. Run 'mock -r fedora-rawhide-x86_64 --scrub=bootstrap'
>>
>> 3. Edit /usr/lib/python3.11/site-packages/FedoraReview/deps.py. Change line
>> 83 from:
>>
>> "dnf repoquery -q -C --requires --resolve " + "
".join(list(set(pkgs))),
>>
>> to:
>>
>> "dnf repoquery -q -C --requires " + "
".join(list(set(pkgs))),
>>
>> Change line 97 from:
>>
>> name = line.rsplit(".", 2)[0]
>>
>> to:
>>
>> name = resolve_one(line)[0].rsplit(".", 2)[0]
>>
>> Change line 286 from:
>>
>> "dnf repoquery -C -l " + "
".join(list(set(pkgs))),
>>
>> to:
>>
>> "dnf repoquery --files " + "
".join(list(set(pkgs))),
>>
>> Other changes may be needed.
>>
>> [*] Altering rpm-controlled files is generally a bad idea, and I do not
>> recommend it. I am only doing so in this case because fedora-review does
>> not work at all without these changes. I understand that my changes will
>> be overwritten the next time a mock-core-configs or fedora-review update
>> is installed.
>
> Skip steps 1 and 2. They are unnecessary. Step 3 is all you need.
Would that be a temporary solution for Copr as well? I mean for all
rawhide builds? I quite miss not having fedora-review available there.
-- Sandro
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue