Re: Review swaps: A bunch of PHP libraries
Christopher Engelhard kirjoitti 16.7.2021 klo 11.39:
Hi all,
I finally found some time to unbundle all the 3rdparty PHP/composer
libraries from the nextcloud package.
The bad news is that due to their various dependency trees, I now have a
total of 24 new packages that need reviewing.
The good news is that I think quite a few of them will be generally
useful beyond just nextcloud.
They are all fairly small & simple PHP libraries, build without issues
and are basically identical in terms of packaging. If there are people
out there who'd like to try their hand at reviewing for the first time,
one of these might be a good place to start.
Obviously, if you need something reviewed in return, I'd be happy to do
that.
Full list of links is below, but to make it easier for people
- I set up a dependency tree (
https://bugzilla.redhat.com/buglist.cgi?bug_id=1981857&bug_id_type=an...
) so you can pick a leaf.
- I made a copr repository (
https://copr.fedorainfracloud.org/coprs/lcts/nextcloud/packages/ ) that
has builds for all of these, including fedora-review/rpmlint logs (and a
big thank you to whoever made that last bit possible in Copr, that was
*extremely* useful). The repo also contains a few forks of existing
packages, ignore those :) .
I will review at least some of these, depending on how much time I find.
I will flag anything I have ongoing as appropriate, so others are free
to take any that have not been flagged.
In exchange, you could take a look at either or both of these that I
have waiting for a reviewer:
mt32emu - C/C++ library for emulating Roland MT-32, CM-32L and LAPC-I
synthesizer modules
A cmake project that is somewhat complicated by the fact that it comes
from a monorepo that also contains other related projects.
https://bugzilla.redhat.com/show_bug.cgi?id=1980482
rubygem-sync - A module that provides a two-phase lock with a counter
Ruby library whose specfile was automatically generated with gem2rpm,
only small adjustements were needed on top of that.
https://bugzilla.redhat.com/show_bug.cgi?id=1978395
Otto