Otto Liljalaakso <otto.liljalaakso(a)iki.fi> writes:
Hello everybody,
I would like to gather different use cases for the 'fedpkg
scratch-build' command.
Currently, this is exactly the same as 'fedpkg build --scratch', meaning
that is performs a scratch build of the pushed head of the current
branch. At least in my workflow, I only do scratch builds before
pushing, to ensure that what I am about to push builds correctly in
Koji. Because if this, I never use the default form. Instead, I always
specify 'fedpkg scratch-build --srpm', so that the srpm to build from is
locally generated from the local working directory.
What I would like to do is to submit a pull request to either fedpkg or
rpkg, making that the default. It is a single line code change, not
counting changes to documentation and code comments.
Doing a scratch build from the pushed contents would still be possible
by either a) using 'fedpkg build --scratch' or b) checking out the
remote head and then issuing 'fedpkg scratch-build'.
Above change seems like a clear improvement to me, making the most used
option the default. But I have noticed that workflows differ wildly
between packagers, so before submitting any code for review, I would
like to hear if somebody regularly uses the default form 'fedpkg
scratch-build' and thinks it currently does the right thing.
I pretty much use fedpkg scratch-build only with the --srpm option in
the same way that you do. Thus I very welcome this change and thank you
for submitting this pull request!
Cheers,
Dan