Hello Sandro,
I noticed that in f39 builds in Copr the directory containing the
results is now named after the package. Comparing that to the
"traditional" fedora-review directory in f38 builds, I miss the
`licensecheck.txt` file.
It suddenly started happening and I don't know what is to blame yet.
You can follow
https://github.com/FrostyX/fedora-review-service/issues/28
https://pagure.io/FedoraReview/issue/486
I plan to work on it as soon as I can.
Jakub
On Wed, Jul 26, 2023 at 1:34 AM Sandro <lists(a)penguinpee.nl> wrote:
>
> On 25-07-2023 04:47, Michel Alexandre Salim wrote:
> > Once this lands in F38, Fedora Review Service should be fixed, unless
> > I'm missing something.
>
> First of all, thanks for bringing fedora-review back. I rely on it quite
> a bit reviewing my own packages as well as for official reviews.
>
I noticed that in f39 builds in Copr the directory containing the
results is now named after the package. Comparing that to the
"traditional" fedora-review directory in f38 builds, I miss the
`licensecheck.txt` file.
>
> The contents of the fedora-review directory ($PACKAGE_NAME) in f39 look
> more alike to a local fedora-review, which is fine. But
> `licensecheck.txt` is invaluable for checking licenses of generated
> files. Just now I finished a review using the f38 build, which detected
> two additional licenses in generated files, that went unnoticed by the
> submitter.
>
> Can `licensecheck.txt` be added back to f39 fedora-review runs, please?
>
> -- Sandro
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue