Re: fstrim and LUKS [Re: Fedora 32 System-Wide Change proposal: Enable fstrim.timer by default]
On Friday, December 20, 2019 7:27:20 PM MST Chris Murphy wrote:
On Fri, Dec 20, 2019 at 5:42 PM John M. Harris Jr
<johnmh(a)splentity.com>
wrote:
>
>
> On Friday, December 20, 2019 1:53:41 PM MST Chris Murphy wrote:
>
> > On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil
> > <jan.kratochvil(a)redhat.com> wrote:
> >
> >
> >
> > >
> > >
> > >
> > > On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote:
> > >
> > >
> > >
> > > > == Summary ==
> > > > Enabling fstrim.timer will cause fstrim.service to execute weekly,
> > > > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet`
> > >
> > >
> > >
> > >
> > >
> > > This is AFAIK not enough for LUKS drives, will it be supported for
> > > LUKS?
> >
> >
> >
> >
> > Good question. This change [1] happened in Fedora 27. But because
> > there's neither `discard` mount option, nor fstrim.timer enabled by
> > default, that feature doesn't really do anything for most users. This
> > feature proposal would build on that previous approval.
> >
> >
> >
> > If your LUKS drives are listed in fstab, they will have fstrim issued
> > and it will pass down to the physical drive. I've updated the proposal
> > how to modify fstrim.service unit to specify --all instead of --fstab,
> > so all mounted devices have fstrim passed to them.
> >
> >
> >
> > [1]
> > https://fedoraproject.org/wiki/Changes/EnableTrimOnDmCrypt
>
>
>
> What do you mean about the `discard` option? If users wish to enable
> `discard`, they can do so. For LUKs devices, this is already the default,
> if one uses Anaconda to install.
"discard mount option" and "fstrim.timer" refer to the mounted file
system. The /etc/crypttab discard option only allows discards to
passthrough from the file system to the device, enabling it doesn't
cause discards to happen.
I understand that. See my previous message...
--
John M. Harris, Jr.
Splentity