Re: fedpkg build version numbering discrepancy

[Jean-Marc Pigeon]

On Thu, 2011-01-27 at 16:27 -0700, Nathanael D. Noblet wrote:
>  On 01/27/2011 04:10 PM, Jean-Marc Pigeon wrote:
>  > Hello,
>  >
>  > 	Hoping to be wrong.
>  >
>  > 	Today I was working on my package after a long time,
>  > 	I upgraded from version 2.1-320 to 2.1-400.
>  >
>  > 	I didn't "fedpkg new-sources" and only updated
>  > 	the spec file to be 2.1-400 (sources file was
>  > 	still referring to 2.1-320).
>  > 	fedpkg commit ; fedpkg push
>  >
>  > 	Next, fedpkg build
>  >
>  > 	Koji reported me 2.1-400 was compiled no trouble.
>  > 	how come? new tar file was not event uploaded...
>  >
>  > 	Is my understanding right?, koji build
>  > 	report "spec file" version while crunching
>  > 	"sources file" version!
>  > 	Did I missed something or we are in "easy mistake"
>  > 	situation??.
>  
>  Really depends if the rpm Version tag is 2.1-400 or if you are talking 
>  about Version: 2.1, Release: 400.
>  
>  The Release is the number of times the package at that upstream version  
	I am the
upstream too.
>  has been packaged. When unpacking the source it expects (unless
> you've 
>  given it a different path) to find the sources as package-version so 
>  package-2.1 in your case, and the 320,400 means nothing... 
	my mistake, I used
'-' while I should have use ".'
>  
>  
>  If you aren't talking about Release: 400 then everything I've said above 
>  is null and void and I have no idea. 
	rversion=2.1
	subversion=400


	Spec file extract:
	Version: %{rversion}.%{subversion}
	Release: 2%{?locmark}
	Source: ...../%{name}-%{version}.tar.gz

	So the potential for disasters is real?
	


	



-- 
A bientôt
==========================================================================
Jean-Marc Pigeon                                   Internet: jmp(a)safe.ca
SAFE Inc.                                          Phone: [phone]
                                                   Fax:   [phone]
        Clement, 'a kiss solution' to get rid of SPAM (at last)
           Clement' Home base <"http://www.clement.safe.ca">
==========================================================================