Re: Default LDFLAGS in build system - possible problems

[Zdenek Dohnal]

On 2/28/19 12:04 PM, Florian Weimer wrote:
>  * Zdenek Dohnal:
>
> > I, as Fedora's vim co-maintainer, encountered the issue with default
> > LDFLAGS.
> >
> > I tried to manually run configure script for Vim, with ruby support
> > enabled, but it always failed with error message about missing ncurses
> > (ncurses-devel was installed though). When I looked into config.log, I saw:
> >
> > configure:12069: gcc -o conftest -g -O2  -L. -Wl,-z,relro   -Wl,-z,now
> > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fstack-protector
> > -rdynamic -Wl,-export-dynamic  -L/usr/local/lib conftest.c  -lselinux 
> > -lncurses >&5
> > conftest.c: In function 'main':
> > conftest.c:67:26: warning: implicit declaration of function 'tgetent'
> > [-Wimplicit-function-declaration]
> >  char s[10000]; int res = tgetent(s, "thisterminaldoesnotexist");
> >                           ^~~~~~~
> > /usr/bin/ld: /tmp/ccivPtT5.o: relocation R_X86_64_32 against
> > `.rodata.str1.1' can not be used when making a PIE object; recompile
> > with -fPIC
> > /usr/bin/ld: final link failed: nonrepresentable section on output
> > collect2: error: ld returned 1 exit status
>  This is a bug in the configure script.  It needs to pass the original
>  CFLAGS when compiling link tests.
>
>  The command is set correctly initially:
>
>  | ac_link='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext
> $LIBS >&5'
>
>  So something appears to reset CFLAGS in the script. 
Actually it was like Tom wrote - Fedora specific linker flags were used,
but compiler flags were not. When I added including Fedora specific
compiler flags to configure script, it started to work.

Now let's hope upstream will take it.

Thank you for the hint too though :) .

>  Thanks,
>  Florian
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail] 
-- 
Zdenek Dohnal
Associate Software Engineer
Red Hat Czech - Brno TPB-C