Otto Liljalaakso kirjoitti 16.1.2023 klo 23.31:
Miro Hrončok kirjoitti 16.1.2023 klo 16.05:
> On 16. 01. 23 14:57, Richard Shaw wrote:
>>
>> Since `fedpkg scratch-build` bombs out with an error if you've made
>> local changes I propose a slight modification:
>>
>> If no changes are made then it does a normal scratch build for the
>> "does this still build / not build" 1% use case
>>
>> If there are local changes it automatically uploads an SRPM for the
>> 99% use case.
>
> I love this.
>
> $ fedpkg scratchbuild / $ fedpkg build --scratch
> Uncommitted changes found, uploading SRPM...
I like this modified proposal, too. It achieves what I wanted to do, and
(unlike my original idea) does not break the "1% case" for 'fedpkg
scratch-build'. I will try to create a pull request for this. More than
a single line needs to change, but it should not be too difficult.
Pull request that implements what is discussed above:
https://pagure.io/rpkg/pull-request/653