On 4/6/20 12:53 PM, Nicolas Mailhot via devel wrote:
Le lundi 06 avril 2020 à 09:03 +0200, Petr Pisar a écrit :
>
> # Build an HTML manual with ascidoc
> %bcond_without docs
> # Perform the tests
> %bcond_without tests
I feel the above syntax is hopeless. You need boilerplate (in all eln
specs!) to explain that foo_without tests means enabling tests.
Good syntax does not need line-by-line comments.
Agreed, but miscommenting only spreads the confusion further.
Once you accept what it actually does instead of thinking what you'd
wish it was, it starts making more sense:
# Add an option to build without running tests
%bcond_without tests
...because *that* is what it does. Also because of this,
%bcond_with/without is very ill-suited to the kind of distro-wide
default settings being discussed.
- Panu -
Regards,