(replying here to avoid multiple emails)
On Thu, Jan 19, 2023 at 01:48:16PM -0800, Gordon Messmer wrote:
On 2023-01-19 00:55, Lennart Poettering wrote:
> hat you could do is split up the problem: have iscsi-starter.service
> or so, that is separate from the iscsi.service main service.
I think this is the way to go. Lennart's solution is elegant and simple.
The unit *right now* has ConditionDirectoryNotEmpty, so it already is
skipped if /var/lib/iscsi/nodes is empty, so this change seems pretty
safe. It just moves the check to a better point in time.
I think this approach is much better than just downgrading the package
dependencies:
- it immediately works for people who upgrade and already have the
package installed without any local intervention.
- it also works for people who legitimately need the iscsi package,
so you avoid the effect where default installs are OK, but then the user
installs a bunch of packages and the next reboot is painful.
If I'm not mistaken, this approach would also probably need
approval by
FESCo, since it'd involve reverting the "default on" status of the iscsi
service. Is that right?
Yes. But it'd be more of a rubber stamp. If you remove the dep on
network-online.service, everybody will be happy.
Zbyszek