On Thu, Sep 26, 2019 at 15:49 Pierre-Yves Chibon wrote:
On Thu, Sep 26, 2019 at 03:40:49PM +0200, Miroslav Suchý wrote:
> Dne 26. 09. 19 v 15:10 Pierre-Yves Chibon napsal(a):
> > On Thu, Sep 26, 2019 at 03:01:25PM +0200, Remi Collet wrote:
> > > Le 26/09/2019 à 11:36, Pierre-Yves Chibon a écrit :
> > > > Here is what the vision we came to and that we would like to discuss:
> > > >
> > > > ○ Every changes to dist-git is done via pull-requests
> > > IMHO Have to stay optional, making this mandatory being a terrible
headache.
> > What makes it a headache? What can we do to not have this be a terrible
> > headache?
>
> I use PRs in Pagure a lot. And the Rebase/Merge functionality is broken most of the
time. For months.
> Fortunately it is still a git, so when the team agrees, we can merge and push PR
manually.
> Having PR a mandatory thing (relying on Pagure to do the merge) would be PITA for
me.
You'll notice I didn't mention any tools in the proposal. I specifically
didn't
want to limit ourself to our current tooling :)
Before we discuss how we want to implement something let's see if we can agree
on what that thing is :)
Note that git-pull-requests now support pagure. The tool takes care of
creating the fork, pushing the local changes and opening the PR:
https://github.com/Mergifyio/git-pull-request
Regards,
-Tristan