Re: ld error

[Nikola Pajkovsky]

Alain> Le dimanche 20 mars 2011 04:03:48, Kevin Kofler a écrit :
Alain> > Przemek Klosowski wrote:
Alain> > > On 03/11/2011 10:58 AM, Alain Portal wrote:
Alain> > >> Le vendredi 11 mars 2011 14:58:03, Stephen Gallagher a écrit :
Alain> > >>> On 03/11/2011 08:12 AM, Alain Portal wrote:
Alain> > >>>> Hi,
Alain> > >>>> 
Alain> > >>>> I trying to update kicad but the built fails with a ld
error:
Alain> > >>>>
http://koji.fedoraproject.org/koji/taskinfo?taskID=2903979
Alain> > >>>> and I don't succeed to fix it.
Alain> > >>>> 
Alain> > >>>> Can somebody help me?
Alain> > >>> 
Alain> > >>> Looks like you're not linking in BOARD::GetLayerColor(int)
and
Alain> > >>> BOARD::GetLayerName(int) const correctly. You should figure
out
Alain> > >>> what library or object file provides those and make sure
they're
Alain> > >>> listed in the linking step.
Alain> > >> 
Alain> > >> These functions are provided by pcbnew/class_board.cpp and I
don't
Alain> > >> know how to act on the linking step.
Alain> > > 
Alain> > > class_board.cpp.o is placed in libpcbcommon.o but the failing link
Alain> > > step, creating eeschema, only links to libcommon.o
Alain> > 
Alain> > Regression caused by this upstream commit:
Alain> >
http://bazaar.launchpad.net/~kicad-stable-committers/kicad/stable/revision/
Alain> > 2594
Alain> > 
Alain> > This moves class_layerchoicebox.cpp from pcbnew to common without
Alain> > realizing that it depends on stuff from pcbnew.
Alain> 
Alain> What is your secret Kevin?
Alain> 
Alain> Reported upstream.
Alain> Thanks.
Alain> 
Alain> Alain

Here we go, thanks Kevin to point the commit regression. The workaround is
pretty simple. I've moved class_layerchoicebox.cpp back to pcbnew and one
little tweak in CMakeLists.txt. See patch for more info.

Successful build http://koji.fedoraproject.org/koji/taskinfo?taskID=2930101

Happy hacking ;)

-- 
Nikola