Re: patch applied without package maintainers' approve
On Mon, Nov 09, 2020 at 08:03:59AM -0500, Neal Gompa wrote:
On Mon, Nov 9, 2020 at 8:03 AM Honggang LI <honli(a)redhat.com>
wrote:
>
> hi
>
> I'm one of package maintainers of rdma-core. There is a patch
> applied without any maintainers' review/approve. I had sent two emails
> to patch committer to ask him/her to push the change to upstream.
> But never get response.
>
> The patch maybe useful or fix something. But the divergence between
> upstream and Fedora rawhide is what I don't want to see, because
> such divergence is source of regression issues.
>
> What I should to do with that commit? Just blindly revert it?
Send it upstream yourself. If you don't like the divergence, help fix
it by sending the patch upstream and working with them.
To be honest, the patch was applied without any PR or bugzilla opened,
just very simple inline comment, I don't really understand the patch.
That is why I did not submit it to upstream.