%{_lib} leads to dir not found, whereas lib works fine (firefox-pkcs11-loader)

[Germano Massullo]

During package firefox-pkcs11-loader build, the following two spec file
lines

%dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
%_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json

and also this variant

%dir %{_libdir}/mozilla/pkcs11-modules/
%{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json

lead to errors

Directory not found:
/builddir/build/BUILDROOT/firefox-pkcs11-loader-3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
File not found:
/builddir/build/BUILDROOT/firefox-pkcs11-loader-3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json

(Copr build path URL [1] )

instead

%dir %_prefix/lib/mozilla/pkcs11-modules/
%_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json

works fine
(Copr build path URL [2] )

How can you explain this?

Thank you for your time


[1]: failed build
https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...

[2]: successful build
https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...

[Daniel P. Berrangé]

On Tue, Mar 06, 2018 at 03:29:58PM +0100, Germano Massullo wrote:
>  During package firefox-pkcs11-loader build, the following two spec
> file
>  lines
>  
>  %dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
>  %_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  and also this variant
>  
>  %dir %{_libdir}/mozilla/pkcs11-modules/
>  %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  lead to errors
>  
>  Directory not found:
> /builddir/build/BUILDROOT/firefox-pkcs11-loader-3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
>  File not found:
> /builddir/build/BUILDROOT/firefox-pkcs11-loader-3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  (Copr build path URL [1] )
>  
>  instead
>  
>  %dir %_prefix/lib/mozilla/pkcs11-modules/
>  %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  works fine
>  (Copr build path URL [2] )
>  
>  How can you explain this? 
%{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
to "/usr/lib64", but your app is installing files into "/usr/lib"
instead.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Germano Massullo]

Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
>  %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus
> expands
>  to "/usr/lib64", but your app is installing files into "/usr/lib"
>  instead. 
I suspected this, but I found no hardcoded paths in
https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
so I don't understand why it installs in /usr/lib

[Daniel P. Berrangé]

On Tue, Mar 06, 2018 at 03:46:38PM +0100, Germano Massullo wrote:
>  Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
>  > %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
>  > to "/usr/lib64", but your app is installing files into
> "/usr/lib"
>  > instead.
>  
>  I suspected this, but I found no hardcoded paths in
>  https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
>  so I don't understand why it installs in /usr/lib 
In the specfile it has  %{cmake} which expands to

  ...some compiler flags stuff...
  /usr/bin/cmake \
        -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
        -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
        -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
        -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
        -DCMAKE_INSTALL_PREFIX:PATH=/usr \
        -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
        -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
        -DSYSCONF_INSTALL_DIR:PATH=/etc \
        -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if "lib64" == "lib64" 
        -DLIB_SUFFIX=64 \
%endif 
        -DBUILD_SHARED_LIBS:BOOL=ON

So could be something not correctly honouring LIB_INSTALL_DIR and
or LIB_SUFFIX variables.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Germano Massullo]

Il 06/03/2018 15:50, Daniel P. Berrangé ha scritto:
>  On Tue, Mar 06, 2018 at 03:46:38PM +0100, Germano Massullo wrote:
> > Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
> >> %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
> >> to "/usr/lib64", but your app is installing files into
> "/usr/lib"
> >> instead.
> > I suspected this, but I found no hardcoded paths in
> > https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
> > so I don't understand why it installs in /usr/lib
>  In the specfile it has  %{cmake} which expands to
>
>    ...some compiler flags stuff...
>    /usr/bin/cmake \
>          -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
>          -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
>          -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
>          -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
>          -DCMAKE_INSTALL_PREFIX:PATH=/usr \
>          -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
>          -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
>          -DSYSCONF_INSTALL_DIR:PATH=/etc \
>          -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
>  %if "lib64" == "lib64" 
>          -DLIB_SUFFIX=64 \
>  %endif 
>          -DBUILD_SHARED_LIBS:BOOL=ON
>
>  So could be something not correctly honouring LIB_INSTALL_DIR and
>  or LIB_SUFFIX variables.
>
>  Regards,
>  Daniel 
In
https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...

I can read

CMake Warning (dev) at /usr/share/cmake/Modules/GNUInstallDirs.cmake:237 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.

So I guess it is a bug in
https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists.txt
If you have any idea how I could patch it, I would be happy to make a
pull request

[Germano Massullo]

Il 06/03/2018 16:19, Germano Massullo ha scritto:
>  Il 06/03/2018 15:50, Daniel P. Berrangé ha scritto:
> > On Tue, Mar 06, 2018 at 03:46:38PM +0100, Germano Massullo wrote:
> >> Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
> >>> %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
> >>> to "/usr/lib64", but your app is installing files into
> "/usr/lib"
> >>> instead.
> >> I suspected this, but I found no hardcoded paths in
> >> https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
> >> so I don't understand why it installs in /usr/lib
> > In the specfile it has  %{cmake} which expands to
> >
> >   ...some compiler flags stuff...
> >   /usr/bin/cmake \
> >         -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
> >         -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
> >         -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
> >         -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
> >         -DCMAKE_INSTALL_PREFIX:PATH=/usr \
> >         -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
> >         -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
> >         -DSYSCONF_INSTALL_DIR:PATH=/etc \
> >         -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
> > %if "lib64" == "lib64" 
> >         -DLIB_SUFFIX=64 \
> > %endif 
> >         -DBUILD_SHARED_LIBS:BOOL=ON
> >
> > So could be something not correctly honouring LIB_INSTALL_DIR and
> > or LIB_SUFFIX variables.
> >
> > Regards,
> > Daniel
>  In
>
> https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...
>
>  I can read
>
>  CMake Warning (dev) at /usr/share/cmake/Modules/GNUInstallDirs.cmake:237 (message):
>    Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
>    target architecture is known.  Please enable at least one language before
>    including GNUInstallDirs.
>
>  So I guess it is a bug in
>  https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists.txt
>  If you have any idea how I could patch it, I would be happy to make a
>  pull request 
I tried to manually build the software using upstream procedure, and I
got the same errors, so I filled a bugreport
https://github.com/open-eid/firefox-pkcs11-loader/issues/10

[Daniel P. Berrangé]

On Tue, Mar 06, 2018 at 04:19:48PM +0100, Germano Massullo wrote:
>  Il 06/03/2018 15:50, Daniel P. Berrangé ha scritto:
>  > On Tue, Mar 06, 2018 at 03:46:38PM +0100, Germano Massullo wrote:
>  >> Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
>  >>> %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
>  >>> to "/usr/lib64", but your app is installing files into
> "/usr/lib"
>  >>> instead.
>  >> I suspected this, but I found no hardcoded paths in
>  >>
> https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
>  >> so I don't understand why it installs in /usr/lib
>  > In the specfile it has  %{cmake} which expands to
>  >
>  >   ...some compiler flags stuff...
>  >   /usr/bin/cmake \
>  >         -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
>  >         -DCMAKE_INSTALL_PREFIX:PATH=/usr \
>  >         -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
>  >         -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
>  >         -DSYSCONF_INSTALL_DIR:PATH=/etc \
>  >         -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
>  > %if "lib64" == "lib64" 
>  >         -DLIB_SUFFIX=64 \
>  > %endif 
>  >         -DBUILD_SHARED_LIBS:BOOL=ON
>  >
>  > So could be something not correctly honouring LIB_INSTALL_DIR and
>  > or LIB_SUFFIX variables.
>  >
>  > Regards,
>  > Daniel
>  In
>
> https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...
>  
>  I can read
>  
>  CMake Warning (dev) at /usr/share/cmake/Modules/GNUInstallDirs.cmake:237 (message):
>    Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
>    target architecture is known.  Please enable at least one language before
>    including GNUInstallDirs.
>  
>  So I guess it is a bug in
>  https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists.txt
>  If you have any idea how I could patch it, I would be happy to make a
>  pull request 
Afraid I stay away from CMake in general so leave that upto someone else
to suggest a fix

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Dennis Gilmore]

El mar, 06-03-2018 a las 15:29 +0100, Germano Massullo escribió:
>  During package firefox-pkcs11-loader build, the following two spec
>  file
>  lines
>  
>  %dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
>  %_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  and also this variant
>  
>  %dir %{_libdir}/mozilla/pkcs11-modules/
>  %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  
>  lead to errors
>  
>  Directory not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
>  3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
>  File not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
>  3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-
>  modules/onepinopenscpkcs11.json 
noarch only builds do not have %{_lib} or %{_libdir} defined 

Dennis

[Germano Massullo]

Il 06/03/2018 16:35, Dennis Gilmore ha scritto:
>  El mar, 06-03-2018 a las 15:29 +0100, Germano Massullo escribió:
> > During package firefox-pkcs11-loader build, the following two spec
> > file
> > lines
> >
> > %dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
> > %_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> >
> > and also this variant
> >
> > %dir %{_libdir}/mozilla/pkcs11-modules/
> > %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> >
> > lead to errors
> >
> > Directory not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
> > 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
> > File not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
> > 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-
> > modules/onepinopenscpkcs11.json
>  noarch only builds do not have %{_lib} or %{_libdir} defined 
>  
Thank you very much, I solved with
%{cmake} . -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

Could you please leave a feedback about the comment I am going to attach
in the spec file?

# in noarch builds, %%{_libdir} is not defined in cmake, so the default
# installation would try installing for example
# file onepinopenscpkcs11.json
# into /usr/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
# even if the system architecture is 64bit. This will lead to errors because
# the %%files entry
# %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
# would be defined as
# /usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json
# that is different from the previous one

[Dennis Gilmore]

El mar, 06-03-2018 a las 17:20 +0100, Germano Massullo escribió:
>  Il 06/03/2018 16:35, Dennis Gilmore ha scritto:
>  > El mar, 06-03-2018 a las 15:29 +0100, Germano Massullo escribió:
>  > > During package firefox-pkcs11-loader build, the following two
>  > > spec
>  > > file
>  > > lines
>  > > 
>  > > %dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
>  > > %_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  > > 
>  > > and also this variant
>  > > 
>  > > %dir %{_libdir}/mozilla/pkcs11-modules/
>  > > %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  > > 
>  > > lead to errors
>  > > 
>  > > Directory not found: /builddir/build/BUILDROOT/firefox-pkcs11-
>  > > loader-
>  > > 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
>  > > File not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
>  > > 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-
>  > > modules/onepinopenscpkcs11.json
>  > 
>  > noarch only builds do not have %{_lib} or %{_libdir} defined 
>  > 
>  
>  Thank you very much, I solved with
>  %{cmake} . -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}
>  
>  Could you please leave a feedback about the comment I am going to
>  attach
>  in the spec file?
>  
>  # in noarch builds, %%{_libdir} is not defined in cmake, so the
>  default
>  # installation would try installing for example
>  # file onepinopenscpkcs11.json
>  # into /usr/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # even if the system architecture is 64bit. This will lead to errors
>  because
>  # the %%files entry
>  # %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # would be defined as
>  # /usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # that is different from the previous one 
so the content should always be in /usr/lib for a noarch build as it
has to work for cases where _lib is both lib64 and lib  if the content
needs to be in /usr/lib64/mozilla/pkcs11-modules on systems with lib64
as the value for _lib then your content and package needs to be
archful. I am concerned that you are not going to get the outcome you
expect here.


Dennis

[Germano Massullo]

Il 06/03/2018 17:42, Dennis Gilmore ha scritto:
>  El mar, 06-03-2018 a las 17:20 +0100, Germano Massullo escribió:
> > Il 06/03/2018 16:35, Dennis Gilmore ha scritto:
> >> El mar, 06-03-2018 a las 15:29 +0100, Germano Massullo escribió:
> >>> During package firefox-pkcs11-loader build, the following two
> >>> spec
> >>> file
> >>> lines
> >>>
> >>> %dir %_prefix/%{_lib}/mozilla/pkcs11-modules/
> >>> %_prefix/%{_lib}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> >>>
> >>> and also this variant
> >>>
> >>> %dir %{_libdir}/mozilla/pkcs11-modules/
> >>> %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> >>>
> >>> lead to errors
> >>>
> >>> Directory not found: /builddir/build/BUILDROOT/firefox-pkcs11-
> >>> loader-
> >>> 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-modules
> >>> File not found: /builddir/build/BUILDROOT/firefox-pkcs11-loader-
> >>> 3.13.0-2.fc27.x86_64/usr/lib64/mozilla/pkcs11-
> >>> modules/onepinopenscpkcs11.json
> >> noarch only builds do not have %{_lib} or %{_libdir} defined 
> >>
> > Thank you very much, I solved with
> > %{cmake} . -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}
> >
> > Could you please leave a feedback about the comment I am going to
> > attach
> > in the spec file?
> >
> > # in noarch builds, %%{_libdir} is not defined in cmake, so the
> > default
> > # installation would try installing for example
> > # file onepinopenscpkcs11.json
> > # into /usr/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> > # even if the system architecture is 64bit. This will lead to errors
> > because
> > # the %%files entry
> > # %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> > # would be defined as
> > # /usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json
> > # that is different from the previous one
>  so the content should always be in /usr/lib for a noarch build as it
>  has to work for cases where _lib is both lib64 and lib  if the content
>  needs to be in /usr/lib64/mozilla/pkcs11-modules on systems with lib64
>  as the value for _lib then your content and package needs to be
>  archful. I am concerned that you are not going to get the outcome you
>  expect here. 
Thank you Dennis. Therefore I think that rpmlint messages should be
improved about noarch packages.
I started working on %{_lib} / %{_libdir} on firefox-pkcs11-loader spec
file because originally there were %files entries like
%_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
and rpmlint returned errors like

firefox-pkcs11-loader.src:43: E: hardcoded-library-path in
%_prefix/lib/mozilla/pkcs11-modules/
firefox-pkcs11-loader.src:44: E: hardcoded-library-path in
%_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json

So I started working to fix them....
Source:
https://taskotron.fedoraproject.org/artifacts/all/46067844-18bd-11e8-9d96...
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4558f54f10

[Germano Massullo]

Il 06/03/2018 18:17, Germano Massullo ha scritto:
>  Thank you Dennis. Therefore I think that rpmlint messages should be
>  improved about noarch packages.
>  I started working on %{_lib} / %{_libdir} on firefox-pkcs11-loader spec
>  file because originally there were %files entries like
>  %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  and rpmlint returned errors like
>
>  firefox-pkcs11-loader.src:43: E: hardcoded-library-path in
> %_prefix/lib/mozilla/pkcs11-modules/
>  firefox-pkcs11-loader.src:44: E: hardcoded-library-path in
> %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>
>  So I started working to fix them....
>  Source:
>
> https://taskotron.fedoraproject.org/artifacts/all/46067844-18bd-11e8-9d96...
>  https://bodhi.fedoraproject.org/updates/FEDORA-2018-4558f54f10 
An interesting discussion about %{_lib} and noarch packages
https://pagure.io/packaging-committee/issue/203

[Björn Persson]

Germano Massullo wrote:
>  # in noarch builds, %%{_libdir} is not defined in cmake, so the
> default
>  # installation would try installing for example
>  # file onepinopenscpkcs11.json
>  # into /usr/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # even if the system architecture is 64bit. This will lead to errors because
>  # the %%files entry
>  # %{_libdir}/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # would be defined as
>  # /usr/lib64/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>  # that is different from the previous one 
onepin-opensc-pkcs11.so is an architecture-dependent file. Its content
is different on different processor architectures, and it's also
installed with different pathnames on different architectures.
Therefore anything that refers to the file by its absolute pathname is
also architecture-dependent.

When you insert the pathname into onepinopenscpkcs11.json, that makes
the JSON file architecture-dependent. It must contain different
pathnames on different architectures. A noarch package cannot contain
such a file. "noarch" means that the package's content is exactly the
same on all architectures.

To make a noarch package you must find a way to have a relative
pathname in onepinopenscpkcs11.json – one that contains neither "lib"
nor "lib64" – and install the file in a directory that doesn't depend
on _libdir, perhaps somewhere under %{_datadir}/mozilla.

If that isn't possible, then you must remove "BuildArch: noarch" from
firefox-pkcs11-loader.spec, allowing the package to differ between
architectures, and use _libdir where applicable.

Björn Persson

[Germano Massullo]

Thank you Björn you clarified all my remaining doubts!
I will remove "BuildArch: noarch" because in my opinion is the best
solution. Then I will resume the %{_libdir} macros