Re: %{_lib} leads to dir not found, whereas lib works fine (firefox-pkcs11-loader)

[Daniel P. Berrangé]

On Tue, Mar 06, 2018 at 04:19:48PM +0100, Germano Massullo wrote:
>  Il 06/03/2018 15:50, Daniel P. Berrangé ha scritto:
>  > On Tue, Mar 06, 2018 at 03:46:38PM +0100, Germano Massullo wrote:
>  >> Il 06/03/2018 15:34, Daniel P. Berrangé ha scritto:
>  >>> %{_lib} expands to 'lib64' on x86_64, and %{_libdir} thus expands
>  >>> to "/usr/lib64", but your app is installing files into
> "/usr/lib"
>  >>> instead.
>  >> I suspected this, but I found no hardcoded paths in
>  >>
> https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists....
>  >> so I don't understand why it installs in /usr/lib
>  > In the specfile it has  %{cmake} which expands to
>  >
>  >   ...some compiler flags stuff...
>  >   /usr/bin/cmake \
>  >         -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
>  >         -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
>  >         -DCMAKE_INSTALL_PREFIX:PATH=/usr \
>  >         -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
>  >         -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
>  >         -DSYSCONF_INSTALL_DIR:PATH=/etc \
>  >         -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
>  > %if "lib64" == "lib64" 
>  >         -DLIB_SUFFIX=64 \
>  > %endif 
>  >         -DBUILD_SHARED_LIBS:BOOL=ON
>  >
>  > So could be something not correctly honouring LIB_INSTALL_DIR and
>  > or LIB_SUFFIX variables.
>  >
>  > Regards,
>  > Daniel
>  In
>
> https://copr-be.cloud.fedoraproject.org/results/germano/firefox-pkcs11-lo...
>  
>  I can read
>  
>  CMake Warning (dev) at /usr/share/cmake/Modules/GNUInstallDirs.cmake:237 (message):
>    Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
>    target architecture is known.  Please enable at least one language before
>    including GNUInstallDirs.
>  
>  So I guess it is a bug in
>  https://github.com/open-eid/firefox-pkcs11-loader/blob/master/CMakeLists.txt
>  If you have any idea how I could patch it, I would be happy to make a
>  pull request 
Afraid I stay away from CMake in general so leave that upto someone else
to suggest a fix

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|