Undetected ABI change in libkcapi (rawhide)

[Simo Sorce]

Hello,
I just rebased libkcapi in Rawhide, without realizing there was an ABI
change.
The ABI change should affect only S390 but I am discussing with the
author on handling this better given the library does use symbol
versioning.

So I may "revert" this ABI change in short order.

Apologies if any build will have issues between today and when I will
be able to handle it, if you have any concerns please let me know.

Simo.

-- 
Simo Sorce
RHEL Crypto Team
Red Hat, Inc

[Ondrej Mosnacek]

On Mon, Jul 12, 2021 at 4:32 PM Simo Sorce <simo(a)redhat.com&gt; wrote:
>  Hello,
>  I just rebased libkcapi in Rawhide, without realizing there was an ABI
>  change.
>  The ABI change should affect only S390 but I am discussing with the
>  author on handling this better given the library does use symbol
>  versioning. 
It is already being discussed here:
https://github.com/smuellerDD/libkcapi/issues/115

Please in the future at least look at open pull requests before you
push something to dist-git. I had started the rebase to 1.3 already
[1], but was holding it off because of the ABI change (though to be
fair I didn't note that in the PR).

>  So I may "revert" this ABI change in short order.
>
>  Apologies if any build will have issues between today and when I will
>  be able to handle it, if you have any concerns please let me know. 
AFAIK, no other package in Fedora currently links against libkcapi, so
there should be no impact on other packages.

[1] https://src.fedoraproject.org/rpms/libkcapi/pull-request/24

--
Ondrej Mosnacek
Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.

[Simo Sorce]

On Mon, 2021-07-12 at 16:53 +0200, Ondrej Mosnacek wrote:
>  On Mon, Jul 12, 2021 at 4:32 PM Simo Sorce <simo(a)redhat.com&gt;
> wrote:
>  > 
>  > Hello,
>  > I just rebased libkcapi in Rawhide, without realizing there was an ABI
>  > change.
>  > The ABI change should affect only S390 but I am discussing with the
>  > author on handling this better given the library does use symbol
>  > versioning.
>  
>  It is already being discussed here:
>  https://github.com/smuellerDD/libkcapi/issues/115
>   
I have been discussing privately with Stephan, good to know there is  a
public issue.

>  Please in the future at least look at open pull requests before you
>  push something to dist-git. I had started the rebase to 1.3 already
>  [1], but was holding it off because of the ABI change (though to be
>  fair I didn't note that in the PR). 
Sorry did not know you were working on this, I was helping Sahana
taking up some slack, and I am new to the package.

>  > So I may "revert" this ABI change in short order.
>  > 
>  > Apologies if any build will have issues between today and when I will
>  > be able to handle it, if you have any concerns please let me know.
>  
>  AFAIK, no other package in Fedora currently links against libkcapi, so
>  there should be no impact on other packages.
>  
>  [1] https://src.fedoraproject.org/rpms/libkcapi/pull-request/24 
That makes it easier, but I still do not want to break potential users.

Simo.

-- 
Simo Sorce
RHEL Crypto Team
Red Hat, Inc