An easy way to redefine configure?

[Susi Lehtola]

Hi,


related to the MPI packaging draft
 http://www.fedoraproject.org/wiki/PackagingDrafts/MPI
I have a need to redefine %configure to use ../configure instead
of ./configure to do off-root builds.


So far I've tried

%global dconfigure %(echo "%{configure}" | sed
's|./configure|../configure|g')

but calling

%dconfigure

gives me

+ CFLAGS=-O2
+ -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic
/var/tmp/rpm-tmp.mvjW71: line 42: -g: command not found


What's the correct way to do this?
-- 
Jussi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org

[Michael Schwendt]

On Tue, 04 Aug 2009 12:14:34 +0300, Jussi wrote:

>  Hi,
>  
>  
>  related to the MPI packaging draft
>   http://www.fedoraproject.org/wiki/PackagingDrafts/MPI
>  I have a need to redefine %configure to use ../configure instead
>  of ./configure to do off-root builds.
>  
>  
>  So far I've tried
>  
>  %global dconfigure %(echo "%{configure}" | sed
>  's|./configure|../configure|g')
>  
>  but calling
>  
>  %dconfigure
>  
>  gives me
>  
>  + CFLAGS=-O2
>  + -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
>  --param=ssp-buffer-size=4 -m64 -mtune=generic
>  /var/tmp/rpm-tmp.mvjW71: line 42: -g: command not found
>  
>  
>  What's the correct way to do this? 
The easy way (as in Subject) or the correct way?
Here's an easy way:

echo '%configure' | sed 's!./configure!../configure!g' > my-configure
sh my-configure

[Mattias Ellert]

tis 2009-08-04 klockan 12:14 +0300 skrev Jussi Lehtola:
>  Hi,
>  
>  
>  related to the MPI packaging draft
>   http://www.fedoraproject.org/wiki/PackagingDrafts/MPI
>  I have a need to redefine %configure to use ../configure instead
>  of ./configure to do off-root builds.
>  
>  
>  So far I've tried
>  
>  %global dconfigure %(echo "%{configure}" | sed
> 's|./configure|../configure|g')
>  
>  but calling
>  
>  %dconfigure
>  
>  gives me
>  
>  + CFLAGS=-O2
>  + -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
>  --param=ssp-buffer-size=4 -m64 -mtune=generic
>  /var/tmp/rpm-tmp.mvjW71: line 42: -g: command not found
>  
>  
>  What's the correct way to do this? 
%global dconfigure %(rpm -E %%configure | sed 's!./configure!../configure!g')
%dconfigure

	Mattias

[Susi Lehtola]

On Tue, 2009-08-04 at 13:42 +0200, Mattias Ellert wrote:
>  > What's the correct way to do this?
>  
>  %global dconfigure %(rpm -E %%configure | sed 's!./configure!../configure!g')
>  %dconfigure 
This works, but isn't it bad style to call rpm from within a spec
file..?
-- 
Jussi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org

[Ralf Corsepius]

On 08/04/2009 02:01 PM, Jussi Lehtola wrote:
>  On Tue, 2009-08-04 at 13:42 +0200, Mattias Ellert wrote:
> >> What's the correct way to do this?
> >
> > %global dconfigure %(rpm -E %%configure | sed
> 's!./configure!../configure!g')
> > %dconfigure
>
>  This works, but isn't it bad style to call rpm from within a spec
>  file..? 
Correct - This is not allowed in Fedora.

In occasions like yours, I normally use a manually expanded ../configure 
....

IMO, it's much cleaner and less error prone than to mess around with 
%configure.

Ralf

[Fabian Deutsch]

Am Dienstag, den 04.08.2009, 14:15 +0200 schrieb Ralf Corsepius:
>  On 08/04/2009 02:01 PM, Jussi Lehtola wrote:
>  > On Tue, 2009-08-04 at 13:42 +0200, Mattias Ellert wrote:
>  >>> What's the correct way to do this?
>  >>
>  >> %global dconfigure %(rpm -E %%configure | sed
>  's!./configure!../configure!g')
>  >> %dconfigure
>  >
>  > This works, but isn't it bad style to call rpm from within a spec
>  > file..?
>  Correct - This is not allowed in Fedora.
>  
>  In occasions like yours, I normally use a manually
>  expanded ../configure 
>  ....
>  
>  IMO, it's much cleaner and less error prone than to mess around with 
>  %configure. 
I'd also recommend this way, just run

../configure ...

and pass all necessary flags via arguments.

- fabian

[Andreas Schwab]

Jussi Lehtola <jussilehtola(a)fedoraproject.org&gt; writes:

>  So far I've tried
>
>  %global dconfigure %(echo "%{configure}" | sed
>  's|./configure|../configure|g') 
Since %configure expands to a text containing double quotes this gets
the quoting wrong.  Using single quotes work here (albeit still not
general enough):

%global dconfigure %(printf %%s '%configure' | sed
's!\./configure!../configure!g')

Andreas.

-- 
Andreas Schwab, schwab(a)redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

[Susi Lehtola]

On Tue, 2009-08-04 at 14:47 +0200, Andreas Schwab wrote:
>  Jussi Lehtola <jussilehtola(a)fedoraproject.org&gt; writes:
>  
>  > So far I've tried
>  >
>  > %global dconfigure %(echo "%{configure}" | sed
>  > 's|./configure|../configure|g')
>  
>  Since %configure expands to a text containing double quotes this gets
>  the quoting wrong.  Using single quotes work here (albeit still not
>  general enough):
>  
>  %global dconfigure %(printf %%s '%configure' | sed
> 's!\./configure!../configure!g') 
Thanks, this was what I was looking for.
-- 
Jussi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org

[Adam Williamson]

On Tue, 2009-08-04 at 15:58 +0300, Jussi Lehtola wrote:
>  On Tue, 2009-08-04 at 14:47 +0200, Andreas Schwab wrote:
>  > Jussi Lehtola <jussilehtola(a)fedoraproject.org&gt; writes:
>  > 
>  > > So far I've tried
>  > >
>  > > %global dconfigure %(echo "%{configure}" | sed
>  > > 's|./configure|../configure|g')
>  > 
>  > Since %configure expands to a text containing double quotes this gets
>  > the quoting wrong.  Using single quotes work here (albeit still not
>  > general enough):
>  > 
>  > %global dconfigure %(printf %%s '%configure' | sed
> 's!\./configure!../configure!g')
>  
>  Thanks, this was what I was looking for. 
I feel like I've mentioned this before, but just in case...in Mandriva,
the configure location is not hard-coded but is an environment variable
(CONFIGURE_TOP) with a default value of ./configure . If you need to run
configure from a different location, you just redefine CONFIGURE_TOP in
the spec file. I've found that useful in two builds, myself.

I think the last time this came up, someone liked the idea but suggested
a better implementation, and then the thread just died...

-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
http://www.happyassassin.net

[Alexander Boström]

tis 2009-08-04 klockan 12:14 +0300 skrev Jussi Lehtola:

>  What's the correct way to do this? 
I don't know about correct, but this should work:

mkdir foo
cd foo
cat >configure <<'EOF'
#!/bin/bash
exec ../configure "$@"
EOF
chmod 755 configure
%configure

/abo