Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
------- Additional Comments From updates(a)fedoraproject.org 2008-05-07 01:57 EST -------
brettfont-fonts-20080506-1.fc8 has been submitted as an update for Fedora 8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
------- Additional Comments From updates(a)fedoraproject.org 2008-05-07 01:51 EST -------
brettfont-fonts-20080506-1.fc9 has been submitted as an update for Fedora 9
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
kevin(a)tummy.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |nicolas.mailhot(a)laposte.net
Status|NEW |ASSIGNED
Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin(a)tummy.com 2008-05-06 20:20 EST -------
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
jonstanley(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
------- Additional Comments From jonstanley(a)gmail.com 2008-05-06 18:25 EST -------
New Package CVS Request
=======================
Package Name: brettfont-fonts
Short Description: A handwriting font
Owners: jstanley
Branches: F-8 F-9 EL-4 EL-5
InitialCC:
Cvsextras Commits: yes
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
------- Additional Comments From jonstanley(a)gmail.com 2008-05-06 18:22 EST -------
Yeah, I thought I changed the name to something more palatable in the %prep,
which I will change to %install per your suggestion. Should I just use today as
the version, or is there some way to tell from the TTF metadata (or just use the
date it was posted upstream?). Look for a new version and CVS checkin tonight.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: icelandic-fonts - Icelandic Magical Staves
https://bugzilla.redhat.com/show_bug.cgi?id=445261
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-05-06 17:39 EST -------
On the technical side same comments apply as for Brett font.
*However* please contact the author and make sure he's not just digitized and
transformed without authorization material posted on www.galdrasyning.is. If he
actually drew the shapes himself from scratch that's probably ok.
Thank you for packaging a few fonts!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-05-06 17:29 EST -------
When you're done please do not forget moving it to the "packaged" part of the
fonts pipeline, and also referencing (as optional) in the @fonts comps group
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
nicolas.mailhot(a)laposte.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-05-06 17:28 EST -------
Only looked at the spec since the SRPM is not reachable.
Anyway:
1. Spec is a textbook copy of the official template → OK
2. Source is correctly licensed and from a trusty provider → OK
Approved
Some optional comments
1. you do not need the cp in %prep. Just use %{SOURCE0} in %install directly
(and save a few electrons)
2. for releases ≥ F9 you can drop the -f in fc-cache
3. Upstream TTF file name is fugly. Fontconfig will work the same no matter what
of course but you should consider changing it to something better in the install
ttf line
4. it's somewhat dangerous to use 1.0 as version for upstreams with lax release
discipline. They sometimes update the file in-place later without changing the
TTF metadata version (1.0 is the default for the version field in many tools,
thus unfortunately it does not always mean the author really decided this was
release 1.0). For this reason I've used timestamps as versions in the gfs font
packages
5. bonus points if you can get upstream to release its font in a nice versioned
archive with detached license text.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: icelandic-fonts - Icelandic Magical Staves
https://bugzilla.redhat.com/show_bug.cgi?id=445261
jonstanley(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-fonts-bugs-
| |list(a)redhat.com
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: brettfont-fonts - A handwriting font
https://bugzilla.redhat.com/show_bug.cgi?id=445279
nicolas.mailhot(a)laposte.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-fonts-bugs-
| |list(a)redhat.com
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.