rpmbuild

[Patrick Dupre]

Hello,

I am trying to patch gnuplot with
https://sourceforge.net/p/gnuplot/patches/694/

However, it fails for several reasons,
The first one is that the patch does not apply to last version 
of tabulate.c (maybe to a previous one).
Then a fixed directly the tabulate.c file

How can generate the package directly from the SOURCES?
with rpmbuild
I try to modify the .spc file by removing the 
#%patch0 -p1 -b .refto
#%patch1 -p1 -b .font
#%patch3 -p1 -b .plot-sigsegv
#%patch4 -p1 -b .isinglethread
#%patch5 -p1 -b .checkint
#%patch6 -p1 -b .tabulate   # This fails

But it does not work.
because I guess that it does not compile my new sources but the old ones.

Actually, %patch6 -p1 -b .tabulate
would fails
patch -p0 gnuplot-5.0.6a-tabulate.patch (manually)
would be OK, but it fails from the .spec file

Thank for your help.

===========================================================================
 Patrick DUPRÉ                                 | | email: pdupre(a)gmx.com
 Laboratoire de Physico-Chimie de l'Atmosphère | |
 Université du Littoral-Côte d'Opale           | |
 Tel.  (33)-(0)3 28 23 76 12                   | | Fax: [phone]
 189A, avenue Maurice Schumann                 | | 59140 Dunkerque, France
===========================================================================

[Rick Stevens]

On 07/18/2017 09:07 AM, Patrick Dupre wrote:
>  Hello,
>  
>  I am trying to patch gnuplot with
>  https://sourceforge.net/p/gnuplot/patches/694/
>  
>  However, it fails for several reasons,
>  The first one is that the patch does not apply to last version 
>  of tabulate.c (maybe to a previous one).
>  Then a fixed directly the tabulate.c file
>  
>  How can generate the package directly from the SOURCES?
>  with rpmbuild
>  I try to modify the .spc file by removing the 
>  #%patch0 -p1 -b .refto
>  #%patch1 -p1 -b .font
>  #%patch3 -p1 -b .plot-sigsegv
>  #%patch4 -p1 -b .isinglethread
>  #%patch5 -p1 -b .checkint
>  #%patch6 -p1 -b .tabulate   # This fails
>  
>  But it does not work.
>  because I guess that it does not compile my new sources but the old ones.
>  
>  Actually, %patch6 -p1 -b .tabulate
>  would fails
>  patch -p0 gnuplot-5.0.6a-tabulate.patch (manually)
>  would be OK, but it fails from the .spec file 
Patrick, it's very difficult to troubleshoot many of your issues as you
(and many others) rarely provide basic information other than "such-
and-such fails". This is somewhat like taking your car to a mechanic,
saying "the car is broken" and then walking away. How is it broken? What
doesn't work? Sorta hard on the mechanic.

In this case, you simply say "this patch fails" but do not include the
error messages involved in the failure. I'm not trying to point you out
specifically, but this really goes for anyone requesting help here on
the list...we need the context around the problem (error messages, log
entries, etc.). Otherwise we're trying to troubleshoot in a vacuum which
rarely ends in a viable solution.

In a nutshell, patch files are generally quite specific. They direct
"patch" to look for a pattern to match starting at a specific line in
the original file. If the original file you're trying to patch doesn't
correspond (fairly) closely to the one the patch was created for (e.g.
extra lines, punctuation changes such as tabs, etc.), yes the patch will
likely fail. We need the output of the patch command to tell you why
it's failing. As to how to fix it, you may have to manually patch the
file. If you do that, you can create a new patchfile for that patch on
that file by running "diff" on the pre-patched file and the patched
file. I'm sure the package maintainers would like to have it.
----------------------------------------------------------------------
- Rick Stevens, Systems Engineer, AllDigital    ricks(a)alldigital.com -
- AIM/Skype: therps2        ICQ: 226437340           Yahoo: origrps2 -
-                                                                    -
-                Huked on foniks reely wurked for me!                -
----------------------------------------------------------------------

[John Pilkington]

On 18/07/17 17:07, Patrick Dupre wrote:
>  Hello,
>  
>  I am trying to patch gnuplot with
>  https://sourceforge.net/p/gnuplot/patches/694/
>  
>  However, it fails for several reasons,
>  The first one is that the patch does not apply to last version
>  of tabulate.c (maybe to a previous one).
>  Then a fixed directly the tabulate.c file
>  
>  How can generate the package directly from the SOURCES?
>  with rpmbuild
>  I try to modify the .spc file by removing the
>  #%patch0 -p1 -b .refto
>  #%patch1 -p1 -b .font
>  #%patch3 -p1 -b .plot-sigsegv
>  #%patch4 -p1 -b .isinglethread
>  #%patch5 -p1 -b .checkint
>  #%patch6 -p1 -b .tabulate   # This fails
>  
>  But it does not work.
>  because I guess that it does not compile my new sources but the old ones.
>  
>  Actually, %patch6 -p1 -b .tabulate
>  would fails
>  patch -p0 gnuplot-5.0.6a-tabulate.patch (manually)
>  would be OK, but it fails from the .spec file
>  
>  Thank for your help. 
I suggest you start from the gnuplot srpm
# put package in ~/rpmbuild/SRPMS/foo.src.rpm

$  rpm -ihv foo.src.rpm
$  rpmbuild --nodeps -bp /where/the/spec/files/land/foo.spec

$[wherever SPECS]$ rpmbuild --nodeps -bp  foo.spec

# and look for the patched source in ~/rpmbuild/BUILD/

Put your patch in SOURCES

Then add to the .spec file

Patch7:  tabulate.patch

and

%patch7 -p1 -b .tabulate

and update the changelog

and build, preferably using mock.  First the new srpm, then the rpm.

[John Pilkington]

On 18/07/17 18:07, John Pilkington wrote:
>  On 18/07/17 17:07, Patrick Dupre wrote:
> > Hello,
> >
> > I am trying to patch gnuplot with
> > https://sourceforge.net/p/gnuplot/patches/694/
> >
> > However, it fails for several reasons,
> > The first one is that the patch does not apply to last version
> > of tabulate.c (maybe to a previous one).
> > Then a fixed directly the tabulate.c file
> >
> > How can generate the package directly from the SOURCES?
> > with rpmbuild
> > I try to modify the .spc file by removing the
> > #%patch0 -p1 -b .refto
> > #%patch1 -p1 -b .font
> > #%patch3 -p1 -b .plot-sigsegv
> > #%patch4 -p1 -b .isinglethread
> > #%patch5 -p1 -b .checkint
> > #%patch6 -p1 -b .tabulate   # This fails
> >
> > But it does not work.
> > because I guess that it does not compile my new sources but the old ones.
> >
> > Actually, %patch6 -p1 -b .tabulate
> > would fails
> > patch -p0 gnuplot-5.0.6a-tabulate.patch (manually)
> > would be OK, but it fails from the .spec file
> >
> > Thank for your help.
>  
>  I suggest you start from the gnuplot srpm
>  # put package in ~/rpmbuild/SRPMS/foo.src.rpm
>  
>  $  rpm -ihv foo.src.rpm
>  $  rpmbuild --nodeps -bp /where/the/spec/files/land/foo.spec
>  
>  $[wherever SPECS]$ rpmbuild --nodeps -bp  foo.spec
>  
>  # and look for the patched source in ~/rpmbuild/BUILD/
>  
>  Put your patch in SOURCES
>  
>  Then add to the .spec file
>  
>  Patch7:  tabulate.patch
>  
>  and
>  
>  %patch7 -p1 -b .tabulate
>  
>  and update the changelog
>  
>  and build, preferably using mock.  First the new srpm, then the rpm.
>   
This was a tentative reply that got sent 'by accident.'  Something like 
it has worked for me (with other packages) in the past.

John P

[Todd Zullinger]

Patrick Dupre wrote:
>  I am trying to patch gnuplot with 
>  https://sourceforge.net/p/gnuplot/patches/694/
>
>  However, it fails for several reasons, 
>  The first one is that the patch does not apply to last version 
>  of tabulate.c (maybe to a previous one). 
>  Then a fixed directly the tabulate.c file
>
>  How can generate the package directly from the SOURCES? 
>  with rpmbuild 
>  I try to modify the .spc file by removing the 
>  #%patch0 -p1 -b .refto 
>  #%patch1 -p1 -b .font 
>  #%patch3 -p1 -b .plot-sigsegv 
>  #%patch4 -p1 -b .isinglethread 
>  #%patch5 -p1 -b .checkint 
>  #%patch6 -p1 -b .tabulate   # This fails
>
>  But it does not work. 
>  because I guess that it does not compile my new sources but the old ones.
>
>  Actually, %patch6 -p1 -b .tabulate would fails  
-p1 is used here

>  patch -p0 gnuplot-5.0.6a-tabulate.patch (manually) 
>  would be OK, but it fails from the .spec file 
And -p0 is used here.

The argument to -p is the number of leading directories to strip off 
the paths in the patch.  It's fairly important to use the right value.

Whether that's the main issue or not isn't clear, as you didn't 
include any of the rpmbuild output from the failure.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
So its hurry! Hurry! Step right up, it's a matter of life or death
The sun is going down and the moon is just holding its breath.

[Bill Shirley]

I just recently build a spec file for ndppd (NDP Proxy Daemon) and found out
you can't comment out by using a single # in a spec file if it is a % command.
It has to be like this:
#%%configure

ndppd: https://github.com/DanielAdolfsson/ndppd

Do not build rpm's as root.  Set up a build tree using a non-root uid.  My notes::
as root:
yum/dnf install @development-tools
yum/dnf install fedora-packager

add bill to mock group in /etc/group

as bill:
rpmdev-setuptree
rpmdev-newspec ndp-proxy

I used 'rpmdev-newspec' because ndppd doesn't have a .spec file.

Bill


On 7/18/2017 12:07 PM, Patrick Dupre wrote:
>  Hello,
>
>  I am trying to patch gnuplot with
>  https://sourceforge.net/p/gnuplot/patches/694/
>
>  However, it fails for several reasons,
>  The first one is that the patch does not apply to last version
>  of tabulate.c (maybe to a previous one).
>  Then a fixed directly the tabulate.c file
>
>  How can generate the package directly from the SOURCES?
>  with rpmbuild
>  I try to modify the .spc file by removing the
>  #%patch0 -p1 -b .refto
>  #%patch1 -p1 -b .font
>  #%patch3 -p1 -b .plot-sigsegv
>  #%patch4 -p1 -b .isinglethread
>  #%patch5 -p1 -b .checkint
>  #%patch6 -p1 -b .tabulate   # This fails
>
>  But it does not work.
>  because I guess that it does not compile my new sources but the old ones.
>
>  Actually, %patch6 -p1 -b .tabulate
>  would fails
>  patch -p0 gnuplot-5.0.6a-tabulate.patch (manually)
>  would be OK, but it fails from the .spec file
>
>  Thank for your help.
>
>  ===========================================================================
>    Patrick DUPRÉ                                 | | email: pdupre(a)gmx.com
>    Laboratoire de Physico-Chimie de l'Atmosphère | |
>    Université du Littoral-Côte d'Opale           | |
>    Tel.  (33)-(0)3 28 23 76 12                   | | Fax: [phone]
>    189A, avenue Maurice Schumann                 | | 59140 Dunkerque, France
>  ===========================================================================
>  _______________________________________________
>  users mailing list -- users(a)lists.fedoraproject.org
>  To unsubscribe send an email to users-leave(a)lists.fedoraproject.org

[Matthew Miller]

On Wed, Jul 19, 2017 at 12:50:50AM -0400, Bill Shirley wrote:
>  I just recently build a spec file for ndppd (NDP Proxy Daemon) and
> found out
>  you can't comment out by using a single # in a spec file if it is a % command.
>  It has to be like this:
>  #%%configure 
Yeah, this is because macros are expanded even in comments. It works
okay for single-line macros, but fails badly for multiple-line ones,
since then only the first line ends up commented out.



-- 
Matthew Miller
<mattdm(a)fedoraproject.org&gt;
Fedora Project Leader